Skip to content

Expand ownership of Version Bump related files #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Expand ownership of Version Bump related files #6877

merged 1 commit into from
Apr 22, 2025

Conversation

bouwkast
Copy link
Collaborator

Summary of changes

Expand the ownership of Version Bump-related files to be reviewable by https://github.com/orgs/DataDog/teams/apm-dotnet

Reason for change

Several of the files require reviews from https://github.com/orgs/DataDog/teams/profiling-dotnet, which has limited coverage.

Implementation details

I reviewed this recent Version Bump PR file-by-file, hovered over the little "shield" icon and added the file to the CODEOWNERS if it wasn't already owned by @apm-dotnet.

All of the new entries with JUST @apm-dotnet were previously owned by @tracing-dotnet.
All of the new entries with @DataDog/profiling-dotnet @DataDog/apm-dotnet were previously owned by JUST @DataDog/profiling-dotnet

Test coverage

Other details

This isn't ideal, but I don't see a better way around it without just force merging.

@bouwkast bouwkast requested a review from a team as a code owner April 21, 2025 16:29
@bouwkast bouwkast requested a review from a team April 21, 2025 16:29
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 21, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmarks Report for tracer 🐌

Benchmarks for #99 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.138
  • 2 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.1 KB 6.14 KB 44 B 0.72%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 59.2ns 374ns 0 0 0 5.57 KB
master StartStopWithChild netcoreapp3.1 13.5μs 67.4ns 294ns 0 0 0 5.76 KB
master StartStopWithChild net472 22.5μs 125ns 803ns 0.867 0.217 0 6.1 KB
#99 StartStopWithChild net6.0 10.2μs 57.2ns 366ns 0 0 0 5.55 KB
#99 StartStopWithChild netcoreapp3.1 13.2μs 69.5ns 374ns 0 0 0 5.76 KB
#99 StartStopWithChild net472 22.2μs 120ns 709ns 1.08 0.324 0.108 6.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.35 KB 3.31 KB -46 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 926μs 39ns 151ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 94.8ns 355ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 341ns 1.23μs 0 0 0 3.35 KB
#99 WriteAndFlushEnrichedTraces net6.0 916μs 60.7ns 235ns 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 1ms 72.4ns 261ns 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces net472 1.23ms 33.7ns 121ns 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 62μs 287ns 1.11μs 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71μs 184ns 690ns 0 0 0 17.42 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#99 SendRequest net6.0 61.9μs 71.5ns 268ns 0 0 0 14.53 KB
#99 SendRequest netcoreapp3.1 71.6μs 60.3ns 225ns 0 0 0 17.42 KB
#99 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #99

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.138 638,009.77 725,865.62

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.01 KB 56.32 KB 312 B 0.56%

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.35 KB 41.77 KB -574 B -1.36%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 639μs 1.24μs 4.47μs 0 0 0 42.35 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 3.5μs 24.3μs 0 0 0 42.23 KB
master WriteAndFlushEnrichedTraces net472 971μs 4.6μs 19.5μs 4.81 0 0 56.01 KB
#99 WriteAndFlushEnrichedTraces net6.0 726μs 959ns 3.71μs 0 0 0 41.77 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 698μs 1.5μs 7.05μs 0 0 0 42.25 KB
#99 WriteAndFlushEnrichedTraces net472 913μs 3.88μs 14μs 8.93 4.46 0 56.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 8.2ns 31.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.46μs 10.2ns 39.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.8μs 4.93ns 19.1ns 0.153 0.0139 0 995 B
#99 ExecuteNonQuery net6.0 1.87μs 7.29ns 28.2ns 0 0 0 1.03 KB
#99 ExecuteNonQuery netcoreapp3.1 2.49μs 8.18ns 31.7ns 0 0 0 1.02 KB
#99 ExecuteNonQuery net472 2.9μs 8.72ns 33.8ns 0.156 0.0142 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 9.48ns 46.5ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.27μs 10.9ns 43.7ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.54μs 1.43ns 5.55ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.85μs 8.88ns 36.6ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.43μs 8.95ns 34.7ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.71μs 1.43ns 5.35ns 0.166 0 0 1.11 KB
#99 CallElasticsearch net6.0 1.92μs 6.12ns 23.7ns 0 0 0 1.04 KB
#99 CallElasticsearch netcoreapp3.1 2.29μs 7.13ns 27.6ns 0 0 0 1.04 KB
#99 CallElasticsearch net472 3.55μs 4.09ns 15.9ns 0.159 0 0 1.05 KB
#99 CallElasticsearchAsync net6.0 1.91μs 4.42ns 17.1ns 0 0 0 1.02 KB
#99 CallElasticsearchAsync netcoreapp3.1 2.34μs 8.97ns 32.3ns 0 0 0 1.09 KB
#99 CallElasticsearchAsync net472 3.72μs 8.13ns 31.5ns 0.167 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.83μs 6.11ns 23.7ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.34μs 2.84ns 11ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.77ns 6.63ns 0.141 0 0 923 B
#99 ExecuteAsync net6.0 1.79μs 6.99ns 27.1ns 0 0 0 960 B
#99 ExecuteAsync netcoreapp3.1 2.27μs 8.45ns 32.7ns 0 0 0 960 B
#99 ExecuteAsync net472 2.61μs 0.906ns 3.51ns 0.144 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.84μs 15.4ns 55.5ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.63μs 15.8ns 61.2ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 9.74ns 37.7ns 0.488 0 0 3.19 KB
#99 SendAsync net6.0 7.33μs 13.4ns 51.9ns 0 0 0 2.37 KB
#99 SendAsync netcoreapp3.1 8.78μs 14.8ns 57.3ns 0 0 0 2.9 KB
#99 SendAsync net472 12.1μs 6.69ns 25.9ns 0.481 0 0 3.19 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.59μs 0.676ns 2.62ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.47μs 10.2ns 39.5ns 0 0 0 1.76 KB
master EnrichedLog net472 3.93μs 4.14ns 15.5ns 0.255 0 0 1.69 KB
#99 EnrichedLog net6.0 2.61μs 3.98ns 15.4ns 0 0 0 1.76 KB
#99 EnrichedLog netcoreapp3.1 3.49μs 16.6ns 64.1ns 0 0 0 1.76 KB
#99 EnrichedLog net472 3.93μs 4.81ns 18.6ns 0.257 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 88.3ns 330ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 127μs 62.2ns 215ns 0 0 0 4.37 KB
master EnrichedLog net472 171μs 111ns 400ns 0 0 0 4.57 KB
#99 EnrichedLog net6.0 124μs 74.3ns 288ns 0 0 0 4.37 KB
#99 EnrichedLog netcoreapp3.1 126μs 118ns 440ns 0 0 0 4.37 KB
#99 EnrichedLog net472 166μs 161ns 625ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.88μs 19.8ns 74.2ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.8μs 18.4ns 71.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.42μs 8.51ns 32.9ns 0.333 0 0 2.14 KB
#99 EnrichedLog net6.0 5μs 7.7ns 28.8ns 0 0 0 2.32 KB
#99 EnrichedLog netcoreapp3.1 6.66μs 5.13ns 19.9ns 0 0 0 2.32 KB
#99 EnrichedLog net472 7.54μs 5.94ns 22.2ns 0.338 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.07μs 10ns 41.2ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.66μs 9.63ns 34.7ns 0 0 0 1.21 KB
master SendReceive net472 3.09μs 4.88ns 18.9ns 0.186 0 0 1.21 KB
#99 SendReceive net6.0 1.97μs 10.6ns 54ns 0 0 0 1.21 KB
#99 SendReceive netcoreapp3.1 2.64μs 13.7ns 62.8ns 0 0 0 1.21 KB
#99 SendReceive net472 3μs 1.11ns 4.32ns 0.18 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.31μs 15.6ns 60.6ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.78μs 15.3ns 57.1ns 0 0 0 1.69 KB
master EnrichedLog net472 6.6μs 7.85ns 30.4ns 0.331 0 0 2.08 KB
#99 EnrichedLog net6.0 4.14μs 3.29ns 12.3ns 0 0 0 1.64 KB
#99 EnrichedLog netcoreapp3.1 5.76μs 16.9ns 63.3ns 0 0 0 1.69 KB
#99 EnrichedLog net472 6.58μs 9.95ns 38.6ns 0.327 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 760ns 3.95ns 18.5ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 957ns 5.04ns 24.2ns 0 0 0 584 B
master StartFinishSpan net472 900ns 0.239ns 0.924ns 0.0919 0 0 586 B
master StartFinishScope net6.0 939ns 4.83ns 21.6ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.19μs 1.74ns 6.75ns 0 0 0 704 B
master StartFinishScope net472 1.11μs 0.142ns 0.549ns 0.1 0 0 666 B
#99 StartFinishSpan net6.0 736ns 3.99ns 22.6ns 0 0 0 584 B
#99 StartFinishSpan netcoreapp3.1 943ns 4.55ns 18.2ns 0 0 0 584 B
#99 StartFinishSpan net472 877ns 0.179ns 0.668ns 0.0924 0 0 586 B
#99 StartFinishScope net6.0 890ns 4.7ns 24.4ns 0 0 0 704 B
#99 StartFinishScope netcoreapp3.1 1.12μs 5.91ns 30.2ns 0 0 0 704 B
#99 StartFinishScope net472 1.07μs 0.449ns 1.74ns 0.101 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.05μs 1.37ns 5.32ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.35μs 7.37ns 33.8ns 0 0 0 704 B
master RunOnMethodBegin net472 1.37μs 0.658ns 2.55ns 0.102 0 0 666 B
#99 RunOnMethodBegin net6.0 1.03μs 4.96ns 19.2ns 0 0 0 704 B
#99 RunOnMethodBegin netcoreapp3.1 1.35μs 5.97ns 23.1ns 0 0 0 704 B
#99 RunOnMethodBegin net472 1.39μs 1.06ns 3.97ns 0.105 0 0 666 B

andrewlock
andrewlock reviewed Apr 22, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. Also gross 😂

The other option is to add everyone to the profiling team 😉

@bouwkast bouwkast merged commit 786c914 into master Apr 22, 2025
99 of 102 checks passed
@bouwkast bouwkast deleted the steven/version-bump-pr-code-owners branch April 22, 2025 18:41
@github-actions github-actions bot added this to the vNext-v3 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bouwkast @lucaspimentel @andrewlock