-
Notifications
You must be signed in to change notification settings - Fork 147
Standardise file naming, header guards #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@willgittoes-dd: You and @dd-caleb should agree on one style for filenames and And don't worry about the C++ code being more "Windows-y." It will need to compile on Linux at some point, too. |
Yeah I had been removing the pragmas and renaming the files to match the google style guide. Don't have a strong opinion one way or the other, but if we use |
ehehe, I'm happy to flip this to doing it all the other way :) I picked these conventions because they were the ones used in the ClrSamples repo, but I don't mind either way. I'll make a version of this that uses the opposite conventions (as per Google C++ style guide), and you can approve whichever :D |
eyyyy, try this one instead: #103 |
We're going with #103 instead. Thanks! |
Standardises source file naming on TitleCase.ext, which is more windowsy than the alternative snake_case.ext.
Same deal with header guards. There was a mix of #defines and #pragma onces, and I settled on the latter as being more common in windows code.