Skip to content

Reduce the number of places we explicitly set the version in projects #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

Reduce the number of places we explicitly set the version in projects #7031

merged 2 commits into from
Jun 3, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Instead of setting the <Version> explicitly in all the projects in tracer/src, set it in the Directory.Build.props file instead

Reason for change

I wanted to add it to one of the other projects, which would have required updating all these places. Did this instead as it seemed to make more sense.

Implementation details

  • Move <Version>3.18.0</Version> to the Directory.Build.props file
  • Remove it from all the other projects
  • Update the UpdateVersion and VerifyChangedFilesFromVersionBump Nuke targets

Test coverage

Did a test run locally and it looks good to me. The Datadog.Trace.dll file still had the correct version embedded too, so I think it's fine. None of these projects are explicitly overriding the Directory.Build.props import AFAICT, so there's no reason it shouldn't work either, which is nice.

Other details

@andrewlock andrewlock requested a review from a team as a code owner May 29, 2025 16:06
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 29, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 29, 2025 •
edited
Loading

Datadog Report

Branch report: andrew/simplify-updating-build-version
Commit report: ad644f9
Test service: dd-trace-dotnet

✅ 0 Failed, 243681 Passed, 2281 Skipped, 15h 10m 45.57s Total Time

@andrewlock
Copy link
Member Author

andrewlock commented May 29, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (89ms)  : 81, 98
     .   : milestone, 89,
    master - mean (89ms)  : 81, 96
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (1,215ms)  : 1153, 1277
     .   : milestone, 1215,
    master - mean (1,224ms)  : 1167, 1282
     .   : milestone, 1224,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (135ms)  : 126, 143
     .   : milestone, 135,
    master - mean (135ms)  : 126, 143
     .   : milestone, 135,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (845ms)  : 802, 888
     .   : milestone, 845,
    master - mean (863ms)  : 819, 908
     .   : milestone, 863,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (117ms)  : 107, 128
     .   : milestone, 117,
    master - mean (121ms)  : 114, 127
     .   : milestone, 121,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (801ms)  : 758, 844
     .   : milestone, 801,
    master - mean (823ms)  : 791, 856
     .   : milestone, 823,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (1,114ms)  : 1087, 1141
     .   : milestone, 1114,
    master - mean (1,118ms)  : 1092, 1145
     .   : milestone, 1118,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (269ms)  : 265, 274
     .   : milestone, 269,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (879ms)  : 845, 913
     .   : milestone, 879,
    master - mean (883ms)  : 854, 912
     .   : milestone, 883,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7031) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7031) - mean (863ms)  : 836, 891
     .   : milestone, 863,
    master - mean (875ms)  : 847, 903
     .   : milestone, 875,
Loading

@pr-commenter
Copy link

pr-commenter bot commented May 29, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #99 compared to master:

  • All benchmarks have the same speed
  • 5 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.78 KB 5.75 KB -29 B -0.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.4μs 58.7ns 411ns 0 0 0 5.56 KB
master StartStopWithChild netcoreapp3.1 13.5μs 69.1ns 309ns 0 0 0 5.78 KB
master StartStopWithChild net472 22μs 119ns 639ns 1.02 0.451 0.113 6.07 KB
#99 StartStopWithChild net6.0 10.5μs 57.1ns 328ns 0 0 0 5.57 KB
#99 StartStopWithChild netcoreapp3.1 13.2μs 67.2ns 308ns 0 0 0 5.75 KB
#99 StartStopWithChild net472 22.4μs 122ns 654ns 1.06 0.422 0.106 6.1 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.33 KB 23 B 0.70%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 930μs 195ns 755ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 114ns 413ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.24ms 740ns 2.87μs 0 0 0 3.31 KB
#99 WriteAndFlushEnrichedTraces net6.0 936μs 55.3ns 207ns 0 0 0 2.71 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 33.1ns 115ns 0 0 0 2.7 KB
#99 WriteAndFlushEnrichedTraces net472 1.25ms 507ns 1.96μs 0 0 0 3.33 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 332μs 311ns 1.2μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 503μs 2.29μs 8.25μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 443μs 166ns 642ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 334μs 1.32μs 5.12μs 0 0 0 200.57 KB
master AllCycleMoreComplexBody netcoreapp3.1 507μs 1.83μs 6.84μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 450μs 154ns 597ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 318ns 0.123ns 0.461ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 394ns 2.23ns 14.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 305ns 0.0884ns 0.331ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.45μs 32.6ns 146ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.7μs 39.1ns 175ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.68μs 1.92ns 7.19ns 0.601 0 0 3.8 KB
#99 AllCycleSimpleBody net6.0 329μs 994ns 3.85μs 0 0 0 197.06 KB
#99 AllCycleSimpleBody netcoreapp3.1 480μs 2μs 7.74μs 0 0 0 204.77 KB
#99 AllCycleSimpleBody net472 451μs 118ns 442ns 35.7 2.23 0 236.37 KB
#99 AllCycleMoreComplexBody net6.0 336μs 1.24μs 4.8μs 0 0 0 200.56 KB
#99 AllCycleMoreComplexBody netcoreapp3.1 510μs 1.8μs 6.98μs 0 0 0 208.18 KB
#99 AllCycleMoreComplexBody net472 448μs 223ns 864ns 37.9 2.23 0 239.88 KB
#99 ObjectExtractorSimpleBody net6.0 311ns 1.66ns 8.29ns 0 0 0 280 B
#99 ObjectExtractorSimpleBody netcoreapp3.1 393ns 2.12ns 12.2ns 0 0 0 272 B
#99 ObjectExtractorSimpleBody net472 304ns 0.0552ns 0.214ns 0.0444 0 0 281 B
#99 ObjectExtractorMoreComplexBody net6.0 6.29μs 23.9ns 92.7ns 0 0 0 3.78 KB
#99 ObjectExtractorMoreComplexBody netcoreapp3.1 7.72μs 31.8ns 123ns 0 0 0 3.69 KB
#99 ObjectExtractorMoreComplexBody net472 6.65μs 3.36ns 13ns 0.599 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#99 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.6μs 38.9ns 150ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72.1μs 120ns 451ns 0 0 0 17.42 KB
master SendRequest net472 0.0195ns 0.00281ns 0.0109ns 0 0 0 0 b
#99 SendRequest net6.0 61.1μs 70.2ns 263ns 0 0 0 14.53 KB
#99 SendRequest netcoreapp3.1 72.5μs 123ns 444ns 0 0 0 17.43 KB
#99 SendRequest net472 0.0163ns 0.00264ns 0.0102ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.76 KB 42.05 KB 295 B 0.71%

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.42 KB 55.61 KB -813 B -1.44%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 677μs 3.72μs 20.7μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 712μs 2.38μs 18.4μs 0 0 0 41.76 KB
master WriteAndFlushEnrichedTraces net472 1.04ms 5.83μs 41.6μs 8.33 0 0 56.42 KB
#99 WriteAndFlushEnrichedTraces net6.0 692μs 748ns 2.9μs 0 0 0 41.75 KB
#99 WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 3.06μs 12.3μs 0 0 0 42.05 KB
#99 WriteAndFlushEnrichedTraces net472 987μs 4.77μs 20.2μs 4.46 0 0 55.61 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.98μs 5.71ns 22.1ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 10.2ns 39.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.43ns 9.09ns 0.148 0.0135 0 995 B
#99 ExecuteNonQuery net6.0 1.95μs 9.31ns 36.1ns 0 0 0 1.03 KB
#99 ExecuteNonQuery netcoreapp3.1 2.49μs 8.78ns 32.9ns 0 0 0 1.02 KB
#99 ExecuteNonQuery net472 2.68μs 4.65ns 18ns 0.148 0.0134 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 9.12ns 41.8ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.35μs 6.77ns 26.2ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.6μs 8.72ns 33.8ns 0.162 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.88μs 4.59ns 17.2ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.54μs 6.42ns 24.9ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.76μs 7.85ns 30.4ns 0.172 0 0 1.11 KB
#99 CallElasticsearch net6.0 1.74μs 8.5ns 37.1ns 0 0 0 1.04 KB
#99 CallElasticsearch netcoreapp3.1 2.43μs 11.5ns 43ns 0 0 0 1.04 KB
#99 CallElasticsearch net472 3.53μs 2.6ns 10.1ns 0.159 0 0 1.05 KB
#99 CallElasticsearchAsync net6.0 1.86μs 4.92ns 19.1ns 0 0 0 1.02 KB
#99 CallElasticsearchAsync netcoreapp3.1 2.38μs 11.7ns 48.2ns 0 0 0 1.09 KB
#99 CallElasticsearchAsync net472 3.69μs 2.65ns 10.3ns 0.165 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.84μs 6.82ns 26.4ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.24μs 8.47ns 32.8ns 0 0 0 960 B
master ExecuteAsync net472 2.52μs 0.461ns 1.78ns 0.138 0 0 923 B
#99 ExecuteAsync net6.0 1.82μs 9.42ns 43.2ns 0 0 0 960 B
#99 ExecuteAsync netcoreapp3.1 2.32μs 7.44ns 28.8ns 0 0 0 960 B
#99 ExecuteAsync net472 2.49μs 1.06ns 4.09ns 0.137 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.94μs 13.9ns 51.9ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.44μs 29.9ns 116ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 7.12ns 27.6ns 0.484 0 0 3.19 KB
#99 SendAsync net6.0 7.27μs 13.4ns 51.9ns 0 0 0 2.37 KB
#99 SendAsync netcoreapp3.1 8.89μs 24ns 93.1ns 0 0 0 2.9 KB
#99 SendAsync net472 12.5μs 12.6ns 48.8ns 0.496 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%

Fewer allocations 🎉 in #99

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.55 KB 43.86 KB -696 B -1.56%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 45.13 KB 42.64 KB -2.49 KB -5.51%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 275.18 KB 257.7 KB -17.48 KB -6.35%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 42.5μs 222ns 1.09μs 0 0 0 44.55 KB
master StringConcatBenchmark netcoreapp3.1 48.9μs 284ns 2.25μs 0 0 0 45.13 KB
master StringConcatBenchmark net472 57.2μs 171ns 617ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 463μs 1.88μs 6.76μs 0 0 0 276.09 KB
master StringConcatAspectBenchmark netcoreapp3.1 529μs 2.71μs 12.1μs 0 0 0 275.18 KB
master StringConcatAspectBenchmark net472 412μs 2.1μs 10.1μs 0 0 0 286.72 KB
#99 StringConcatBenchmark net6.0 45.6μs 267ns 2.15μs 0 0 0 43.86 KB
#99 StringConcatBenchmark netcoreapp3.1 47.6μs 275ns 2.02μs 0 0 0 42.64 KB
#99 StringConcatBenchmark net472 58.3μs 203ns 761ns 0 0 0 65.54 KB
#99 StringConcatAspectBenchmark net6.0 514μs 1.85μs 6.67μs 0 0 0 275.79 KB
#99 StringConcatAspectBenchmark netcoreapp3.1 526μs 2.58μs 10.6μs 0 0 0 257.7 KB
#99 StringConcatAspectBenchmark net472 406μs 1.69μs 6.55μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.6μs 13.6ns 65.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.41μs 18ns 90ns 0 0 0 1.76 KB
master EnrichedLog net472 4.14μs 3.32ns 12.9ns 0.267 0 0 1.69 KB
#99 EnrichedLog net6.0 2.56μs 1.04ns 4.04ns 0 0 0 1.76 KB
#99 EnrichedLog netcoreapp3.1 3.54μs 14.2ns 54.9ns 0 0 0 1.76 KB
#99 EnrichedLog net472 3.83μs 2.66ns 10.3ns 0.269 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 23.1ns 83.4ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 130μs 234ns 908ns 0 0 0 4.37 KB
master EnrichedLog net472 165μs 98.6ns 356ns 0 0 0 4.57 KB
#99 EnrichedLog net6.0 123μs 40.4ns 156ns 0 0 0 4.37 KB
#99 EnrichedLog netcoreapp3.1 127μs 134ns 484ns 0 0 0 4.37 KB
#99 EnrichedLog net472 166μs 191ns 741ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.04μs 4.44ns 17.2ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.7μs 10.1ns 39.2ns 0 0 0 2.32 KB
master EnrichedLog net472 7.58μs 5.77ns 22.3ns 0.304 0 0 2.14 KB
#99 EnrichedLog net6.0 5.03μs 10ns 38.8ns 0 0 0 2.32 KB
#99 EnrichedLog netcoreapp3.1 6.75μs 5.79ns 20.9ns 0 0 0 2.32 KB
#99 EnrichedLog net472 7.49μs 4.38ns 17ns 0.338 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.01μs 1.18ns 4.59ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.48μs 12.6ns 57.8ns 0 0 0 1.21 KB
master SendReceive net472 3.12μs 6.06ns 21.8ns 0.187 0 0 1.21 KB
#99 SendReceive net6.0 1.99μs 2.72ns 10.2ns 0 0 0 1.21 KB
#99 SendReceive netcoreapp3.1 2.59μs 4.4ns 15.9ns 0 0 0 1.21 KB
#99 SendReceive net472 3.29μs 1.21ns 4.68ns 0.179 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.24μs 5.84ns 21.1ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.7μs 17.6ns 65.8ns 0 0 0 1.69 KB
master EnrichedLog net472 6.7μs 5.98ns 23.2ns 0.303 0 0 2.08 KB
#99 EnrichedLog net6.0 4.15μs 5.41ns 20.2ns 0 0 0 1.64 KB
#99 EnrichedLog netcoreapp3.1 5.72μs 15.6ns 60.4ns 0 0 0 1.69 KB
#99 EnrichedLog net472 6.71μs 9.62ns 37.2ns 0.3 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 761ns 0.204ns 0.763ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 962ns 4.85ns 21.7ns 0 0 0 584 B
master StartFinishSpan net472 937ns 0.208ns 0.807ns 0.089 0 0 586 B
master StartFinishScope net6.0 885ns 4.57ns 20.4ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.14μs 1.88ns 7.02ns 0 0 0 704 B
master StartFinishScope net472 1.12μs 1.49ns 5.75ns 0.101 0 0 666 B
#99 StartFinishSpan net6.0 754ns 0.297ns 1.07ns 0 0 0 584 B
#99 StartFinishSpan netcoreapp3.1 942ns 4.96ns 24.3ns 0 0 0 584 B
#99 StartFinishSpan net472 924ns 0.258ns 0.966ns 0.0923 0 0 586 B
#99 StartFinishScope net6.0 899ns 4.61ns 20.6ns 0 0 0 704 B
#99 StartFinishScope netcoreapp3.1 1.13μs 5.41ns 20.9ns 0 0 0 704 B
#99 StartFinishScope net472 1.1μs 0.265ns 0.917ns 0.1 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1μs 4.36ns 16.3ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 5.85ns 22.6ns 0 0 0 704 B
master RunOnMethodBegin net472 1.44μs 0.331ns 1.24ns 0.101 0 0 666 B
#99 RunOnMethodBegin net6.0 1μs 1.69ns 6.31ns 0 0 0 704 B
#99 RunOnMethodBegin netcoreapp3.1 1.37μs 5.5ns 21.3ns 0 0 0 704 B
#99 RunOnMethodBegin net472 1.36μs 0.533ns 2.06ns 0.102 0 0 666 B

bouwkast
bouwkast approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice makes sense to me 👍

lucaspimentel
lucaspimentel approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srsly

@andrewlock andrewlock force-pushed the andrew/simplify-updating-build-version branch from 0516ca0 to ad644f9 Compare June 2, 2025 13:48
@andrewlock andrewlock merged commit 1a590d2 into master Jun 3, 2025
125 of 128 checks passed
@andrewlock andrewlock deleted the andrew/simplify-updating-build-version branch June 3, 2025 11:46
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 3, 2025
@lucaspimentel lucaspimentel mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @lucaspimentel @bouwkast