[AAP] Update waf value obfuscation default regex value #7004

daniel-romano-DD · 2025-05-25T21:21:31Z

Summary of changes

Update default Waf value obfuscation regex

Reason for change

Jira

Implementation details

Test coverage

Other details

datadog-datadog-prod-us1 · 2025-05-25T21:56:44Z

Datadog Report

Branch report: dani/iast/update_waf_obfuscation_regex
Commit report: ea5bb20
Test service: dd-trace-dotnet

✅ 0 Failed, 257252 Passed, 2302 Skipped, 18h 14m 14.12s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

RenamesService - Datadog.Trace.ClrProfiler.IntegrationTests.PeerServiceMappingTests - Last Failure

Expand for error

 Expected relevantSpans to contain at least 91 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 90: {{TraceId: 878045199838252627, SpanId: 5186552495816329205, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 13773230589396499517, SpanId: 10212281380712991703, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 11941397404444317585, SpanId: 12705323828122358545, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 9828709445092619538, SpanId: 1968931281790566272, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 1632733479514218726, SpanId: 10170559211905333141, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 9366587404949850091, SpanId: 4491600688822931547, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 8443757663734245619, SpanId: 3274976397498155528, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 17809311004275729084, SpanId: 14099324763212438210, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 597673669894565045, SpanId: 14556954648125906446, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 4807301179028204465, SpanId: 9755148978915268752, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 16669456830350273280, SpanId: 12439768689780439283, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 14201037029948683356, SpanId: 12201265476129608455, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 15751521743034675498, SpanId: 4379975238549394801, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 18393943910648234405, SpanId: 7235650839403992204, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 7006686391407909963, SpanId: 7090532694494121487, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 8186681106001105694, SpanId: 7687394586944314449, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 5799227574209905823, SpanId: 16317411023451112435, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 9170531493231227537, SpanId: 12591310008946430268, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 2768487446238639915, SpanId: 16686163780248520544, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 14034183504266664112, SpanId: 1134233204866586052, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 4216817929770551698, SpanId: 14159391179493514981, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 6727184605810671648, SpanId: 7299462184557368017, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 16707745870296794253, SpanId: 2271935374763455229, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 11259280286393860179, SpanId: 2491773105213970531, Name: http.request, Resource: GET localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 7255354686670963573, SpanId: 14036310227514309148, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 7814606049051279397, SpanId: 16592030449002165165, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 8590886117169220997, SpanId: 18445840952797058159, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 12801579244159480737, SpanId: 12355290121793229454, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 17001011002886148178, SpanId: 16845873646453568619, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 2604134937206419406, SpanId: 13466261984715086226, Name: http.request, Resource: POST localhost:38655/?/, Service: Samples.WebRequest-http-client}, {TraceId: 6216241169742875309, SpanId: 11502969486436095006, Name: http.request, Resource: POST localhost:38655/?/, Se

andrewlock · 2025-05-25T21:57:36Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (69ms)  : 63, 74
     .   : milestone, 69,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (1,012ms)  : 984, 1039
     .   : milestone, 1012,
    master - mean (1,003ms)  : 979, 1027
     .   : milestone, 1003,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 99, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (694ms)  : 676, 712
     .   : milestone, 694,
    master - mean (690ms)  : 668, 711
     .   : milestone, 690,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (655ms)  : 634, 677
     .   : milestone, 655,
    master - mean (654ms)  : 633, 675
     .   : milestone, 654,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (1,111ms)  : 1081, 1141
     .   : milestone, 1111,
    master - mean (1,110ms)  : 1078, 1142
     .   : milestone, 1110,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (270ms)  : 266, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (877ms)  : 851, 903
     .   : milestone, 877,
    master - mean (886ms)  : 855, 918
     .   : milestone, 886,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7004) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (262ms)  : 260, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7004) - mean (866ms)  : 832, 900
     .   : milestone, 866,
    master - mean (871ms)  : 842, 901
     .   : milestone, 871,

pr-commenter · 2025-05-25T22:11:47Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #99 compared to master:

All benchmarks have the same speed
2 benchmarks have fewer allocations
5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.12 KB	6.22 KB	99 B	1.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	10.1μs	56.6ns	358ns	0	0	0	5.56 KB
master	`StartStopWithChild`	netcoreapp3.1	14.2μs	75ns	382ns	0	0	0	5.79 KB
master	`StartStopWithChild`	net472	22.2μs	117ns	586ns	1.07	0.322	0.107	6.12 KB
#99	`StartStopWithChild`	net6.0	11.3μs	60.6ns	337ns	0	0	0	5.56 KB
#99	`StartStopWithChild`	netcoreapp3.1	13.6μs	69.5ns	318ns	0	0	0	5.77 KB
#99	`StartStopWithChild`	net472	21.9μs	117ns	597ns	0.994	0.331	0.11	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.31 KB	3.33 KB	23 B	0.70%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	934μs	314ns	1.21μs	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.02ms	69.3ns	250ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.21ms	39.6ns	143ns	3.31 KB
#99	`WriteAndFlushEnrichedTraces`	net6.0	933μs	69ns	267ns	2.71 KB
#99	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.04ms	195ns	755ns	2.7 KB
#99	`WriteAndFlushEnrichedTraces`	net472	1.27ms	73.7ns	286ns	3.33 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	335μs	882ns	3.3μs	0	0	197.06 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	483μs	324ns	1.25μs	0	0	204.77 KB
master	`AllCycleSimpleBody`	net472	438μs	219ns	848ns	36.6	2.16	236.35 KB
master	`AllCycleMoreComplexBody`	net6.0	338μs	642ns	2.49μs	0	0	200.57 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	492μs	1.87μs	7.26μs	0	0	208.18 KB
master	`AllCycleMoreComplexBody`	net472	445μs	177ns	638ns	37.9	2.23	239.88 KB
master	`ObjectExtractorSimpleBody`	net6.0	315ns	1.59ns	7.09ns	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	391ns	2.16ns	12ns	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	309ns	0.0385ns	0.144ns	0.0441	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.31μs	27.9ns	108ns	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.89μs	30ns	116ns	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.71μs	6.68ns	25.9ns	0.602	0	3.8 KB
#99	`AllCycleSimpleBody`	net6.0	328μs	1.68μs	7.49μs	0	0	197.06 KB
#99	`AllCycleSimpleBody`	netcoreapp3.1	502μs	462ns	1.79μs	0	0	204.77 KB
#99	`AllCycleSimpleBody`	net472	437μs	111ns	416ns	36.6	2.16	236.35 KB
#99	`AllCycleMoreComplexBody`	net6.0	336μs	1.67μs	7.26μs	0	0	200.56 KB
#99	`AllCycleMoreComplexBody`	netcoreapp3.1	485μs	217ns	814ns	0	0	208.18 KB
#99	`AllCycleMoreComplexBody`	net472	445μs	126ns	473ns	36.6	2.16	239.87 KB
#99	`ObjectExtractorSimpleBody`	net6.0	319ns	0.428ns	1.66ns	0	0	280 B
#99	`ObjectExtractorSimpleBody`	netcoreapp3.1	399ns	0.224ns	0.867ns	0	0	272 B
#99	`ObjectExtractorSimpleBody`	net472	301ns	0.0256ns	0.0958ns	0.0441	0	281 B
#99	`ObjectExtractorMoreComplexBody`	net6.0	6.26μs	28.1ns	109ns	0	0	3.78 KB
#99	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.77μs	2.47ns	9.56ns	0	0	3.69 KB
#99	`ObjectExtractorMoreComplexBody`	net472	6.67μs	5.53ns	21.4ns	0.598	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	61.9μs	164ns	636ns	14.53 KB
master	`SendRequest`	netcoreapp3.1	71μs	155ns	601ns	17.43 KB
master	`SendRequest`	net472	0.0117ns	0.00314ns	0.0122ns	0 b
#99	`SendRequest`	net6.0	60.5μs	61.8ns	231ns	14.53 KB
#99	`SendRequest`	netcoreapp3.1	71.2μs	89.2ns	322ns	17.42 KB
#99	`SendRequest`	net472	0.0191ns	0.00151ns	0.00583ns	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	697μs	1.04μs	3.88μs	0	41.9 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	712μs	3.92μs	25.1μs	0	41.86 KB
master	`WriteAndFlushEnrichedTraces`	net472	932μs	2.23μs	8.33μs	4.46	55.95 KB
#99	`WriteAndFlushEnrichedTraces`	net6.0	697μs	589ns	2.21μs	0	41.85 KB
#99	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	649μs	2.64μs	9.16μs	0	41.95 KB
#99	`WriteAndFlushEnrichedTraces`	net472	934μs	5.03μs	28μs	8.33	56.19 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.91μs	8.65ns	32.4ns	0	0	1.03 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.55μs	3.5ns	13.1ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.71μs	2.6ns	9.71ns	0.149	0.0135	995 B
#99	`ExecuteNonQuery`	net6.0	1.94μs	0.982ns	3.8ns	0	0	1.03 KB
#99	`ExecuteNonQuery`	netcoreapp3.1	2.54μs	3.73ns	14ns	0	0	1.02 KB
#99	`ExecuteNonQuery`	net472	2.78μs	3.6ns	13.9ns	0.15	0.0136	995 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.75μs	4.95ns	19.2ns	0	1.04 KB
master	`CallElasticsearch`	netcoreapp3.1	2.29μs	2.26ns	8.77ns	0	1.04 KB
master	`CallElasticsearch`	net472	3.44μs	4.57ns	17.7ns	0.156	1.05 KB
master	`CallElasticsearchAsync`	net6.0	1.81μs	5.75ns	20.7ns	0	1.02 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.32μs	11.5ns	47.5ns	0	1.09 KB
master	`CallElasticsearchAsync`	net472	3.62μs	3.76ns	14.6ns	0.161	1.11 KB
#99	`CallElasticsearch`	net6.0	1.8μs	7.72ns	29.9ns	0	1.04 KB
#99	`CallElasticsearch`	netcoreapp3.1	2.28μs	2.41ns	9.34ns	0	1.04 KB
#99	`CallElasticsearch`	net472	3.61μs	1.78ns	6.88ns	0.163	1.05 KB
#99	`CallElasticsearchAsync`	net6.0	1.83μs	1.34ns	5ns	0	1.02 KB
#99	`CallElasticsearchAsync`	netcoreapp3.1	2.43μs	10.7ns	41.4ns	0	1.09 KB
#99	`CallElasticsearchAsync`	net472	3.75μs	2.3ns	8.91ns	0.169	1.11 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.77μs	6ns	23.2ns	0	960 B
master	`ExecuteAsync`	netcoreapp3.1	2.31μs	10.7ns	44.2ns	0	960 B
master	`ExecuteAsync`	net472	2.54μs	6.4ns	24.8ns	0.142	923 B
#99	`ExecuteAsync`	net6.0	1.87μs	2.43ns	9.4ns	0	960 B
#99	`ExecuteAsync`	netcoreapp3.1	2.41μs	1.95ns	7.56ns	0	960 B
#99	`ExecuteAsync`	net472	2.52μs	1.78ns	6.9ns	0.139	923 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	7.03μs	4.93ns	18.4ns	0	2.37 KB
master	`SendAsync`	netcoreapp3.1	8.45μs	18.1ns	70.3ns	0	2.9 KB
master	`SendAsync`	net472	12.1μs	8.61ns	33.3ns	0.478	3.19 KB
#99	`SendAsync`	net6.0	7.15μs	8.5ns	31.8ns	0	2.37 KB
#99	`SendAsync`	netcoreapp3.1	8.51μs	21ns	81.2ns	0	2.9 KB
#99	`SendAsync`	net472	12.2μs	8.73ns	32.7ns	0.486	3.19 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472	278.53 KB	294.91 KB	16.38 KB	5.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	43.86 KB	44.67 KB	808 B	1.84%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	274.5 KB	279.31 KB	4.82 KB	1.75%

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	43.54 KB	42.64 KB	-904 B	-2.08%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	276 KB	257.11 KB	-18.89 KB	-6.84%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	43.8μs	218ns	952ns	43.86 KB
master	`StringConcatBenchmark`	netcoreapp3.1	48.6μs	242ns	1.11μs	43.54 KB
master	`StringConcatBenchmark`	net472	56.9μs	120ns	417ns	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	460μs	1.4μs	5.03μs	276 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	526μs	891ns	3.09μs	274.5 KB
master	`StringConcatAspectBenchmark`	net472	407μs	2.32μs	16.7μs	278.53 KB
#99	`StringConcatBenchmark`	net6.0	41.9μs	147ns	586ns	44.67 KB
#99	`StringConcatBenchmark`	netcoreapp3.1	50.2μs	292ns	2.28μs	42.64 KB
#99	`StringConcatBenchmark`	net472	57.4μs	275ns	1.13μs	57.34 KB
#99	`StringConcatAspectBenchmark`	net6.0	455μs	1.66μs	5.99μs	257.11 KB
#99	`StringConcatAspectBenchmark`	netcoreapp3.1	579μs	1.93μs	6.94μs	279.31 KB
#99	`StringConcatAspectBenchmark`	net472	409μs	1.74μs	6.73μs	294.91 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.56μs	10ns	37.5ns	0	1.76 KB
master	`EnrichedLog`	netcoreapp3.1	3.46μs	8.14ns	31.5ns	0	1.76 KB
master	`EnrichedLog`	net472	3.93μs	4.25ns	16.5ns	0.256	1.69 KB
#99	`EnrichedLog`	net6.0	2.58μs	12.9ns	57.6ns	0	1.76 KB
#99	`EnrichedLog`	netcoreapp3.1	3.45μs	1.19ns	4.31ns	0	1.76 KB
#99	`EnrichedLog`	net472	3.88μs	6.45ns	25ns	0.252	1.69 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	122μs	61.5ns	230ns	4.37 KB
master	`EnrichedLog`	netcoreapp3.1	127μs	292ns	1.13μs	4.37 KB
master	`EnrichedLog`	net472	165μs	57.6ns	223ns	4.57 KB
#99	`EnrichedLog`	net6.0	123μs	66.6ns	258ns	4.37 KB
#99	`EnrichedLog`	netcoreapp3.1	127μs	29.2ns	101ns	4.37 KB
#99	`EnrichedLog`	net472	166μs	63.9ns	221ns	4.57 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	5.03μs	22.2ns	86.1ns	0	2.32 KB
master	`EnrichedLog`	netcoreapp3.1	6.73μs	10.1ns	39ns	0	2.32 KB
master	`EnrichedLog`	net472	7.3μs	7.88ns	30.5ns	0.327	2.14 KB
#99	`EnrichedLog`	net6.0	5.14μs	4.84ns	18.7ns	0	2.32 KB
#99	`EnrichedLog`	netcoreapp3.1	6.71μs	17.9ns	69.2ns	0	2.32 KB
#99	`EnrichedLog`	net472	7.29μs	6.24ns	24.2ns	0.327	2.14 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2μs	9.56ns	38.3ns	0	1.21 KB
master	`SendReceive`	netcoreapp3.1	2.55μs	9.46ns	34.1ns	0	1.21 KB
master	`SendReceive`	net472	3.05μs	2.31ns	8.93ns	0.183	1.21 KB
#99	`SendReceive`	net6.0	1.98μs	9.87ns	41.9ns	0	1.21 KB
#99	`SendReceive`	netcoreapp3.1	2.62μs	12.4ns	52.5ns	0	1.21 KB
#99	`SendReceive`	net472	3.04μs	7.64ns	29.6ns	0.183	1.21 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.17μs	17.3ns	66.9ns	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	5.64μs	13.9ns	53.8ns	0	1.69 KB
master	`EnrichedLog`	net472	6.58μs	8.94ns	34.6ns	0.328	2.08 KB
#99	`EnrichedLog`	net6.0	4.22μs	4.29ns	15.5ns	0	1.64 KB
#99	`EnrichedLog`	netcoreapp3.1	5.65μs	14.4ns	54ns	0	1.69 KB
#99	`EnrichedLog`	net472	6.44μs	5.04ns	19.5ns	0.322	2.08 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	749ns	3.96ns	20.6ns	0	584 B
master	`StartFinishSpan`	netcoreapp3.1	930ns	4.44ns	17.2ns	0	584 B
master	`StartFinishSpan`	net472	923ns	0.229ns	0.856ns	0.0924	586 B
master	`StartFinishScope`	net6.0	885ns	4.56ns	20.9ns	0	704 B
master	`StartFinishScope`	netcoreapp3.1	1.19μs	4.23ns	16.4ns	0	704 B
master	`StartFinishScope`	net472	1.13μs	0.856ns	3.31ns	0.102	666 B
#99	`StartFinishSpan`	net6.0	759ns	2.93ns	11.3ns	0	584 B
#99	`StartFinishSpan`	netcoreapp3.1	954ns	5.1ns	27ns	0	584 B
#99	`StartFinishSpan`	net472	921ns	0.109ns	0.422ns	0.0921	586 B
#99	`StartFinishScope`	net6.0	894ns	0.206ns	0.771ns	0	704 B
#99	`StartFinishScope`	netcoreapp3.1	1.17μs	6.12ns	30ns	0	705 B
#99	`StartFinishScope`	net472	1.14μs	0.464ns	1.8ns	0.102	666 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.04μs	1.87ns	7.25ns	0	704 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.34μs	6.76ns	30.2ns	0	704 B
master	`RunOnMethodBegin`	net472	1.36μs	0.843ns	3.27ns	0.102	666 B
#99	`RunOnMethodBegin`	net6.0	1.05μs	5.01ns	21.3ns	0	704 B
#99	`RunOnMethodBegin`	netcoreapp3.1	1.36μs	6.58ns	27.9ns	0	704 B
#99	`RunOnMethodBegin`	net472	1.34μs	1.44ns	5.58ns	0.101	666 B

e-n-0

Thanks!

Update default regex value

ea5bb20

daniel-romano-DD added the area:asm label May 25, 2025

e-n-0 approved these changes May 26, 2025

View reviewed changes

daniel-romano-DD marked this pull request as ready for review May 27, 2025 15:05

daniel-romano-DD requested a review from a team as a code owner May 27, 2025 15:05

e-n-0 approved these changes May 27, 2025

View reviewed changes

daniel-romano-DD merged commit 428048e into master May 27, 2025
126 of 127 checks passed

daniel-romano-DD deleted the dani/iast/update_waf_obfuscation_regex branch May 27, 2025 15:07

github-actions bot added this to the vNext-v3 milestone May 27, 2025

[AAP] Update waf value obfuscation default regex value #7004

[AAP] Update waf value obfuscation default regex value #7004

Uh oh!

Conversation

daniel-romano-DD commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-datadog-prod-us1 bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

New Flaky Tests (1)

Uh oh!

andrewlock commented May 25, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

pr-commenter bot commented May 25, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #99

Raw results

More allocations ⚠️ in #99

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #99

Fewer allocations 🎉 in #99

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

e-n-0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daniel-romano-DD commented May 25, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented May 25, 2025 •

edited

Loading