Skip to content

fix: enable retries on failure due to script error #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix: enable retries on failure due to script error #7022

merged 1 commit into from
May 30, 2025

Conversation

faydef
Copy link
Contributor

@faydef faydef commented May 28, 2025

Summary of changes

Enables retries on failure due to script error

Reason for change

We need to diagnose errors from k6, we are enabling retiries on script failure

Implementation details

Test coverage

Other details

@faydef faydef requested a review from a team as a code owner May 28, 2025 11:36
@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7022 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.146
  • 3 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 58.3ns 355ns 0 0 0 5.54 KB
master StartStopWithChild netcoreapp3.1 14μs 66.7ns 283ns 0 0 0 5.77 KB
master StartStopWithChild net472 22.2μs 115ns 585ns 1.09 0.326 0.109 6.15 KB
#7022 StartStopWithChild net6.0 10.3μs 57.7ns 396ns 0 0 0 5.55 KB
#7022 StartStopWithChild netcoreapp3.1 13.9μs 70.6ns 324ns 0 0 0 5.75 KB
#7022 StartStopWithChild net472 22μs 115ns 588ns 0.95 0.211 0 6.17 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7022

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 942μs 220ns 851ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 75.9ns 273ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.24ms 335ns 1.3μs 0 0 0 3.33 KB
#7022 WriteAndFlushEnrichedTraces net6.0 930μs 190ns 709ns 0 0 0 2.71 KB
#7022 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 60.5ns 210ns 0 0 0 2.7 KB
#7022 WriteAndFlushEnrichedTraces net472 1.24ms 295ns 1.14μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 328μs 1.03μs 3.97μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 988ns 3.83μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 439μs 133ns 497ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 339μs 358ns 1.39μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 490μs 2.2μs 8.25μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 450μs 509ns 1.97μs 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 323ns 0.117ns 0.436ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.19ns 13.1ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 307ns 0.0508ns 0.183ns 0.0433 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.66μs 2.53ns 9.8ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 37.7ns 160ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.69μs 5.52ns 21.4ns 0.6 0 0 3.8 KB
#7022 AllCycleSimpleBody net6.0 329μs 1.61μs 6.25μs 0 0 0 197.06 KB
#7022 AllCycleSimpleBody netcoreapp3.1 489μs 751ns 2.91μs 0 0 0 204.77 KB
#7022 AllCycleSimpleBody net472 441μs 120ns 449ns 36.6 2.16 0 236.35 KB
#7022 AllCycleMoreComplexBody net6.0 335μs 1.6μs 6.42μs 0 0 0 200.56 KB
#7022 AllCycleMoreComplexBody netcoreapp3.1 496μs 2.44μs 10.1μs 0 0 0 208.18 KB
#7022 AllCycleMoreComplexBody net472 450μs 226ns 874ns 37.9 2.23 0 239.88 KB
#7022 ObjectExtractorSimpleBody net6.0 313ns 0.08ns 0.31ns 0 0 0 280 B
#7022 ObjectExtractorSimpleBody netcoreapp3.1 397ns 1.96ns 7.83ns 0 0 0 272 B
#7022 ObjectExtractorSimpleBody net472 303ns 0.0395ns 0.153ns 0.0444 0 0 281 B
#7022 ObjectExtractorMoreComplexBody net6.0 6.4μs 27.6ns 107ns 0 0 0 3.78 KB
#7022 ObjectExtractorMoreComplexBody netcoreapp3.1 7.62μs 36.3ns 140ns 0 0 0 3.69 KB
#7022 ObjectExtractorMoreComplexBody net472 6.72μs 10.1ns 39.1ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7022 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7022 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 68.4ns 256ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71.4μs 79.2ns 296ns 0 0 0 17.42 KB
master SendRequest net472 0.0143ns 0.00212ns 0.00822ns 0 0 0 0 b
#7022 SendRequest net6.0 60.7μs 48.6ns 188ns 0 0 0 14.53 KB
#7022 SendRequest netcoreapp3.1 71.3μs 188ns 703ns 0 0 0 17.42 KB
#7022 SendRequest net472 0.0228ns 0.0015ns 0.00582ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7022

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.146 954,521.88 832,934.82

More allocations ⚠️ in #7022

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.01 KB 42.52 KB 509 B 1.21%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 769μs 715ns 2.67μs 0 0 0 42.01 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 689μs 3.95μs 32.1μs 0 0 0 41.74 KB
master WriteAndFlushEnrichedTraces net472 952μs 4.64μs 20.2μs 4.46 0 0 55.7 KB
#7022 WriteAndFlushEnrichedTraces net6.0 689μs 3.78μs 23.6μs 0 0 0 42.52 KB
#7022 WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 2.92μs 13.7μs 0 0 0 41.94 KB
#7022 WriteAndFlushEnrichedTraces net472 836μs 3.81μs 14.3μs 4.46 0 0 55.59 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.96μs 7.59ns 29.4ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.47μs 5.88ns 22.8ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.78μs 2.58ns 10ns 0.151 0.0137 0 995 B
#7022 ExecuteNonQuery net6.0 1.94μs 9.84ns 45.1ns 0 0 0 1.03 KB
#7022 ExecuteNonQuery netcoreapp3.1 2.51μs 9.69ns 37.5ns 0 0 0 1.02 KB
#7022 ExecuteNonQuery net472 2.66μs 4.09ns 15.8ns 0.147 0.0134 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.79μs 4.84ns 18.1ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.36μs 9.49ns 36.8ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.48μs 1.9ns 7.1ns 0.157 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.77μs 9.44ns 47.2ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.53ns 29.2ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.69μs 1.95ns 7.31ns 0.166 0 0 1.11 KB
#7022 CallElasticsearch net6.0 1.84μs 1.9ns 7.11ns 0 0 0 1.04 KB
#7022 CallElasticsearch netcoreapp3.1 2.27μs 8.73ns 31.5ns 0 0 0 1.04 KB
#7022 CallElasticsearch net472 3.48μs 2.16ns 8.35ns 0.157 0 0 1.05 KB
#7022 CallElasticsearchAsync net6.0 1.87μs 1.84ns 7.12ns 0 0 0 1.02 KB
#7022 CallElasticsearchAsync netcoreapp3.1 2.42μs 11.2ns 44.8ns 0 0 0 1.09 KB
#7022 CallElasticsearchAsync net472 3.71μs 3.42ns 13.2ns 0.166 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.83μs 6.44ns 24.9ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.27μs 11ns 42.5ns 0 0 0 960 B
master ExecuteAsync net472 2.53μs 0.805ns 3.12ns 0.139 0 0 923 B
#7022 ExecuteAsync net6.0 1.81μs 6.5ns 25.2ns 0 0 0 960 B
#7022 ExecuteAsync netcoreapp3.1 2.29μs 7.44ns 28.8ns 0 0 0 960 B
#7022 ExecuteAsync net472 2.58μs 2.86ns 10.7ns 0.142 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.8μs 32.8ns 127ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.55μs 12.4ns 46.5ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 9.6ns 37.2ns 0.492 0 0 3.19 KB
#7022 SendAsync net6.0 6.92μs 2.92ns 10.9ns 0 0 0 2.37 KB
#7022 SendAsync netcoreapp3.1 8.64μs 12.9ns 50.1ns 0 0 0 2.9 KB
#7022 SendAsync net472 12.5μs 6.5ns 23.4ns 0.502 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7022

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.67 KB 45.5 KB 2.83 KB 6.64%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 275.34 KB 286.72 KB 11.38 KB 4.13%

Fewer allocations 🎉 in #7022

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 278.98 KB 276.05 KB -2.94 KB -1.05%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.19 KB 257.23 KB -16.96 KB -6.19%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.2μs 239ns 1.22μs 0 0 0 45.1 KB
master StringConcatBenchmark netcoreapp3.1 49.8μs 280ns 2.6μs 0 0 0 42.67 KB
master StringConcatBenchmark net472 57.3μs 170ns 612ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 490μs 2.03μs 7.03μs 0 0 0 278.98 KB
master StringConcatAspectBenchmark netcoreapp3.1 518μs 2.45μs 9.8μs 0 0 0 274.19 KB
master StringConcatAspectBenchmark net472 408μs 2.25μs 12.7μs 0 0 0 275.34 KB
#7022 StringConcatBenchmark net6.0 44.6μs 242ns 1.35μs 0 0 0 45.15 KB
#7022 StringConcatBenchmark netcoreapp3.1 53.9μs 669ns 6.59μs 0 0 0 45.5 KB
#7022 StringConcatBenchmark net472 57.3μs 94.8ns 328ns 0 0 0 65.54 KB
#7022 StringConcatAspectBenchmark net6.0 469μs 2.14μs 8.3μs 0 0 0 276.05 KB
#7022 StringConcatAspectBenchmark netcoreapp3.1 526μs 2.31μs 8.64μs 0 0 0 257.23 KB
#7022 StringConcatAspectBenchmark net472 406μs 1.91μs 7.66μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.58μs 10.5ns 40.5ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 2.62ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog net472 3.85μs 3.38ns 13.1ns 0.267 0 0 1.69 KB
#7022 EnrichedLog net6.0 2.63μs 13.3ns 62.3ns 0 0 0 1.76 KB
#7022 EnrichedLog netcoreapp3.1 3.42μs 17ns 75.8ns 0 0 0 1.76 KB
#7022 EnrichedLog net472 3.94μs 2.87ns 11.1ns 0.255 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 58.2ns 225ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 83.3ns 289ns 0 0 0 4.37 KB
master EnrichedLog net472 167μs 32.8ns 127ns 0 0 0 4.57 KB
#7022 EnrichedLog net6.0 123μs 132ns 474ns 0 0 0 4.37 KB
#7022 EnrichedLog netcoreapp3.1 128μs 117ns 422ns 0 0 0 4.37 KB
#7022 EnrichedLog net472 167μs 165ns 640ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.98μs 19.3ns 74.7ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.74μs 28.6ns 103ns 0 0 0 2.32 KB
master EnrichedLog net472 7.37μs 4.33ns 16.2ns 0.33 0 0 2.14 KB
#7022 EnrichedLog net6.0 5.03μs 9.81ns 38ns 0 0 0 2.32 KB
#7022 EnrichedLog netcoreapp3.1 6.65μs 13.2ns 51.2ns 0 0 0 2.32 KB
#7022 EnrichedLog net472 7.43μs 6.61ns 25.6ns 0.334 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.02μs 10.2ns 46.8ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.5μs 12.9ns 63.2ns 0 0 0 1.21 KB
master SendReceive net472 3.26μs 3.27ns 12.7ns 0.18 0 0 1.21 KB
#7022 SendReceive net6.0 1.98μs 9.82ns 42.8ns 0 0 0 1.21 KB
#7022 SendReceive netcoreapp3.1 2.51μs 3.23ns 12.5ns 0 0 0 1.21 KB
#7022 SendReceive net472 3.23μs 2.79ns 10.8ns 0.181 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.32μs 10.6ns 38.1ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.8μs 4.91ns 19ns 0 0 0 1.69 KB
master EnrichedLog net472 6.64μs 3.91ns 14.1ns 0.299 0 0 2.08 KB
#7022 EnrichedLog net6.0 4.25μs 7.76ns 30.1ns 0 0 0 1.64 KB
#7022 EnrichedLog netcoreapp3.1 5.69μs 11.7ns 45.2ns 0 0 0 1.69 KB
#7022 EnrichedLog net472 6.6μs 4.59ns 17.2ns 0.331 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 757ns 3.89ns 19.5ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 957ns 5.05ns 26.7ns 0 0 0 584 B
master StartFinishSpan net472 958ns 0.909ns 3.52ns 0.0896 0 0 586 B
master StartFinishScope net6.0 887ns 4.65ns 22.3ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 1.48ns 5.74ns 0 0 0 704 B
master StartFinishScope net472 1.11μs 0.226ns 0.875ns 0.102 0 0 666 B
#7022 StartFinishSpan net6.0 750ns 3.86ns 18.9ns 0 0 0 584 B
#7022 StartFinishSpan netcoreapp3.1 942ns 4.38ns 18.1ns 0 0 0 584 B
#7022 StartFinishSpan net472 907ns 0.315ns 1.22ns 0.0905 0 0 586 B
#7022 StartFinishScope net6.0 888ns 4.41ns 22ns 0 0 0 704 B
#7022 StartFinishScope netcoreapp3.1 1.17μs 6.06ns 29.7ns 0 0 0 704 B
#7022 StartFinishScope net472 1.09μs 1.79ns 6.92ns 0.104 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 2.89ns 10.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 7.06ns 34.6ns 0 0 0 704 B
master RunOnMethodBegin net472 1.41μs 0.951ns 3.56ns 0.0993 0 0 666 B
#7022 RunOnMethodBegin net6.0 1.03μs 0.648ns 2.43ns 0 0 0 704 B
#7022 RunOnMethodBegin netcoreapp3.1 1.36μs 4.27ns 16ns 0 0 0 704 B
#7022 RunOnMethodBegin net472 1.35μs 1.38ns 5.34ns 0.101 0 0 666 B

NachoEchevarria
NachoEchevarria approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@faydef faydef force-pushed the fayssal/retries-on-failure branch from f038329 to a17a16c Compare May 30, 2025 09:47
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 30, 2025 •
edited
Loading

Datadog Report

Branch report: fayssal/retries-on-failure
Commit report: a17a16c
Test service: dd-trace-dotnet

✅ 0 Failed, 257872 Passed, 2317 Skipped, 15h 10m 23.08s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (1,008ms)  : 986, 1030
     .   : milestone, 1008,
    master - mean (1,011ms)  : 986, 1036
     .   : milestone, 1011,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (104ms)  : 102, 106
     .   : milestone, 104,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (696ms)  : 684, 709
     .   : milestone, 696,
    master - mean (701ms)  : 682, 721
     .   : milestone, 701,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (88ms)  : 87, 90
     .   : milestone, 88,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (653ms)  : 631, 675
     .   : milestone, 653,
    master - mean (658ms)  : 639, 677
     .   : milestone, 658,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (190ms)  : 184, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (1,113ms)  : 1085, 1141
     .   : milestone, 1113,
    master - mean (1,108ms)  : 1082, 1135
     .   : milestone, 1108,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (269ms)  : 266, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (880ms)  : 849, 910
     .   : milestone, 880,
    master - mean (883ms)  : 846, 919
     .   : milestone, 883,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7022) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (262ms)  : 258, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7022) - mean (873ms)  : 832, 913
     .   : milestone, 873,
    master - mean (865ms)  : 832, 899
     .   : milestone, 865,
Loading

@faydef faydef merged commit b18a340 into master May 30, 2025
127 of 128 checks passed
@faydef faydef deleted the fayssal/retries-on-failure branch May 30, 2025 12:07
@github-actions github-actions bot added this to the vNext-v3 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@faydef @andrewlock @NachoEchevarria