Streamline release process by not explicitly creating a tag in `create_draft_release.yml` #7024

andrewlock · 2025-05-28T11:48:16Z

Summary of changes

Instead of manually creating a tag in create_draft_release.yml, create the tag when the release is published.

Reason for change

Currently, the workflow creates the tag before creating the release. I'm pretty sure that was because we thought a release had to be associated with an existing tag. However, as long as you specify the release sha (we do, now), then you can pass a sha instead, and when you publish the release it automatically creates the release.

The advantage of this is that we no longer need to manually start the gitlab pipeline after doing the release. We can have the publishing of the tag automatically trigger the rest of the GitLab pipeline.

One annoying thing though is that we can no longer use the "built in" GH_TOKEN, because if workflow files have changed, the release fails (because you need the workflows permissions, and you can't grant it from a workflow). Luckily we already have a token we use for invoking workflows, so we can switch to that one instead.

Implementation details

Use the external GH_TOKEN
Remove the explicit git publish
Pass the SHA into the create-release workflow
Auto trigger the gitlab run when a tag is pushed

Test coverage

I tested the create release process several times in a dummy repo to confirm it works as described above. It's also where I caught the external GH_TOKEN issue too.

Other details

I'm about 90% sure the release process was actually wrong before, and we would always tag the HEAD commit, even though we could use the artifacts from a previous commit 😕 I don't think that's what we ever actually want to do, so that's also implicitly fixed 😅

I'll update the release process docs if/when this is merged

Tip

Fun story, this apparently fixes our release note generation issue too, because authentication sucks

NachoEchevarria

Thanks!

datadog-datadog-prod-us1 · 2025-05-28T12:11:23Z

Datadog Report

Branch report: andrew/ci/implicitly-create-tag-on-release
Commit report: 1509c1c
Test service: dd-trace-dotnet

✅ 0 Failed, 251840 Passed, 2329 Skipped, 14h 54m 27.42s Total Time

andrewlock · 2025-05-28T12:24:50Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 69
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (1,008ms)  : 973, 1043
     .   : milestone, 1008,
    master - mean (1,008ms)  : 984, 1032
     .   : milestone, 1008,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (689ms)  : 671, 707
     .   : milestone, 689,
    master - mean (692ms)  : 676, 708
     .   : milestone, 692,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (650ms)  : 627, 673
     .   : milestone, 650,
    master - mean (657ms)  : 633, 681
     .   : milestone, 657,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (190ms)  : 185, 196
     .   : milestone, 190,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (1,113ms)  : 1085, 1142
     .   : milestone, 1113,
    master - mean (1,112ms)  : 1084, 1140
     .   : milestone, 1112,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (268ms)  : 264, 273
     .   : milestone, 268,
    master - mean (269ms)  : 264, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (876ms)  : 849, 902
     .   : milestone, 876,
    master - mean (878ms)  : 849, 907
     .   : milestone, 878,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7024) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (261ms)  : 259, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7024) - mean (863ms)  : 826, 900
     .   : milestone, 863,
    master - mean (868ms)  : 829, 907
     .   : milestone, 868,

pr-commenter · 2025-05-28T12:44:15Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #99 compared to master:

All benchmarks have the same speed
7 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.14 KB	6.1 KB	-34 B	-0.55%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	11.3μs	46.1ns	172ns	0	0	0	5.56 KB
master	`StartStopWithChild`	netcoreapp3.1	13.3μs	70.2ns	344ns	0	0	0	5.75 KB
master	`StartStopWithChild`	net472	21.8μs	102ns	393ns	0.96	0.24	0	6.14 KB
#99	`StartStopWithChild`	net6.0	10.5μs	43.6ns	169ns	0	0	0	5.56 KB
#99	`StartStopWithChild`	netcoreapp3.1	13.5μs	66.9ns	299ns	0	0	0	5.76 KB
#99	`StartStopWithChild`	net472	22μs	116ns	601ns	1.03	0.31	0.103	6.1 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.33 KB	3.31 KB	-23 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	921μs	81.6ns	294ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.05ms	63.7ns	221ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.25ms	73.2ns	283ns	3.33 KB
#99	`WriteAndFlushEnrichedTraces`	net6.0	921μs	87.9ns	329ns	2.7 KB
#99	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.03ms	1.08μs	4.17μs	2.7 KB
#99	`WriteAndFlushEnrichedTraces`	net472	1.22ms	168ns	630ns	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	331μs	560ns	2.17μs	0	0	197.06 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	485μs	1.98μs	7.68μs	0	0	204.77 KB
master	`AllCycleSimpleBody`	net472	437μs	211ns	818ns	36.6	2.16	236.35 KB
master	`AllCycleMoreComplexBody`	net6.0	337μs	999ns	3.6μs	0	0	200.56 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	488μs	2.22μs	9.15μs	0	0	208.18 KB
master	`AllCycleMoreComplexBody`	net472	445μs	164ns	615ns	37.9	2.23	239.88 KB
master	`ObjectExtractorSimpleBody`	net6.0	314ns	1.56ns	7.15ns	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	392ns	2.16ns	10.8ns	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	303ns	0.0307ns	0.115ns	0.0442	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.27μs	14.1ns	54.5ns	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.76μs	38ns	152ns	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.67μs	1.73ns	6.69ns	0.6	0	3.8 KB
#99	`AllCycleSimpleBody`	net6.0	327μs	1.49μs	5.79μs	0	0	197.06 KB
#99	`AllCycleSimpleBody`	netcoreapp3.1	504μs	1.77μs	6.86μs	0	0	204.77 KB
#99	`AllCycleSimpleBody`	net472	436μs	104ns	390ns	36.6	2.16	236.35 KB
#99	`AllCycleMoreComplexBody`	net6.0	337μs	1.49μs	5.78μs	0	0	200.56 KB
#99	`AllCycleMoreComplexBody`	netcoreapp3.1	488μs	1.25μs	4.84μs	0	0	208.18 KB
#99	`AllCycleMoreComplexBody`	net472	446μs	174ns	673ns	37.9	2.23	239.88 KB
#99	`ObjectExtractorSimpleBody`	net6.0	316ns	0.108ns	0.403ns	0	0	280 B
#99	`ObjectExtractorSimpleBody`	netcoreapp3.1	399ns	2.18ns	13.3ns	0	0	272 B
#99	`ObjectExtractorSimpleBody`	net472	317ns	0.0209ns	0.0808ns	0.0435	0	281 B
#99	`ObjectExtractorMoreComplexBody`	net6.0	6.37μs	1.69ns	6.53ns	0	0	3.78 KB
#99	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.79μs	27.6ns	107ns	0	0	3.69 KB
#99	`ObjectExtractorMoreComplexBody`	net472	6.87μs	4.69ns	18.1ns	0.585	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`EncodeLegacyArgs`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2
master	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
master	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmark`	net472	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	net6.0	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	N/A	N/A	N/A	NaN	NaN	NaN
#99	`RunWafRealisticBenchmarkWithAttack`	net472	N/A	N/A	N/A	NaN	NaN	NaN

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0	14.62 KB	14.53 KB	-90 B	-0.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	62.1μs	246ns	919ns	14.62 KB
master	`SendRequest`	netcoreapp3.1	72.5μs	77ns	278ns	17.42 KB
master	`SendRequest`	net472	0.0113ns	0.0018ns	0.00672ns	0 b
#99	`SendRequest`	net6.0	62.6μs	129ns	500ns	14.53 KB
#99	`SendRequest`	netcoreapp3.1	71.2μs	210ns	785ns	17.42 KB
#99	`SendRequest`	net472	0.0122ns	0.00147ns	0.00529ns	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	56.25 KB	55.86 KB	-390 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	655μs	614ns	2.38μs	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	686μs	3.94μs	33.7μs	0	42.21 KB
master	`WriteAndFlushEnrichedTraces`	net472	934μs	4.21μs	16.3μs	8.33	56.25 KB
#99	`WriteAndFlushEnrichedTraces`	net6.0	666μs	1.72μs	6.64μs	0	41.83 KB
#99	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	733μs	1.35μs	4.69μs	0	42.01 KB
#99	`WriteAndFlushEnrichedTraces`	net472	934μs	3.01μs	11.2μs	4.46	55.86 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.99μs	5.74ns	22.2ns	0	0	1.03 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.45μs	11.8ns	50.2ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.87μs	2.6ns	10.1ns	0.144	0.0144	995 B
#99	`ExecuteNonQuery`	net6.0	1.86μs	1.01ns	3.92ns	0	0	1.03 KB
#99	`ExecuteNonQuery`	netcoreapp3.1	2.54μs	9.75ns	37.8ns	0	0	1.02 KB
#99	`ExecuteNonQuery`	net472	2.75μs	3.14ns	12.1ns	0.152	0.0139	995 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.78μs	3.42ns	13.2ns	0	1.04 KB
master	`CallElasticsearch`	netcoreapp3.1	2.2μs	10.3ns	42.5ns	0	1.04 KB
master	`CallElasticsearch`	net472	3.54μs	5.44ns	21.1ns	0.158	1.05 KB
master	`CallElasticsearchAsync`	net6.0	1.83μs	9.39ns	44ns	0	1.02 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.41μs	11.2ns	44.6ns	0	1.09 KB
master	`CallElasticsearchAsync`	net472	3.63μs	1.59ns	5.95ns	0.164	1.11 KB
#99	`CallElasticsearch`	net6.0	1.73μs	9.13ns	45.7ns	0	1.04 KB
#99	`CallElasticsearch`	netcoreapp3.1	2.18μs	11ns	47.9ns	0	1.04 KB
#99	`CallElasticsearch`	net472	3.51μs	3.02ns	11.7ns	0.159	1.05 KB
#99	`CallElasticsearchAsync`	net6.0	1.8μs	1.87ns	7.24ns	0	1.02 KB
#99	`CallElasticsearchAsync`	netcoreapp3.1	2.39μs	11.2ns	44.8ns	0	1.09 KB
#99	`CallElasticsearchAsync`	net472	3.74μs	4.8ns	18.6ns	0.167	1.11 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.8μs	1.57ns	6.1ns	0	960 B
master	`ExecuteAsync`	netcoreapp3.1	2.37μs	8.31ns	32.2ns	0	960 B
master	`ExecuteAsync`	net472	2.62μs	3.11ns	12ns	0.144	923 B
#99	`ExecuteAsync`	net6.0	1.86μs	8.35ns	32.3ns	0	960 B
#99	`ExecuteAsync`	netcoreapp3.1	2.34μs	7.31ns	28.3ns	0	960 B
#99	`ExecuteAsync`	net472	2.56μs	3.34ns	13ns	0.14	923 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	6.76μs	14.6ns	56.5ns	0	2.37 KB
master	`SendAsync`	netcoreapp3.1	8.62μs	9.8ns	38ns	0	2.9 KB
master	`SendAsync`	net472	12.3μs	9.38ns	35.1ns	0.491	3.19 KB
#99	`SendAsync`	net6.0	6.67μs	13.1ns	47.1ns	0	2.37 KB
#99	`SendAsync`	netcoreapp3.1	8.42μs	26.3ns	102ns	0	2.9 KB
#99	`SendAsync`	net472	12.1μs	12.8ns	49.6ns	0.488	3.19 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #99

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	278.74 KB	277.3 KB	-1.44 KB	-0.52%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	259.16 KB	256.48 KB	-2.68 KB	-1.03%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	44.1 KB	42.9 KB	-1.21 KB	-2.74%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	45.1μs	259ns	1.78μs	43.51 KB
master	`StringConcatBenchmark`	netcoreapp3.1	47.7μs	184ns	665ns	44.1 KB
master	`StringConcatBenchmark`	net472	56.7μs	258ns	1.03μs	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	489μs	1.15μs	3.97μs	278.74 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	536μs	1.36μs	5.09μs	259.16 KB
master	`StringConcatAspectBenchmark`	net472	408μs	2.35μs	18.5μs	278.53 KB
#99	`StringConcatBenchmark`	net6.0	42.5μs	238ns	1.37μs	43.59 KB
#99	`StringConcatBenchmark`	netcoreapp3.1	48.8μs	280ns	2.08μs	42.9 KB
#99	`StringConcatBenchmark`	net472	57.1μs	263ns	1.05μs	57.34 KB
#99	`StringConcatAspectBenchmark`	net6.0	473μs	1.9μs	7.84μs	277.3 KB
#99	`StringConcatAspectBenchmark`	netcoreapp3.1	521μs	2.13μs	7.7μs	256.48 KB
#99	`StringConcatAspectBenchmark`	net472	407μs	2.17μs	11.7μs	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.64μs	3.11ns	12ns	0	1.76 KB
master	`EnrichedLog`	netcoreapp3.1	3.45μs	4.11ns	15.9ns	0	1.76 KB
master	`EnrichedLog`	net472	3.87μs	2.6ns	10.1ns	0.251	1.69 KB
#99	`EnrichedLog`	net6.0	2.54μs	11.7ns	48.3ns	0	1.76 KB
#99	`EnrichedLog`	netcoreapp3.1	3.5μs	12.1ns	47ns	0	1.76 KB
#99	`EnrichedLog`	net472	3.78μs	4.29ns	16.6ns	0.264	1.69 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	122μs	96.3ns	333ns	4.37 KB
master	`EnrichedLog`	netcoreapp3.1	127μs	80.6ns	301ns	4.37 KB
master	`EnrichedLog`	net472	168μs	210ns	814ns	4.57 KB
#99	`EnrichedLog`	net6.0	122μs	70.6ns	264ns	4.37 KB
#99	`EnrichedLog`	netcoreapp3.1	126μs	93.2ns	336ns	4.37 KB
#99	`EnrichedLog`	net472	165μs	108ns	418ns	4.57 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.91μs	5.54ns	20.7ns	0	2.32 KB
master	`EnrichedLog`	netcoreapp3.1	6.57μs	19.8ns	76.6ns	0	2.32 KB
master	`EnrichedLog`	net472	7.27μs	7.3ns	28.3ns	0.325	2.14 KB
#99	`EnrichedLog`	net6.0	5.05μs	13.6ns	52.8ns	0	2.32 KB
#99	`EnrichedLog`	netcoreapp3.1	6.63μs	14.6ns	54.7ns	0	2.32 KB
#99	`EnrichedLog`	net472	7.3μs	5.23ns	20.3ns	0.326	2.14 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.06μs	2.54ns	9.82ns	0	1.21 KB
master	`SendReceive`	netcoreapp3.1	2.59μs	13.2ns	57.7ns	0	1.21 KB
master	`SendReceive`	net472	3.02μs	4.81ns	18.6ns	0.182	1.21 KB
#99	`SendReceive`	net6.0	1.98μs	10.4ns	51.8ns	0	1.21 KB
#99	`SendReceive`	netcoreapp3.1	2.73μs	8.57ns	33.2ns	0	1.21 KB
#99	`SendReceive`	net472	2.99μs	6.16ns	23.8ns	0.178	1.21 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.09μs	4.14ns	15.5ns	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	5.62μs	5.07ns	19ns	0	1.69 KB
master	`EnrichedLog`	net472	6.59μs	8.33ns	32.3ns	0.328	2.08 KB
#99	`EnrichedLog`	net6.0	4.3μs	12.3ns	46.1ns	0	1.64 KB
#99	`EnrichedLog`	netcoreapp3.1	5.5μs	19.4ns	75.3ns	0	1.69 KB
#99	`EnrichedLog`	net472	6.42μs	5.37ns	20.1ns	0.32	2.08 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	737ns	4.06ns	24.7ns	0	584 B
master	`StartFinishSpan`	netcoreapp3.1	967ns	0.621ns	2.4ns	0	584 B
master	`StartFinishSpan`	net472	910ns	0.106ns	0.41ns	0.091	586 B
master	`StartFinishScope`	net6.0	926ns	4.56ns	18.8ns	0	704 B
master	`StartFinishScope`	netcoreapp3.1	1.18μs	5.29ns	20.5ns	0	704 B
master	`StartFinishScope`	net472	1.14μs	0.134ns	0.518ns	0.103	666 B
#99	`StartFinishSpan`	net6.0	749ns	0.463ns	1.79ns	0	584 B
#99	`StartFinishSpan`	netcoreapp3.1	954ns	4.5ns	18ns	0	584 B
#99	`StartFinishSpan`	net472	891ns	0.248ns	0.927ns	0.0898	586 B
#99	`StartFinishScope`	net6.0	903ns	4.33ns	17.3ns	0	704 B
#99	`StartFinishScope`	netcoreapp3.1	1.12μs	5.75ns	27.6ns	0	704 B
#99	`StartFinishScope`	net472	1.08μs	0.102ns	0.397ns	0.102	666 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.03μs	1.12ns	4.04ns	0	704 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.34μs	5.3ns	20.5ns	0	704 B
master	`RunOnMethodBegin`	net472	1.34μs	1.47ns	5.69ns	0.101	666 B
#99	`RunOnMethodBegin`	net6.0	1.02μs	4.83ns	20.5ns	0	704 B
#99	`RunOnMethodBegin`	netcoreapp3.1	1.37μs	0.778ns	2.91ns	0	704 B
#99	`RunOnMethodBegin`	net472	1.34μs	0.571ns	2.21ns	0.1	666 B

andrewlock added 3 commits May 28, 2025 11:29

Streamline release process by not explicitly creating a tag

601b356

Make sure we pass the sha to the release

561f82f

Use external token

1509c1c

andrewlock requested a review from a team as a code owner May 28, 2025 11:48

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 28, 2025

NachoEchevarria approved these changes May 28, 2025

View reviewed changes

bouwkast approved these changes May 28, 2025

View reviewed changes

andrewlock merged commit 397ad0e into master May 28, 2025
127 checks passed

andrewlock deleted the andrew/ci/implicitly-create-tag-on-release branch May 28, 2025 13:27

github-actions bot added this to the vNext-v3 milestone May 28, 2025

Streamline release process by not explicitly creating a tag in create_draft_release.yml #7024

Streamline release process by not explicitly creating a tag in create_draft_release.yml #7024

Uh oh!

Conversation

andrewlock commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

NachoEchevarria left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented May 28, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

pr-commenter bot commented May 28, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

Fewer allocations 🎉 in #99

Raw results

Fewer allocations 🎉 in #99

Raw results

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #99

Raw results

Fewer allocations 🎉 in #99

Raw results

Raw results

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #99

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Uh oh!

Uh oh!

Streamline release process by not explicitly creating a tag in `create_draft_release.yml` #7024

Streamline release process by not explicitly creating a tag in `create_draft_release.yml` #7024

andrewlock commented May 28, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented May 28, 2025 •

edited

Loading