[Test Package Versions Bump] Updating package versions #6732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 248746 Passed, 2407 Skipped, 20h 47m 27.48s Total Time ⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (69ms) : 67, 72
. : milestone, 69,
master - mean (69ms) : 67, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (1,010ms) : 985, 1034
. : milestone, 1010,
master - mean (1,006ms) : 977, 1034
. : milestone, 1006,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (102ms) : 100, 105
. : milestone, 102,
master - mean (102ms) : 99, 105
. : milestone, 102,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (688ms) : 674, 702
. : milestone, 688,
master - mean (685ms) : 669, 702
. : milestone, 685,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (89ms) : 88, 91
. : milestone, 89,
master - mean (89ms) : 86, 91
. : milestone, 89,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (641ms) : 624, 658
. : milestone, 641,
master - mean (642ms) : 622, 662
. : milestone, 642,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (190ms) : 185, 195
. : milestone, 190,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (1,111ms) : 1078, 1144
. : milestone, 1111,
master - mean (1,107ms) : 1085, 1130
. : milestone, 1107,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (270ms) : 266, 273
. : milestone, 270,
master - mean (269ms) : 265, 273
. : milestone, 269,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (880ms) : 846, 914
. : milestone, 880,
master - mean (876ms) : 839, 912
. : milestone, 876,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6732) - mean (262ms) : 259, 265
. : milestone, 262,
master - mean (262ms) : 258, 265
. : milestone, 262,
section CallTarget+Inlining+NGEN
This PR (6732) - mean (860ms) : 831, 889
. : milestone, 860,
master - mean (859ms) : 828, 890
. : milestone, 859,
|
Benchmarks Report for tracer 🐌Benchmarks for #6732 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
bouwkast
approved these changes
Mar 3, 2025
| @@ -354,13 +354,13 @@ | |||
|
|
|||
| <!-- Integration: xunit.v3.core --> | |||
| <!-- Assembly: xunit.v3.core --> | |||
| <!-- Latest package https://www.nuget.org/packages/xunit.v3/1.1.0 --> | |||
| <!-- Latest package https://www.nuget.org/packages/xunit.v3/2.0.0 --> | |||
| <!-- Latest package https://www.nuget.org/packages/IBMMQDotnetClient/9.4.1 --> | ||
| <PackageReference Include="IBMMQDotnetClient" Version="9.4.1" /> | ||
| <!-- Latest package https://www.nuget.org/packages/IBMMQDotnetClient/9.4.2 --> | ||
| <PackageReference Include="IBMMQDotnetClient" Version="9.4.2" /> |
There was a problem hiding this comment.
Think will need to look into what changed here as we don't run these on CI
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.47.1 --> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.47.1" /> | ||
| <!-- Latest package https://www.nuget.org/packages/Microsoft.Azure.Cosmos/3.47.2 --> | ||
| <PackageReference Include="Microsoft.Azure.Cosmos" Version="3.47.2" /> |
There was a problem hiding this comment.
Will need to test this out locally.
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
from
c796646 to
094b706
Compare
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
from
094b706 to
a2a9a6c
Compare
andrewlock
requested changes
Mar 17, 2025
andrewlock
added a commit
that referenced
this pull request
Mar 18, 2025
## Summary of changes Fixes the Microsoft.Extensions.Telemetry integration for 9.3.0 ## Reason for change 9.3.0 [introduced a new optional parameter](dotnet/extensions#5574) to a public method we instrument, breaking our integration ## Implementation details Add instrumentation for the new signature ## Test coverage This is the test - if everything passes, we're good ## Other details Identified in #6732
github-actions
bot
force-pushed
the
bot/test-package-versions-bump
branch
from
a2a9a6c to
afb4173
Compare
bouwkast
added
area:test-apps
ddyurchenko
pushed a commit
that referenced
this pull request
Mar 31, 2025
## Summary of changes Fixes the Microsoft.Extensions.Telemetry integration for 9.3.0 ## Reason for change 9.3.0 [introduced a new optional parameter](dotnet/extensions#5574) to a public method we instrument, breaking our integration ## Implementation details Add instrumentation for the new signature ## Test coverage This is the test - if everything passes, we're good ## Other details Identified in #6732
ddyurchenko
pushed a commit
that referenced
this pull request
Mar 31, 2025
Updates the package versions for integration tests. Co-authored-by: andrewlock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package versions for integration tests.