Skip to content

Use code owners in build variable generation #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 5, 2025
Merged

Use code owners in build variable generation #6896

merged 12 commits into from
May 5, 2025

Conversation

NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Apr 25, 2025 •
edited
Loading

Summary of changes

We detected changes in the different areas based on some hardcoded folders and files in the build project. Codeowners has a more detailed and updated set of owned files per teams. We can use that information to deduplicate the process. A codeowners file parser has been added to the build project in order to generate the pipelines variables according to that information.

The codeowners file itself has also been updated (remove not needed values, add missing ones and correct some of them)

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 25, 2025
@andrewlock
Copy link
Member

andrewlock commented Apr 25, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6896 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.137
  • 1 benchmarks are slower, with geometric mean 1.163
  • 1 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6896

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.73 KB 5.8 KB 63 B 1.10%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.13 KB 6.18 KB 42 B 0.68%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.57 KB 5.61 KB 35 B 0.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.74μs 90.1ns 896ns 0 0 0 5.57 KB
master StartStopWithChild netcoreapp3.1 10.1μs 148ns 1.48μs 0 0 0 5.73 KB
master StartStopWithChild net472 15.3μs 87.8ns 697ns 1.04 0.297 0.0741 6.13 KB
#6896 StartStopWithChild net6.0 8.3μs 155ns 1.55μs 0 0 0 5.61 KB
#6896 StartStopWithChild netcoreapp3.1 10.7μs 116ns 1.16μs 0 0 0 5.8 KB
#6896 StartStopWithChild net472 15.3μs 85.8ns 575ns 1 0.286 0.0714 6.18 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 513μs 5.69μs 50.6μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 854ns 3.19μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 841μs 2.7μs 10.1μs 0 0 0 3.31 KB
#6896 WriteAndFlushEnrichedTraces net6.0 494μs 1.32μs 4.93μs 0 0 0 2.7 KB
#6896 WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 725ns 2.71μs 0 0 0 2.7 KB
#6896 WriteAndFlushEnrichedTraces net472 869μs 618ns 2.23μs 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 127μs 626ns 2.66μs 0 0 0 14.48 KB
master SendRequest netcoreapp3.1 141μs 821ns 7.15μs 0 0 0 17.28 KB
master SendRequest net472 0.00158ns 0.000518ns 0.00201ns 0 0 0 0 b
#6896 SendRequest net6.0 129μs 753ns 6.94μs 0 0 0 14.48 KB
#6896 SendRequest netcoreapp3.1 150μs 338ns 1.79μs 0 0 0 17.28 KB
#6896 SendRequest net472 0.000113ns 0.000113ns 0.000407ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6896

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.81 KB 41.5 KB -307 B -0.73%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 653μs 7.16μs 70.9μs 0 0 0 41.81 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 745μs 8.26μs 80.5μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 871μs 4.95μs 46.7μs 7.35 3.68 0 53.37 KB
#6896 WriteAndFlushEnrichedTraces net6.0 639μs 8.76μs 87.2μs 0 0 0 41.5 KB
#6896 WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 3.83μs 28.7μs 0 0 0 41.82 KB
#6896 WriteAndFlushEnrichedTraces net472 852μs 5.31μs 52μs 4.46 0 0 53.37 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 3.03ns 11.3ns 0.0129 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 3.2ns 11.1ns 0.00901 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 1.56ns 5.83ns 0.153 0.0109 0 995 B
#6896 ExecuteNonQuery net6.0 1.39μs 3.62ns 14ns 0.0142 0 0 1.03 KB
#6896 ExecuteNonQuery netcoreapp3.1 1.76μs 4.1ns 15.9ns 0.00874 0 0 1.02 KB
#6896 ExecuteNonQuery net472 2.08μs 5.64ns 21.8ns 0.154 0.0103 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 1.17ns 4.53ns 0.0133 0 0 984 B
master CallElasticsearch netcoreapp3.1 1.6μs 1.34ns 4.83ns 0.00809 0 0 984 B
master CallElasticsearch net472 2.58μs 1.38ns 4.98ns 0.154 0 0 1 KB
master CallElasticsearchAsync net6.0 1.28μs 1.58ns 6.13ns 0.0126 0 0 960 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 1.34ns 5.17ns 0.00864 0 0 1.03 KB
master CallElasticsearchAsync net472 2.6μs 1.17ns 4.53ns 0.156 0 0 1.06 KB
#6896 CallElasticsearch net6.0 1.24μs 1.57ns 6.09ns 0.0123 0 0 984 B
#6896 CallElasticsearch netcoreapp3.1 1.6μs 1.65ns 6.17ns 0.00798 0 0 984 B
#6896 CallElasticsearch net472 2.49μs 2.39ns 8.96ns 0.149 0 0 1 KB
#6896 CallElasticsearchAsync net6.0 1.16μs 1.09ns 4.08ns 0.0118 0 0 960 B
#6896 CallElasticsearchAsync netcoreapp3.1 1.7μs 2ns 7.75ns 0.00851 0 0 1.03 KB
#6896 CallElasticsearchAsync net472 2.78μs 2.06ns 7.72ns 0.167 0 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 0.862ns 3.23ns 0.0135 0 0 960 B
master ExecuteAsync netcoreapp3.1 1.62μs 1.7ns 6.12ns 0.00819 0 0 960 B
master ExecuteAsync net472 1.81μs 0.999ns 3.74ns 0.145 0 0 923 B
#6896 ExecuteAsync net6.0 1.29μs 0.746ns 2.79ns 0.0128 0 0 960 B
#6896 ExecuteAsync netcoreapp3.1 1.63μs 5.87ns 22.7ns 0.00813 0 0 960 B
#6896 ExecuteAsync net472 1.75μs 0.75ns 2.91ns 0.14 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.4μs 1.76ns 6.09ns 0.0221 0 0 2.32 KB
master SendAsync netcoreapp3.1 5.29μs 9.69ns 37.5ns 0.0263 0 0 2.86 KB
master SendAsync net472 7.45μs 5.2ns 19.5ns 0.49 0 0 3.13 KB
#6896 SendAsync net6.0 4.46μs 4.01ns 15.5ns 0.0225 0 0 2.32 KB
#6896 SendAsync netcoreapp3.1 5.5μs 10.6ns 39.5ns 0.0273 0 0 2.86 KB
#6896 SendAsync net472 7.33μs 5.17ns 20ns 0.476 0 0 3.13 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6896

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.137 1,679.31 1,476.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.68μs 1.82ns 7.07ns 0.0168 0 0 1.71 KB
master EnrichedLog netcoreapp3.1 2.34μs 1.83ns 7.09ns 0.0118 0 0 1.71 KB
master EnrichedLog net472 2.65μs 1.81ns 7.02ns 0.25 0 0 1.64 KB
#6896 EnrichedLog net6.0 1.48μs 2.16ns 7.8ns 0.0221 0 0 1.71 KB
#6896 EnrichedLog netcoreapp3.1 2.23μs 1.46ns 5.26ns 0.0225 0 0 1.71 KB
#6896 EnrichedLog net472 2.66μs 1.79ns 6.44ns 0.252 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 295ns 1.14μs 0 0 0 4.32 KB
master EnrichedLog netcoreapp3.1 115μs 424ns 1.64μs 0 0 0 4.32 KB
master EnrichedLog net472 149μs 226ns 876ns 0 0 0 4.51 KB
#6896 EnrichedLog net6.0 111μs 226ns 846ns 0 0 0 4.32 KB
#6896 EnrichedLog netcoreapp3.1 116μs 215ns 803ns 0 0 0 4.32 KB
#6896 EnrichedLog net472 151μs 186ns 722ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.26μs 2.4ns 9.29ns 0.0331 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 4.27μs 5.13ns 19.9ns 0.0214 0 0 2.26 KB
master EnrichedLog net472 4.89μs 3.09ns 12ns 0.318 0 0 2.09 KB
#6896 EnrichedLog net6.0 3.08μs 2.87ns 10.7ns 0.0304 0 0 2.26 KB
#6896 EnrichedLog netcoreapp3.1 4.3μs 3.08ns 11.1ns 0.0217 0 0 2.26 KB
#6896 EnrichedLog net472 4.96μs 3.12ns 12.1ns 0.323 0 0 2.09 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 1.14ns 4.41ns 0.0138 0 0 1.15 KB
master SendReceive netcoreapp3.1 1.8μs 1.13ns 4.22ns 0.00907 0 0 1.15 KB
master SendReceive net472 2.16μs 1.57ns 6.06ns 0.179 0 0 1.16 KB
#6896 SendReceive net6.0 1.3μs 0.826ns 3.2ns 0.013 0 0 1.15 KB
#6896 SendReceive netcoreapp3.1 1.81μs 2.28ns 8.85ns 0.00907 0 0 1.15 KB
#6896 SendReceive net472 2.06μs 1.28ns 4.77ns 0.182 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 1.73ns 6.69ns 0.0142 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.18ns 7.85ns 0.0194 0 0 1.69 KB
master EnrichedLog net472 4.46μs 2.75ns 10.6ns 0.313 0 0 2.08 KB
#6896 EnrichedLog net6.0 2.73μs 2.28ns 8.52ns 0.0136 0 0 1.64 KB
#6896 EnrichedLog netcoreapp3.1 3.94μs 3.09ns 12ns 0.0196 0 0 1.69 KB
#6896 EnrichedLog net472 4.53μs 2.66ns 9.96ns 0.32 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 412ns 0.354ns 1.32ns 0.00815 0 0 584 B
master StartFinishSpan netcoreapp3.1 582ns 0.765ns 2.96ns 0.00573 0 0 584 B
master StartFinishSpan net472 658ns 0.658ns 2.37ns 0.0922 0 0 586 B
master StartFinishScope net6.0 492ns 0.316ns 1.18ns 0.00975 0 0 704 B
master StartFinishScope netcoreapp3.1 752ns 0.69ns 2.58ns 0.00755 0 0 704 B
master StartFinishScope net472 838ns 0.778ns 3.01ns 0.105 0 0 666 B
#6896 StartFinishSpan net6.0 410ns 0.525ns 2.03ns 0.00817 0 0 584 B
#6896 StartFinishSpan netcoreapp3.1 646ns 1.22ns 4.72ns 0.00651 0 0 584 B
#6896 StartFinishSpan net472 640ns 0.287ns 1.11ns 0.09 0 0 586 B
#6896 StartFinishScope net6.0 513ns 0.227ns 0.85ns 0.00763 0 0 704 B
#6896 StartFinishScope netcoreapp3.1 727ns 0.499ns 1.87ns 0.00729 0 0 704 B
#6896 StartFinishScope net472 764ns 0.269ns 1.01ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6896

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.163 597.07 694.16

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 597ns 0.475ns 1.84ns 0.00901 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1μs 1.28ns 4.78ns 0.00501 0 0 704 B
master RunOnMethodBegin net472 1.14μs 1.45ns 5.62ns 0.102 0 0 666 B
#6896 RunOnMethodBegin net6.0 694ns 0.768ns 2.97ns 0.00695 0 0 704 B
#6896 RunOnMethodBegin netcoreapp3.1 994ns 0.864ns 3.23ns 0.00491 0 0 704 B
#6896 RunOnMethodBegin net472 1.09μs 1.07ns 4.02ns 0.103 0 0 666 B

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 25, 2025 •
edited
Loading

Datadog Report

Branch report: nacho/UseCodeOwnersInVariableGeneration
Commit report: c6bead5
Test service: dd-trace-dotnet

✅ 0 Failed, 251747 Passed, 2299 Skipped, 18h 8m 35.13s Total Time

@andrewlock
Copy link
Member

andrewlock commented Apr 25, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (1,011ms)  : 981, 1040
     .   : milestone, 1011,
    master - mean (1,007ms)  : 987, 1027
     .   : milestone, 1007,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (695ms)  : 667, 724
     .   : milestone, 695,
    master - mean (694ms)  : 671, 717
     .   : milestone, 694,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (650ms)  : 628, 672
     .   : milestone, 650,
    master - mean (657ms)  : 632, 683
     .   : milestone, 657,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (189ms)  : 185, 194
     .   : milestone, 189,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (1,112ms)  : 1085, 1140
     .   : milestone, 1112,
    master - mean (1,104ms)  : 1075, 1133
     .   : milestone, 1104,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (880ms)  : 849, 911
     .   : milestone, 880,
    master - mean (882ms)  : 854, 910
     .   : milestone, 882,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6896) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (260ms)  : 257, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (6896) - mean (863ms)  : 830, 895
     .   : milestone, 863,
    master - mean (870ms)  : 842, 899
     .   : milestone, 870,
Loading

@NachoEchevarria NachoEchevarria changed the title Nacho/use code owners in variable generation Use code owners in build variable generation Apr 25, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 25, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for tracer 🐌

Benchmarks for #6896 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.171
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6896

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.2 KB 6.15 KB -42 B -0.68%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 57.9ns 328ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.5μs 62ns 248ns 0 0 0 5.76 KB
master StartStopWithChild net472 22.5μs 114ns 537ns 0.947 0.21 0 6.2 KB
#6896 StartStopWithChild net6.0 10.7μs 56ns 291ns 0 0 0 5.56 KB
#6896 StartStopWithChild netcoreapp3.1 13.8μs 66.6ns 275ns 0 0 0 5.75 KB
#6896 StartStopWithChild net472 21.2μs 112ns 559ns 0.912 0.228 0 6.15 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 929μs 42.1ns 152ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 472ns 1.83μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 87.2ns 326ns 0 0 0 3.31 KB
#6896 WriteAndFlushEnrichedTraces net6.0 935μs 82.1ns 307ns 0 0 0 2.71 KB
#6896 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 231ns 893ns 0 0 0 2.7 KB
#6896 WriteAndFlushEnrichedTraces net472 1.23ms 25.9ns 97ns 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 47ns 176ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 71.8μs 349ns 1.56μs 0 0 0 17.42 KB
master SendRequest net472 0.011ns 0.00348ns 0.0135ns 0 0 0 0 b
#6896 SendRequest net6.0 60.8μs 69.4ns 269ns 0 0 0 14.53 KB
#6896 SendRequest netcoreapp3.1 70μs 129ns 483ns 0 0 0 17.42 KB
#6896 SendRequest net472 0.00886ns 0.00238ns 0.0092ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6896

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.171 746,846.63 637,959.82 bimodal

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 725μs 2.03μs 7.58μs 0 0 0 41.74 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 749μs 4.17μs 26.1μs 0 0 0 41.9 KB
master WriteAndFlushEnrichedTraces net472 885μs 4.39μs 18.1μs 8.33 0 0 56.08 KB
#6896 WriteAndFlushEnrichedTraces net6.0 788μs 3.03μs 11.7μs 0 0 0 41.64 KB
#6896 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 2.72μs 10.5μs 0 0 0 41.9 KB
#6896 WriteAndFlushEnrichedTraces net472 876μs 3.07μs 11.9μs 8.33 0 0 55.91 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 7.2ns 27.9ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.4μs 10.1ns 39.1ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.77μs 2.61ns 10.1ns 0.153 0.0139 0 995 B
#6896 ExecuteNonQuery net6.0 2.09μs 3.08ns 11.9ns 0 0 0 1.03 KB
#6896 ExecuteNonQuery netcoreapp3.1 2.56μs 5.33ns 20.6ns 0 0 0 1.02 KB
#6896 ExecuteNonQuery net472 2.83μs 5.47ns 21.2ns 0.157 0.0143 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.79μs 2.44ns 9.44ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.35μs 11.3ns 43.9ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.53μs 2.5ns 9.67ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.84μs 3.11ns 12ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.37μs 10.4ns 40.3ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.6μs 3.08ns 11.9ns 0.161 0 0 1.11 KB
#6896 CallElasticsearch net6.0 1.83μs 8.8ns 35.2ns 0 0 0 1.04 KB
#6896 CallElasticsearch netcoreapp3.1 2.32μs 9.83ns 38.1ns 0 0 0 1.04 KB
#6896 CallElasticsearch net472 3.51μs 3.1ns 12ns 0.157 0 0 1.05 KB
#6896 CallElasticsearchAsync net6.0 1.83μs 9.27ns 43.5ns 0 0 0 1.02 KB
#6896 CallElasticsearchAsync netcoreapp3.1 2.43μs 1.3ns 4.85ns 0 0 0 1.09 KB
#6896 CallElasticsearchAsync net472 3.62μs 1.67ns 6.24ns 0.163 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.82μs 1.9ns 7.37ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.3μs 11.1ns 45.8ns 0 0 0 960 B
master ExecuteAsync net472 2.57μs 5.99ns 23.2ns 0.141 0 0 923 B
#6896 ExecuteAsync net6.0 1.82μs 2.5ns 9.69ns 0 0 0 960 B
#6896 ExecuteAsync netcoreapp3.1 2.35μs 6.64ns 25.7ns 0 0 0 960 B
#6896 ExecuteAsync net472 2.52μs 1.37ns 4.95ns 0.138 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.91μs 13.8ns 53.3ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.38μs 13ns 50.4ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 9.86ns 38.2ns 0.487 0 0 3.19 KB
#6896 SendAsync net6.0 7.11μs 9.76ns 36.5ns 0 0 0 2.37 KB
#6896 SendAsync netcoreapp3.1 8.42μs 28.7ns 111ns 0 0 0 2.9 KB
#6896 SendAsync net472 12.5μs 8.98ns 34.8ns 0.499 0 0 3.19 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 1.2ns 4.64ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.47μs 16.7ns 64.7ns 0 0 0 1.76 KB
master EnrichedLog net472 4.07μs 4.57ns 17.7ns 0.264 0 0 1.69 KB
#6896 EnrichedLog net6.0 2.6μs 13.6ns 70.6ns 0 0 0 1.76 KB
#6896 EnrichedLog netcoreapp3.1 3.49μs 14.2ns 55ns 0 0 0 1.76 KB
#6896 EnrichedLog net472 3.95μs 5.59ns 21.6ns 0.255 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 206ns 772ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 133μs 676ns 2.95μs 0 0 0 4.37 KB
master EnrichedLog net472 173μs 806ns 3.22μs 0 0 0 4.57 KB
#6896 EnrichedLog net6.0 124μs 230ns 831ns 0 0 0 4.37 KB
#6896 EnrichedLog netcoreapp3.1 131μs 562ns 2.18μs 0 0 0 4.37 KB
#6896 EnrichedLog net472 179μs 436ns 1.69μs 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.09μs 21.2ns 82.3ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.69μs 23.7ns 91.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.28μs 5.57ns 20.8ns 0.326 0 0 2.14 KB
#6896 EnrichedLog net6.0 4.98μs 11.3ns 43.9ns 0 0 0 2.32 KB
#6896 EnrichedLog netcoreapp3.1 6.6μs 3.2ns 12ns 0 0 0 2.32 KB
#6896 EnrichedLog net472 7.25μs 5.12ns 19.8ns 0.326 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.99μs 9.91ns 45.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.63μs 11.5ns 44.6ns 0 0 0 1.21 KB
master SendReceive net472 3.06μs 6.39ns 24.8ns 0.181 0 0 1.21 KB
#6896 SendReceive net6.0 1.99μs 9.59ns 41.8ns 0 0 0 1.21 KB
#6896 SendReceive netcoreapp3.1 2.57μs 13.4ns 67.1ns 0 0 0 1.21 KB
#6896 SendReceive net472 3.11μs 6.93ns 26.8ns 0.186 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.24μs 8.19ns 31.7ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.79μs 5.26ns 20.4ns 0 0 0 1.69 KB
master EnrichedLog net472 6.68μs 8.78ns 34ns 0.328 0 0 2.08 KB
#6896 EnrichedLog net6.0 4.24μs 11.1ns 41.7ns 0 0 0 1.64 KB
#6896 EnrichedLog netcoreapp3.1 5.72μs 16.2ns 62.5ns 0 0 0 1.69 KB
#6896 EnrichedLog net472 6.62μs 9.6ns 37.2ns 0.33 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 750ns 3.86ns 18.9ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 952ns 2.58ns 9.99ns 0 0 0 584 B
master StartFinishSpan net472 911ns 0.316ns 1.23ns 0.0915 0 0 586 B
master StartFinishScope net6.0 905ns 4.74ns 24.2ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.14μs 5.74ns 25.7ns 0 0 0 704 B
master StartFinishScope net472 1.11μs 0.379ns 1.42ns 0.105 0 0 666 B
#6896 StartFinishSpan net6.0 763ns 3.53ns 13.7ns 0 0 0 584 B
#6896 StartFinishSpan netcoreapp3.1 980ns 0.735ns 2.85ns 0 0 0 584 B
#6896 StartFinishSpan net472 912ns 0.148ns 0.533ns 0.0918 0 0 586 B
#6896 StartFinishScope net6.0 910ns 4.72ns 23.6ns 0 0 0 704 B
#6896 StartFinishScope netcoreapp3.1 1.15μs 6.03ns 28.9ns 0 0 0 704 B
#6896 StartFinishScope net472 1.1μs 0.0821ns 0.318ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.33ns 26.1ns 0 0 0 705 B
master RunOnMethodBegin netcoreapp3.1 1.33μs 6.74ns 28.6ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.734ns 2.84ns 0.102 0 0 666 B
#6896 RunOnMethodBegin net6.0 1.04μs 1.01ns 3.9ns 0 0 0 704 B
#6896 RunOnMethodBegin netcoreapp3.1 1.42μs 7.18ns 34.4ns 0 0 0 704 B
#6896 RunOnMethodBegin net472 1.44μs 1.08ns 4.03ns 0.101 0 0 666 B

@NachoEchevarria NachoEchevarria marked this pull request as ready for review April 29, 2025 08:28
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner April 29, 2025 08:28
andrewlock
andrewlock approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

tracer/build/_build/_build.csproj
@@ -58,13 +58,18 @@
<Content Include="..\..\..\.azure-pipelines\ultimate-pipeline.yml" Link="ci\ultimate-pipeline.yml" />
<Content Include="..\..\build_in_docker.sh" Link="boot\build_in_docker.sh" />
<Content Include="..\..\build_in_docker.ps1" Link="boot\build_in_docker.ps1" />
<Content Include="..\..\..\.github\CODEOWNERS" Condition="Exists('..\..\..\.github\CODEOWNERS')" Link="CodeOwners\CODEOWNERS">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the Condition? 🤔 I'm guessing this is the problem that in some parts of the CI, we run from this folder and the file isn't "available"? But wouldn't that impact the links about too, like the azure-pipelines? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, some builds were failing because of that. I think that it fails because of CopyToOutputDirectory. The other ones do not have it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it fails because of CopyToOutputDirectory.

That's kind of weird, but ok 😅

bricefriha
bricefriha reviewed Apr 29, 2025
View reviewed changes
@NachoEchevarria NachoEchevarria merged commit 6c8e40b into master May 5, 2025
127 of 128 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/UseCodeOwnersInVariableGeneration branch May 5, 2025 08:29
@github-actions github-actions bot added this to the vNext-v3 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@bricefriha bricefriha bricefriha left review comments

@e-n-0 e-n-0 e-n-0 approved these changes

@GreenMatan GreenMatan GreenMatan approved these changes

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NachoEchevarria @andrewlock @e-n-0 @GreenMatan @bricefriha @daniel-romano-DD