chore(telemetry): track whether tracing was enabled via ssi #6938

mabdinur · 2025-05-07T21:35:55Z

Summary of changes

Submits instrumentation_source configuration to the instrumentation telemetry platform to track the source of ddtrace instrumentations.

Reason for change

We need to know whether ssi was successful.

Implementation details

Emit instrumentation_source configuration with the value ssi to the instrumentation telemetry platform if a process was instrumented via Single Step Instrumentation. Otherwise report unknown.

Next Steps [p1]: Detect whether ddtool or environments variables were used to "manually" instrument an application.

Test coverage

Validated by: DataDog/system-tests#4543

Other details

This is a first attempt. It only tracks if ssi is used to configure tracing. Profiling is out of scope for now.

datadog-datadog-prod-us1 · 2025-05-07T21:57:58Z

Datadog Report

All test runs ad90746 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
❄️ 1 with New Flaky

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`dd-trace-dotnet`	0	0	2	251099	2483	18h 47m 10.77s	Link
`exploration_tests`	0	0	0	22085	3	2m 14.68s	Link

andrewlock · 2025-05-08T12:37:56Z

tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

+            }
+            else
+            {
+                string? value = EnvironmentHelpers.GetEnvironmentVariable("DD_INSTRUMENTATION_INSTALL_TYPE");


FYI, this value is already tracked separately by telemetry - it's explicitly part of the app-started payload 🤔

Yup, I changed this a little bit. The accepted values for instrumentation_source will be ssi, cmd_line (which should detect if ddtool was used), and env_var.

datadog-datadog-prod-us1 · 2025-05-12T18:51:26Z

Datadog Summary

✅ Code Quality ✅ Code Security ✅ Dependencies

Test Optimization Report

All test runs c5d0559 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`dd-trace-dotnet`	0	0	0	252088	2300	17h 27m 40.32s	Link
`exploration_tests`	0	0	0	22085	3	2m 9.48s	Link

Was this helpful? Give us feedback!

andrewlock · 2025-05-12T19:22:49Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (72ms)  : 69, 76
     .   : milestone, 72,
    master - mean (74ms)  : 69, 79
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (1,061ms)  : 1041, 1082
     .   : milestone, 1061,
    master - mean (1,069ms)  : 1049, 1089
     .   : milestone, 1069,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (728ms)  : 714, 743
     .   : milestone, 728,
    master - mean (744ms)  : 723, 765
     .   : milestone, 744,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (96ms)  : 93, 98
     .   : milestone, 96,
    master - mean (97ms)  : 93, 101
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (698ms)  : 671, 725
     .   : milestone, 698,
    master - mean (712ms)  : 685, 739
     .   : milestone, 712,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (1,168ms)  : 1151, 1185
     .   : milestone, 1168,
    master - mean (1,166ms)  : 1149, 1182
     .   : milestone, 1166,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (270ms)  : 267, 273
     .   : milestone, 270,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (934ms)  : 921, 948
     .   : milestone, 934,
    master - mean (932ms)  : 920, 943
     .   : milestone, 932,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6938) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (262ms)  : 258, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6938) - mean (927ms)  : 911, 942
     .   : milestone, 927,
    master - mean (928ms)  : 911, 944
     .   : milestone, 928,

tracer/test/Datadog.Trace.Tests/Telemetry/Collectors/ConfigurationTelemetryCollectorTests.cs

pr-commenter · 2025-05-13T23:28:04Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #6938 compared to master:

2 benchmarks are slower, with geometric mean 1.208
4 benchmarks have fewer allocations
7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.09 KB	6.13 KB	45 B	0.74%

Fewer allocations 🎉 in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0	5.58 KB	5.53 KB	-46 B	-0.82%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	11.2μs	59.7ns	322ns	0	0	0	5.58 KB
master	`StartStopWithChild`	netcoreapp3.1	14.1μs	67.5ns	286ns	0	0	0	5.75 KB
master	`StartStopWithChild`	net472	22.1μs	119ns	651ns	1.03	0.411	0.103	6.09 KB
#6938	`StartStopWithChild`	net6.0	10.5μs	57ns	332ns	0	0	0	5.53 KB
#6938	`StartStopWithChild`	netcoreapp3.1	13.9μs	70.5ns	323ns	0	0	0	5.77 KB
#6938	`StartStopWithChild`	net472	22.2μs	118ns	599ns	1.07	0.321	0.107	6.13 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.33 KB	3.31 KB	-23 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	927μs	26.6ns	103ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.04ms	404ns	1.56μs	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.25ms	357ns	1.38μs	3.33 KB
#6938	`WriteAndFlushEnrichedTraces`	net6.0	926μs	81ns	303ns	2.71 KB
#6938	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.06ms	83.9ns	325ns	2.7 KB
#6938	`WriteAndFlushEnrichedTraces`	net472	1.23ms	860ns	3.33μs	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472	236.35 KB	239.64 KB	3.28 KB	1.39%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472	239.87 KB	243.15 KB	3.28 KB	1.37%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	331μs	1.76μs	8.42μs	0	0	197.06 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	510μs	1.45μs	5.61μs	0	0	204.77 KB
master	`AllCycleSimpleBody`	net472	436μs	119ns	460ns	36.6	2.16	236.35 KB
master	`AllCycleMoreComplexBody`	net6.0	338μs	1.76μs	8.8μs	0	0	200.56 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	495μs	987ns	3.56μs	0	0	208.18 KB
master	`AllCycleMoreComplexBody`	net472	446μs	106ns	412ns	36.6	2.16	239.87 KB
master	`ObjectExtractorSimpleBody`	net6.0	311ns	1.77ns	12.3ns	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	409ns	1.93ns	8.2ns	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	303ns	0.175ns	0.676ns	0.0442	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.52μs	29.5ns	110ns	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.76μs	36.2ns	140ns	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.66μs	0.89ns	3.33ns	0.599	0	3.8 KB
#6938	`AllCycleSimpleBody`	net6.0	332μs	1.77μs	8.86μs	0	0	197.59 KB
#6938	`AllCycleSimpleBody`	netcoreapp3.1	508μs	1.21μs	4.68μs	0	0	205.34 KB
#6938	`AllCycleSimpleBody`	net472	443μs	159ns	617ns	36.6	2.16	239.64 KB
#6938	`AllCycleMoreComplexBody`	net6.0	349μs	1.7μs	7.23μs	0	0	201.09 KB
#6938	`AllCycleMoreComplexBody`	netcoreapp3.1	508μs	1.86μs	7.21μs	0	0	208.76 KB
#6938	`AllCycleMoreComplexBody`	net472	455μs	136ns	489ns	37.9	2.23	243.15 KB
#6938	`ObjectExtractorSimpleBody`	net6.0	313ns	1.74ns	10.5ns	0	0	280 B
#6938	`ObjectExtractorSimpleBody`	netcoreapp3.1	407ns	0.55ns	2.13ns	0	0	272 B
#6938	`ObjectExtractorSimpleBody`	net472	304ns	0.0298ns	0.115ns	0.0443	0	281 B
#6938	`ObjectExtractorMoreComplexBody`	net6.0	6.39μs	1.13ns	4.38ns	0	0	3.78 KB
#6938	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.88μs	11.6ns	44.9ns	0	0	3.69 KB
#6938	`ObjectExtractorMoreComplexBody`	net472	6.95μs	18.8ns	72.9ns	0.588	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472	2.16 KB	2.17 KB	11 B	0.51%

Fewer allocations 🎉 in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0	2.16 KB	2.15 KB	-11 B	-0.51%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EncodeArgs`	net6.0	73.3μs	263ns	984ns	0	32.41 KB
master	`EncodeArgs`	netcoreapp3.1	95.7μs	36.2ns	130ns	0	32.4 KB
master	`EncodeArgs`	net472	107μs	17.6ns	65.8ns	4.82	32.51 KB
master	`EncodeLegacyArgs`	net6.0	143μs	122ns	472ns	0	2.16 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	197μs	42.5ns	147ns	0	2.14 KB
master	`EncodeLegacyArgs`	net472	261μs	66.8ns	250ns	0	2.16 KB
#6938	`EncodeArgs`	net6.0	72.8μs	339ns	1.31μs	0	32.4 KB
#6938	`EncodeArgs`	netcoreapp3.1	94.5μs	53.7ns	208ns	0	32.4 KB
#6938	`EncodeArgs`	net472	105μs	22.6ns	84.7ns	4.71	32.51 KB
#6938	`EncodeLegacyArgs`	net6.0	147μs	33.8ns	127ns	0	2.15 KB
#6938	`EncodeLegacyArgs`	netcoreapp3.1	196μs	59.5ns	222ns	0	2.15 KB
#6938	`EncodeLegacyArgs`	net472	262μs	99.1ns	384ns	0	2.17 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`RunWafRealisticBenchmark`	net6.0	271μs	133ns	499ns	4.55 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	294μs	264ns	989ns	4.48 KB
master	`RunWafRealisticBenchmark`	net472	307μs	38.1ns	147ns	4.66 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	181μs	80.1ns	300ns	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	198μs	104ns	404ns	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	207μs	45.3ns	169ns	2.28 KB
#6938	`RunWafRealisticBenchmark`	net6.0	271μs	117ns	452ns	4.55 KB
#6938	`RunWafRealisticBenchmark`	netcoreapp3.1	289μs	556ns	2.15μs	4.48 KB
#6938	`RunWafRealisticBenchmark`	net472	307μs	817ns	3.17μs	4.66 KB
#6938	`RunWafRealisticBenchmarkWithAttack`	net6.0	182μs	66.9ns	259ns	2.24 KB
#6938	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	194μs	44.1ns	165ns	2.22 KB
#6938	`RunWafRealisticBenchmarkWithAttack`	net472	206μs	60.7ns	235ns	2.28 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	61.1μs	29ns	104ns	14.53 KB
master	`SendRequest`	netcoreapp3.1	69.9μs	118ns	440ns	17.42 KB
master	`SendRequest`	net472	0.0171ns	0.00147ns	0.00551ns	0 b
#6938	`SendRequest`	net6.0	61.4μs	119ns	429ns	14.53 KB
#6938	`SendRequest`	netcoreapp3.1	70.6μs	26.9ns	104ns	17.42 KB
#6938	`SendRequest`	net472	0.00785ns	0.0021ns	0.00786ns	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #6938

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	1.146	645,405.00	739,353.49

More allocations ⚠️ in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.89 KB	42.17 KB	283 B	0.68%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	645μs	512ns	1.98μs	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	1.67μs	6.67μs	0	41.89 KB
master	`WriteAndFlushEnrichedTraces`	net472	923μs	1.93μs	7.2μs	4.46	55.75 KB
#6938	`WriteAndFlushEnrichedTraces`	net6.0	739μs	1.13μs	4.38μs	0	41.71 KB
#6938	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	680μs	1.47μs	5.31μs	0	42.17 KB
#6938	`WriteAndFlushEnrichedTraces`	net472	957μs	4.73μs	20.1μs	4.46	55.51 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.99μs	10.2ns	46.8ns	0	0	1.03 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.53μs	3.43ns	13.3ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.7μs	2.41ns	9.34ns	0.147	0.0134	995 B
#6938	`ExecuteNonQuery`	net6.0	1.96μs	8.71ns	33.7ns	0	0	1.03 KB
#6938	`ExecuteNonQuery`	netcoreapp3.1	2.45μs	2.42ns	9.36ns	0	0	1.02 KB
#6938	`ExecuteNonQuery`	net472	2.83μs	5.31ns	20.6ns	0.153	0.0139	995 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.83μs	5.85ns	22.7ns	0	1.04 KB
master	`CallElasticsearch`	netcoreapp3.1	2.3μs	11.8ns	56.6ns	0	1.04 KB
master	`CallElasticsearch`	net472	3.55μs	3.05ns	11.8ns	0.159	1.05 KB
master	`CallElasticsearchAsync`	net6.0	1.81μs	3.89ns	14.5ns	0	1.02 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.35μs	7.26ns	28.1ns	0	1.09 KB
master	`CallElasticsearchAsync`	net472	3.84μs	3.19ns	12.4ns	0.169	1.11 KB
#6938	`CallElasticsearch`	net6.0	1.79μs	7.39ns	28.6ns	0	1.04 KB
#6938	`CallElasticsearch`	netcoreapp3.1	2.34μs	11.7ns	52.1ns	0	1.04 KB
#6938	`CallElasticsearch`	net472	3.59μs	1.06ns	3.96ns	0.163	1.05 KB
#6938	`CallElasticsearchAsync`	net6.0	1.85μs	9.73ns	47.7ns	0	1.02 KB
#6938	`CallElasticsearchAsync`	netcoreapp3.1	2.59μs	12.9ns	53.2ns	0	1.09 KB
#6938	`CallElasticsearchAsync`	net472	3.79μs	3.35ns	13ns	0.17	1.11 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.78μs	9.27ns	43.5ns	0	960 B
master	`ExecuteAsync`	netcoreapp3.1	2.29μs	7.45ns	25.8ns	0	960 B
master	`ExecuteAsync`	net472	2.58μs	1.78ns	6.88ns	0.143	923 B
#6938	`ExecuteAsync`	net6.0	1.86μs	5.21ns	19.5ns	0	960 B
#6938	`ExecuteAsync`	netcoreapp3.1	2.26μs	0.484ns	1.68ns	0	960 B
#6938	`ExecuteAsync`	net472	2.5μs	1.8ns	6.96ns	0.137	923 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	7.1μs	10.4ns	39ns	0	2.37 KB
master	`SendAsync`	netcoreapp3.1	8.69μs	14.1ns	54.6ns	0	2.9 KB
master	`SendAsync`	net472	12.5μs	10.3ns	38.5ns	0.498	3.19 KB
#6938	`SendAsync`	net6.0	7.04μs	11.9ns	46.3ns	0	2.37 KB
#6938	`SendAsync`	netcoreapp3.1	8.31μs	25.5ns	98.9ns	0	2.9 KB
#6938	`SendAsync`	net472	12.3μs	8.84ns	34.2ns	0.493	3.19 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #6938

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	1.274	413,700.00	527,150.00

More allocations ⚠️ in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	57.34 KB	65.54 KB	8.19 KB	14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	274.93 KB	277.85 KB	2.92 KB	1.06%

Fewer allocations 🎉 in #6938

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	259.96 KB	248.07 KB	-11.89 KB	-4.57%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	44.6μs	212ns	1.6μs	43.83 KB
master	`StringConcatBenchmark`	netcoreapp3.1	47.2μs	224ns	838ns	42.64 KB
master	`StringConcatBenchmark`	net472	56.8μs	259ns	968ns	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	458μs	1.08μs	3.89μs	259.96 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	447μs	6.44μs	63.7μs	274.93 KB
master	`StringConcatAspectBenchmark`	net472	410μs	2.07μs	9.27μs	286.72 KB
#6938	`StringConcatBenchmark`	net6.0	47μs	241ns	1.39μs	43.78 KB
#6938	`StringConcatBenchmark`	netcoreapp3.1	47.2μs	263ns	1.81μs	42.73 KB
#6938	`StringConcatBenchmark`	net472	56.6μs	261ns	1.04μs	65.54 KB
#6938	`StringConcatAspectBenchmark`	net6.0	481μs	1.79μs	7.38μs	248.07 KB
#6938	`StringConcatAspectBenchmark`	netcoreapp3.1	528μs	1.62μs	5.83μs	277.85 KB
#6938	`StringConcatAspectBenchmark`	net472	408μs	2.2μs	11.4μs	286.72 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.63μs	2.6ns	10.1ns	0	1.76 KB
master	`EnrichedLog`	netcoreapp3.1	3.44μs	4.38ns	17ns	0	1.76 KB
master	`EnrichedLog`	net472	4.05μs	4.83ns	18.7ns	0.265	1.69 KB
#6938	`EnrichedLog`	net6.0	2.56μs	12.4ns	49.8ns	0	1.76 KB
#6938	`EnrichedLog`	netcoreapp3.1	3.54μs	10.9ns	40.8ns	0	1.76 KB
#6938	`EnrichedLog`	net472	3.8μs	3.25ns	12.6ns	0.267	1.69 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	123μs	145ns	563ns	4.37 KB
master	`EnrichedLog`	netcoreapp3.1	126μs	330ns	1.24μs	4.37 KB
master	`EnrichedLog`	net472	167μs	161ns	603ns	4.57 KB
#6938	`EnrichedLog`	net6.0	123μs	42.7ns	160ns	4.37 KB
#6938	`EnrichedLog`	netcoreapp3.1	130μs	408ns	1.58μs	4.37 KB
#6938	`EnrichedLog`	net472	168μs	200ns	722ns	4.57 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.94μs	19.3ns	74.6ns	0	2.32 KB
master	`EnrichedLog`	netcoreapp3.1	6.77μs	22.2ns	79.9ns	0	2.32 KB
master	`EnrichedLog`	net472	7.45μs	8.04ns	31.1ns	0.335	2.14 KB
#6938	`EnrichedLog`	net6.0	4.87μs	12.4ns	48.1ns	0	2.32 KB
#6938	`EnrichedLog`	netcoreapp3.1	6.52μs	24.8ns	96.1ns	0	2.32 KB
#6938	`EnrichedLog`	net472	7.5μs	6.14ns	23.8ns	0.335	2.14 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.04μs	10.5ns	49.4ns	0	1.21 KB
master	`SendReceive`	netcoreapp3.1	2.53μs	11.8ns	47.4ns	0	1.21 KB
master	`SendReceive`	net472	3.28μs	2.71ns	10.5ns	0.178	1.21 KB
#6938	`SendReceive`	net6.0	1.99μs	4.29ns	16.6ns	0	1.21 KB
#6938	`SendReceive`	netcoreapp3.1	2.56μs	11.3ns	43.6ns	0	1.21 KB
#6938	`SendReceive`	net472	3.13μs	5.95ns	23ns	0.186	1.21 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.18μs	0.92ns	3.44ns	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	5.64μs	23ns	89.3ns	0	1.69 KB
master	`EnrichedLog`	net472	6.67μs	7.28ns	27.3ns	0.298	2.08 KB
#6938	`EnrichedLog`	net6.0	4.14μs	5.32ns	19.9ns	0	1.64 KB
#6938	`EnrichedLog`	netcoreapp3.1	5.63μs	16.2ns	62.9ns	0	1.69 KB
#6938	`EnrichedLog`	net472	6.78μs	7.49ns	29ns	0.306	2.08 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	751ns	3.97ns	22.4ns	0	584 B
master	`StartFinishSpan`	netcoreapp3.1	953ns	4.42ns	17.7ns	0	584 B
master	`StartFinishSpan`	net472	914ns	0.809ns	3.13ns	0.0912	586 B
master	`StartFinishScope`	net6.0	918ns	0.479ns	1.73ns	0	704 B
master	`StartFinishScope`	netcoreapp3.1	1.15μs	6.24ns	34.2ns	0	704 B
master	`StartFinishScope`	net472	1.09μs	0.174ns	0.652ns	0.104	666 B
#6938	`StartFinishSpan`	net6.0	731ns	4.09ns	25.6ns	0	584 B
#6938	`StartFinishSpan`	netcoreapp3.1	944ns	4.34ns	17.4ns	0	584 B
#6938	`StartFinishSpan`	net472	922ns	0.173ns	0.646ns	0.0924	586 B
#6938	`StartFinishScope`	net6.0	875ns	4.5ns	21.1ns	0	704 B
#6938	`StartFinishScope`	netcoreapp3.1	1.15μs	5.85ns	27.4ns	0	704 B
#6938	`StartFinishScope`	net472	1.11μs	1.11ns	4.3ns	0.105	666 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.02μs	5.36ns	26.8ns	0	704 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.38μs	2.28ns	8.82ns	0	704 B
master	`RunOnMethodBegin`	net472	1.36μs	0.141ns	0.544ns	0.102	666 B
#6938	`RunOnMethodBegin`	net6.0	1.01μs	5.54ns	31.3ns	0	704 B
#6938	`RunOnMethodBegin`	netcoreapp3.1	1.33μs	5.84ns	21.8ns	0	704 B
#6938	`RunOnMethodBegin`	net472	1.35μs	0.668ns	2.59ns	0.101	666 B

andrewlock

LGTM in general, I think we can already record the dd-trace/dd-dotnet tool values etc though

tracer/test/Datadog.Trace.Tests/Telemetry/Collectors/ConfigurationTelemetryCollectorTests.cs

tracer/test/Datadog.Trace.Tests/Telemetry/config_norm_rules.json

tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

Co-authored-by: Andrew Lock <[email protected]>

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label May 7, 2025

chore(telemetry): track whether tracing was enabled via ssi

7ad66f6

mabdinur force-pushed the munir/track-instrumentation-source-dotnet branch from 34df49a to 7ad66f6 Compare May 7, 2025 23:50

andrewlock reviewed May 8, 2025

View reviewed changes

use unknown is as the other scenario

3ba8c4b

add simple test and clean up unknown TODO

c5d0559

mabdinur marked this pull request as ready for review May 12, 2025 23:12

mabdinur requested a review from a team as a code owner May 12, 2025 23:12

add one more test case

a0b793a

zacharycmontoya reviewed May 13, 2025

View reviewed changes

tracer/test/Datadog.Trace.Tests/Telemetry/Collectors/ConfigurationTelemetryCollectorTests.cs Outdated Show resolved Hide resolved

mabdinur force-pushed the munir/track-instrumentation-source-dotnet branch 3 times, most recently from 93f3b42 to 1ae77cf Compare June 4, 2025 14:17

fix broken test

0fbe7ed

mabdinur force-pushed the munir/track-instrumentation-source-dotnet branch 2 times, most recently from 1f4a51d to 0fbe7ed Compare June 4, 2025 15:16

mabdinur and others added 6 commits June 4, 2025 11:16

Merge branch 'master' into munir/track-instrumentation-source-dotnet

0d2dfc0

fix syntax error

a832041

remove old syntax

78bee0b

add instrumentation source to norm rules

a800435

fix test

efc26db

attempt 200

6219b37

mabdinur requested a review from zacharycmontoya June 4, 2025 23:14

zacharycmontoya approved these changes Jun 4, 2025

View reviewed changes

andrewlock reviewed Jun 5, 2025

View reviewed changes

mabdinur requested a review from andrewlock June 5, 2025 11:28

mabdinur force-pushed the munir/track-instrumentation-source-dotnet branch from 4097bd6 to 6219b37 Compare June 5, 2025 15:17

mabdinur and others added 6 commits June 5, 2025 11:27

Update tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

1ae0c71

Co-authored-by: Andrew Lock <[email protected]>

use EnvironmentRestorer

a39297f

lint

203070c

fix EnvironmentRestorer syntax error

20076ce

set annotation on class, not func

bc69a4f

not default but calculated

ad90746

mabdinur merged commit be8e30a into master Jun 6, 2025
130 of 131 checks passed

mabdinur deleted the munir/track-instrumentation-source-dotnet branch June 6, 2025 16:38

github-actions bot added this to the vNext-v3 milestone Jun 6, 2025

chore(telemetry): track whether tracing was enabled via ssi #6938

chore(telemetry): track whether tracing was enabled via ssi #6938

Uh oh!

Conversation

mabdinur commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-datadog-prod-us1 bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mabdinur May 12, 2025

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Summary

Test Optimization Report

Uh oh!

andrewlock commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

Uh oh!

pr-commenter bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #6938

Fewer allocations 🎉 in #6938

Raw results

Fewer allocations 🎉 in #6938

Raw results

More allocations ⚠️ in #6938

Raw results

More allocations ⚠️ in #6938

Fewer allocations 🎉 in #6938

Raw results

Raw results

Raw results

Slower ⚠️ in #6938

More allocations ⚠️ in #6938

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6938

More allocations ⚠️ in #6938

Fewer allocations 🎉 in #6938

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mabdinur commented May 7, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented May 7, 2025 •

edited

Loading

andrewlock May 8, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented May 12, 2025 •

edited

Loading

andrewlock commented May 12, 2025 •

edited

Loading

pr-commenter bot commented May 13, 2025 •

edited

Loading