Skip to content

[AAP] Update waf to v1.25.0 #7005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

[AAP] Update waf to v1.25.0 #7005

merged 2 commits into from
May 30, 2025

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented May 25, 2025 •
edited
Loading

Summary of changes

UPdate waf version to v1.25.0

Reason for change

Jira

Implementation details

Upgrade guide

Test coverage

Other details

@github-actions GitHub Actions
Copy link
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

3 occurrences of :

-        "_dd.appsec.waf.version": "1.24.1",
+        "_dd.appsec.waf.version": "1.25.0",

8 occurrences of :

-      _dd.appsec.waf.version: 1.24.1,
+      _dd.appsec.waf.version: 1.25.0,

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 25, 2025 •
edited
Loading

Datadog Report

Branch report: dani/asm/waf_v1_25
Commit report: 7401082
Test service: dd-trace-dotnet

✅ 0 Failed, 253624 Passed, 2294 Skipped, 18h 9m 16.87s Total Time

@andrewlock
Copy link
Member

andrewlock commented May 25, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (72ms)  : 68, 76
     .   : milestone, 72,
    master - mean (75ms)  : 69, 82
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (1,042ms)  : 1008, 1076
     .   : milestone, 1042,
    master - mean (1,058ms)  : 1016, 1100
     .   : milestone, 1058,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 105, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (719ms)  : 699, 739
     .   : milestone, 719,
    master - mean (728ms)  : 704, 752
     .   : milestone, 728,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (97ms)  : 93, 100
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (676ms)  : 651, 702
     .   : milestone, 676,
    master - mean (686ms)  : 663, 709
     .   : milestone, 686,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (1,111ms)  : 1090, 1132
     .   : milestone, 1111,
    master - mean (1,112ms)  : 1085, 1139
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (269ms)  : 264, 273
     .   : milestone, 269,
    master - mean (269ms)  : 264, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (879ms)  : 845, 913
     .   : milestone, 879,
    master - mean (882ms)  : 849, 915
     .   : milestone, 882,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7005) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (261ms)  : 258, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7005) - mean (863ms)  : 827, 900
     .   : milestone, 863,
    master - mean (869ms)  : 839, 900
     .   : milestone, 869,
Loading

@pr-commenter
Copy link

pr-commenter bot commented May 29, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7005 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.185
  • 1 benchmarks are slower, with geometric mean 1.251
  • 4 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7005

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.52 KB 5.56 KB 35 B 0.63%

Fewer allocations 🎉 in #7005

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.2 KB 6.09 KB -113 B -1.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.2μs 57.8ns 405ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 13.2μs 56.9ns 220ns 0 0 0 5.75 KB
master StartStopWithChild net472 21.6μs 120ns 899ns 0.982 0.218 0 6.2 KB
#7005 StartStopWithChild net6.0 10.4μs 57.8ns 366ns 0 0 0 5.56 KB
#7005 StartStopWithChild netcoreapp3.1 13.4μs 65.3ns 261ns 0 0 0 5.74 KB
#7005 StartStopWithChild net472 22.4μs 125ns 770ns 0.968 0.43 0.108 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 928μs 279ns 1.08μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 1.47μs 5.71μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.24ms 208ns 804ns 0 0 0 3.31 KB
#7005 WriteAndFlushEnrichedTraces net6.0 938μs 363ns 1.36μs 0 0 0 2.71 KB
#7005 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 108ns 420ns 0 0 0 2.7 KB
#7005 WriteAndFlushEnrichedTraces net472 1.23ms 241ns 934ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 328μs 1.46μs 5.66μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 497μs 1.71μs 6.17μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 444μs 107ns 400ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 717ns 2.78μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 500μs 454ns 1.7μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 449μs 144ns 559ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 320ns 0.923ns 3.45ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 400ns 2.19ns 12.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 304ns 0.17ns 0.659ns 0.0433 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.46μs 29.7ns 119ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 5.32ns 20.6ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.75μs 4.37ns 16.9ns 0.573 0 0 3.8 KB
#7005 AllCycleSimpleBody net6.0 328μs 1.58μs 6.14μs 0 0 0 197.06 KB
#7005 AllCycleSimpleBody netcoreapp3.1 501μs 405ns 1.52μs 0 0 0 204.77 KB
#7005 AllCycleSimpleBody net472 435μs 129ns 501ns 36.6 2.16 0 236.35 KB
#7005 AllCycleMoreComplexBody net6.0 333μs 1.57μs 6.29μs 0 0 0 200.56 KB
#7005 AllCycleMoreComplexBody netcoreapp3.1 491μs 1.42μs 5.5μs 0 0 0 208.18 KB
#7005 AllCycleMoreComplexBody net472 444μs 128ns 478ns 36.6 2.16 0 239.87 KB
#7005 ObjectExtractorSimpleBody net6.0 312ns 1.59ns 7.47ns 0 0 0 280 B
#7005 ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.13ns 11ns 0 0 0 272 B
#7005 ObjectExtractorSimpleBody net472 303ns 0.094ns 0.352ns 0.0441 0 0 281 B
#7005 ObjectExtractorMoreComplexBody net6.0 6.29μs 4.93ns 19.1ns 0 0 0 3.78 KB
#7005 ObjectExtractorMoreComplexBody netcoreapp3.1 7.66μs 36.3ns 145ns 0 0 0 3.69 KB
#7005 ObjectExtractorMoreComplexBody net472 6.66μs 0.511ns 1.91ns 0.601 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7005 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7005 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.5μs 256ns 992ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 70.9μs 121ns 437ns 0 0 0 17.42 KB
master SendRequest net472 0.0205ns 0.00201ns 0.00778ns 0 0 0 0 b
#7005 SendRequest net6.0 60.5μs 65.4ns 253ns 0 0 0 14.53 KB
#7005 SendRequest netcoreapp3.1 71.6μs 95.7ns 383ns 0 0 0 17.42 KB
#7005 SendRequest net472 0.0167ns 0.0014ns 0.00542ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7005

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.59 KB 42.06 KB 473 B 1.14%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 629μs 958ns 3.71μs 0 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 696μs 2.62μs 10.1μs 0 0 0 42.09 KB
master WriteAndFlushEnrichedTraces net472 1.03ms 4.3μs 16.7μs 8.33 0 0 56.22 KB
#7005 WriteAndFlushEnrichedTraces net6.0 661μs 3.7μs 24.3μs 0 0 0 42.06 KB
#7005 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 2.09μs 8.09μs 0 0 0 41.9 KB
#7005 WriteAndFlushEnrichedTraces net472 921μs 4.43μs 17.2μs 8.33 0 0 56.36 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.94μs 1.31ns 5.07ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.48μs 11ns 42.5ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 4.76ns 18.4ns 0.147 0.0134 0 995 B
#7005 ExecuteNonQuery net6.0 1.93μs 7.82ns 31.3ns 0 0 0 1.03 KB
#7005 ExecuteNonQuery netcoreapp3.1 2.39μs 5.22ns 20.2ns 0 0 0 1.02 KB
#7005 ExecuteNonQuery net472 2.71μs 9.5ns 36.8ns 0.146 0.0133 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.79μs 6.32ns 24.5ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.38μs 1.23ns 4.44ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.51μs 4.98ns 19.3ns 0.158 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.89μs 3.9ns 14.6ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.4μs 10.9ns 42.2ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.68μs 1.36ns 5.26ns 0.165 0 0 1.11 KB
#7005 CallElasticsearch net6.0 1.8μs 7.58ns 29.4ns 0 0 0 1.04 KB
#7005 CallElasticsearch netcoreapp3.1 2.34μs 11.4ns 49.7ns 0 0 0 1.04 KB
#7005 CallElasticsearch net472 3.43μs 2.39ns 8.93ns 0.155 0 0 1.05 KB
#7005 CallElasticsearchAsync net6.0 1.74μs 9ns 44.1ns 0 0 0 1.02 KB
#7005 CallElasticsearchAsync netcoreapp3.1 2.34μs 11.1ns 45.6ns 0 0 0 1.09 KB
#7005 CallElasticsearchAsync net472 3.61μs 2.16ns 8.1ns 0.163 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.72μs 9.77ns 44.8ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.34μs 8.9ns 34.5ns 0 0 0 960 B
master ExecuteAsync net472 2.59μs 5.26ns 20.4ns 0.14 0 0 923 B
#7005 ExecuteAsync net6.0 1.81μs 5.27ns 20.4ns 0 0 0 960 B
#7005 ExecuteAsync netcoreapp3.1 2.32μs 11.1ns 44.6ns 0 0 0 960 B
#7005 ExecuteAsync net472 2.6μs 3.66ns 14.2ns 0.141 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.17μs 4.54ns 17ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.51μs 18.3ns 70.8ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 8.98ns 34.8ns 0.485 0 0 3.19 KB
#7005 SendAsync net6.0 7.41μs 7.12ns 27.6ns 0 0 0 2.37 KB
#7005 SendAsync netcoreapp3.1 8.18μs 21.8ns 81.6ns 0 0 0 2.9 KB
#7005 SendAsync net472 12.1μs 13.7ns 53.2ns 0.482 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7005

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.251 431,150.00 539,300.00

Faster 🎉 in #7005

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.185 534,550.00 451,100.00

More allocations ⚠️ in #7005

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 277.3 KB 352.3 KB 75.01 KB 27.05%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 275.5 KB 276.94 KB 1.43 KB 0.52%

Fewer allocations 🎉 in #7005

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 43.37 KB 42.86 KB -512 B -1.18%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 278.02 KB 259.31 KB -18.71 KB -6.73%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 52.77 KB 43.86 KB -8.9 KB -16.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.4μs 244ns 1.48μs 0 0 0 52.77 KB
master StringConcatBenchmark netcoreapp3.1 50.1μs 280ns 1.73μs 0 0 0 43.37 KB
master StringConcatBenchmark net472 56.6μs 150ns 540ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 536μs 2.27μs 7.87μs 0 0 0 278.02 KB
master StringConcatAspectBenchmark netcoreapp3.1 435μs 1.94μs 17.4μs 0 0 0 275.5 KB
master StringConcatAspectBenchmark net472 410μs 2.17μs 11.7μs 0 0 0 277.3 KB
#7005 StringConcatBenchmark net6.0 49μs 596ns 5.87μs 0 0 0 43.86 KB
#7005 StringConcatBenchmark netcoreapp3.1 50.4μs 292ns 2.28μs 0 0 0 42.86 KB
#7005 StringConcatBenchmark net472 57.9μs 279ns 1.08μs 0 0 0 65.54 KB
#7005 StringConcatAspectBenchmark net6.0 453μs 2.27μs 10.4μs 0 0 0 259.31 KB
#7005 StringConcatAspectBenchmark netcoreapp3.1 541μs 1.38μs 4.77μs 0 0 0 276.94 KB
#7005 StringConcatAspectBenchmark net472 409μs 2.16μs 11.4μs 0 0 0 352.3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 12.1ns 48.4ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.49μs 2.41ns 9.33ns 0 0 0 1.76 KB
master EnrichedLog net472 3.83μs 4.98ns 19.3ns 0.25 0 0 1.69 KB
#7005 EnrichedLog net6.0 2.59μs 12.1ns 55.3ns 0 0 0 1.76 KB
#7005 EnrichedLog netcoreapp3.1 3.54μs 15ns 58ns 0 0 0 1.76 KB
#7005 EnrichedLog net472 3.9μs 4.31ns 16.7ns 0.253 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 26.8ns 96.6ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 39.7ns 143ns 0 0 0 4.37 KB
master EnrichedLog net472 166μs 146ns 504ns 0 0 0 4.57 KB
#7005 EnrichedLog net6.0 122μs 74.5ns 258ns 0 0 0 4.37 KB
#7005 EnrichedLog netcoreapp3.1 127μs 216ns 837ns 0 0 0 4.37 KB
#7005 EnrichedLog net472 167μs 73.5ns 275ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.05μs 5.03ns 19.5ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.62μs 10.2ns 39.3ns 0 0 0 2.32 KB
master EnrichedLog net472 7.4μs 10.1ns 39.1ns 0.334 0 0 2.14 KB
#7005 EnrichedLog net6.0 4.9μs 17ns 65.7ns 0 0 0 2.32 KB
#7005 EnrichedLog netcoreapp3.1 6.66μs 16.8ns 62.8ns 0 0 0 2.32 KB
#7005 EnrichedLog net472 7.29μs 10.1ns 39.1ns 0.329 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.09μs 4.61ns 17.9ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.51μs 11.9ns 46.2ns 0 0 0 1.21 KB
master SendReceive net472 3.16μs 1.18ns 4.4ns 0.19 0 0 1.21 KB
#7005 SendReceive net6.0 2.01μs 3.88ns 15ns 0 0 0 1.21 KB
#7005 SendReceive netcoreapp3.1 2.63μs 7.32ns 28.4ns 0 0 0 1.21 KB
#7005 SendReceive net472 3.1μs 2.01ns 7.51ns 0.184 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.08μs 7.67ns 29.7ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.59μs 9.78ns 37.9ns 0 0 0 1.69 KB
master EnrichedLog net472 6.69μs 6.3ns 24.4ns 0.302 0 0 2.08 KB
#7005 EnrichedLog net6.0 4.17μs 3.24ns 12.6ns 0 0 0 1.64 KB
#7005 EnrichedLog netcoreapp3.1 5.73μs 24.7ns 95.6ns 0 0 0 1.69 KB
#7005 EnrichedLog net472 6.44μs 7.9ns 30.6ns 0.321 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 754ns 3.91ns 20.3ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 939ns 4.77ns 21.8ns 0 0 0 584 B
master StartFinishSpan net472 915ns 0.14ns 0.522ns 0.0918 0 0 586 B
master StartFinishScope net6.0 914ns 4.38ns 17.5ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.14μs 6.06ns 30.9ns 0 0 0 705 B
master StartFinishScope net472 1.11μs 0.0887ns 0.307ns 0.101 0 0 666 B
#7005 StartFinishSpan net6.0 755ns 3.41ns 13.2ns 0 0 0 584 B
#7005 StartFinishSpan netcoreapp3.1 930ns 4.87ns 25.3ns 0 0 0 584 B
#7005 StartFinishSpan net472 914ns 0.251ns 0.972ns 0.0919 0 0 586 B
#7005 StartFinishScope net6.0 893ns 0.791ns 3.06ns 0 0 0 704 B
#7005 StartFinishScope netcoreapp3.1 1.16μs 5.78ns 25.9ns 0 0 0 704 B
#7005 StartFinishScope net472 1.14μs 0.187ns 0.701ns 0.102 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.01μs 4.78ns 20.3ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.35μs 0.842ns 3.26ns 0 0 0 704 B
master RunOnMethodBegin net472 1.35μs 0.112ns 0.435ns 0.101 0 0 666 B
#7005 RunOnMethodBegin net6.0 1.01μs 2.61ns 9.75ns 0 0 0 704 B
#7005 RunOnMethodBegin netcoreapp3.1 1.34μs 4.99ns 19.3ns 0 0 0 704 B
#7005 RunOnMethodBegin net472 1.36μs 0.604ns 2.34ns 0.101 0 0 666 B

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review May 30, 2025 10:12
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners May 30, 2025 10:12
e-n-0
e-n-0 approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@daniel-romano-DD daniel-romano-DD merged commit 9a454e3 into master May 30, 2025
128 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/waf_v1_25 branch May 30, 2025 10:37
@github-actions github-actions bot added this to the vNext-v3 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees
No one assigned
Labels
area:asm
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @andrewlock @e-n-0