Skip to content

Print the generated snapshot in case of failures #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Print the generated snapshot in case of failures #7056

merged 1 commit into from
Jun 6, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Add debug statement for analyzing flaky debugger test

Reason for change

It flaked with

Failed Datadog.Trace.Tests.Debugger.DebuggerSnapshotCreatorTests.Limits_FieldsCount [1 s]
Error Message:
Newtonsoft.Json.JsonReaderException : Unexpected end of content while loading JObject. Path 'debugger', line 812, position 3.
Stack Trace:
    at Newtonsoft.Json.Linq.JContainer.ReadTokenFrom(JsonReader reader, JsonLoadSettings options)
at Newtonsoft.Json.Linq.JObject.Load(JsonReader reader, JsonLoadSettings settings)
at Newtonsoft.Json.Linq.JObject.Parse(String json, JsonLoadSettings settings)
at Newtonsoft.Json.Linq.JObject.Parse(String json)
at Datadog.Trace.Tests.Debugger.DebuggerSnapshotCreatorTests.ValidateSingleValue(Object local) in /project/tracer/test/Datadog.Trace.Tests/Debugger/DebuggerSnapshotCreatorTests.cs:line 101
at Datadog.Trace.Tests.Debugger.DebuggerSnapshotCreatorTests.Limits_FieldsCount() in /project/tracer/test/Datadog.Trace.Tests/Debugger/DebuggerSnapshotCreatorTests.cs:line 39

which is kinda weird

Implementation details

Write the snapshot so we can see what it is if it fails again

Test coverage

N/A

Other details

@andrewlock andrewlock requested a review from a team as a code owner June 4, 2025 09:43
@andrewlock andrewlock added the area:tests unit tests, integration tests label Jun 4, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2025 •
edited
Loading

Datadog Report

All test runs f8028a0 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
❄️ 1 with New Flaky

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 2 265652 6717 40h 18m 2.65s Link
exploration_tests 0 0 0 7433 0 10m 34.81s Link

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 63, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (1,020ms)  : 1008, 1032
     .   : milestone, 1020,
    master - mean (1,023ms)  : 1008, 1038
     .   : milestone, 1023,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (103ms)  : 100, 106
     .   : milestone, 103,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (695ms)  : 683, 707
     .   : milestone, 695,
    master - mean (697ms)  : 686, 709
     .   : milestone, 697,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (665ms)  : 648, 682
     .   : milestone, 665,
    master - mean (669ms)  : 650, 689
     .   : milestone, 669,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (1,161ms)  : 1146, 1176
     .   : milestone, 1161,
    master - mean (1,165ms)  : 1147, 1182
     .   : milestone, 1165,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (269ms)  : 265, 272
     .   : milestone, 269,
    master - mean (268ms)  : 263, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (926ms)  : 912, 940
     .   : milestone, 926,
    master - mean (927ms)  : 911, 943
     .   : milestone, 927,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7056) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (261ms)  : 256, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7056) - mean (924ms)  : 910, 938
     .   : milestone, 924,
    master - mean (925ms)  : 909, 942
     .   : milestone, 925,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7056 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.197
  • 3 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7056

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.79 KB 31 B 0.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7056 StartStopWithChild net6.0 10.7μs 56.3ns 281ns 0 0 0 5.55 KB
#7056 StartStopWithChild netcoreapp3.1 14μs 54.1ns 202ns 0 0 0 5.79 KB
#7056 StartStopWithChild net472 21.8μs 126ns 991ns 0.978 0.326 0.109 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7056 WriteAndFlushEnrichedTraces net6.0 925μs 46.5ns 161ns 0 0 0 2.7 KB
#7056 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 89.9ns 324ns 0 0 0 2.7 KB
#7056 WriteAndFlushEnrichedTraces net472 1.29ms 350ns 1.36μs 0 0 0 3.33 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7056 AllCycleSimpleBody net6.0 327μs 1.25μs 4.86μs 0 0 0 197.41 KB
#7056 AllCycleSimpleBody netcoreapp3.1 523μs 2.49μs 9.63μs 0 0 0 205.17 KB
#7056 AllCycleSimpleBody net472 439μs 115ns 444ns 36.6 2.16 0 236.95 KB
#7056 AllCycleMoreComplexBody net6.0 336μs 1.71μs 8.38μs 0 0 0 200.91 KB
#7056 AllCycleMoreComplexBody netcoreapp3.1 490μs 1.39μs 5.21μs 0 0 0 208.58 KB
#7056 AllCycleMoreComplexBody net472 449μs 111ns 415ns 37.9 2.23 0 240.46 KB
#7056 ObjectExtractorSimpleBody net6.0 324ns 1.79ns 8.93ns 0 0 0 280 B
#7056 ObjectExtractorSimpleBody netcoreapp3.1 403ns 2.11ns 12.5ns 0 0 0 272 B
#7056 ObjectExtractorSimpleBody net472 303ns 0.0302ns 0.113ns 0.0443 0 0 281 B
#7056 ObjectExtractorMoreComplexBody net6.0 6.27μs 33.3ns 176ns 0 0 0 3.78 KB
#7056 ObjectExtractorMoreComplexBody netcoreapp3.1 7.71μs 28.4ns 110ns 0 0 0 3.69 KB
#7056 ObjectExtractorMoreComplexBody net472 6.85μs 3.78ns 14.6ns 0.584 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7056

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7056 EncodeArgs net6.0 73.2μs 19.3ns 74.7ns 0 0 0 32.41 KB
#7056 EncodeArgs netcoreapp3.1 93.9μs 385ns 1.49μs 0 0 0 32.4 KB
#7056 EncodeArgs net472 105μs 35.4ns 137ns 4.71 0 0 32.51 KB
#7056 EncodeLegacyArgs net6.0 145μs 46.5ns 174ns 0 0 0 2.15 KB
#7056 EncodeLegacyArgs netcoreapp3.1 196μs 310ns 1.2μs 0 0 0 2.14 KB
#7056 EncodeLegacyArgs net472 262μs 43.2ns 162ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7056 RunWafRealisticBenchmark net6.0 270μs 50.8ns 197ns 0 0 0 4.55 KB
#7056 RunWafRealisticBenchmark netcoreapp3.1 293μs 372ns 1.39μs 0 0 0 4.48 KB
#7056 RunWafRealisticBenchmark net472 306μs 45.3ns 175ns 0 0 0 4.66 KB
#7056 RunWafRealisticBenchmarkWithAttack net6.0 181μs 62.3ns 233ns 0 0 0 2.24 KB
#7056 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 197μs 57.2ns 222ns 0 0 0 2.22 KB
#7056 RunWafRealisticBenchmarkWithAttack net472 206μs 73.3ns 284ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7056 SendRequest net6.0 62.6μs 133ns 515ns 0 0 0 14.53 KB
#7056 SendRequest netcoreapp3.1 71.1μs 362ns 1.58μs 0 0 0 17.42 KB
#7056 SendRequest net472 0.00995ns 0.00293ns 0.0113ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7056

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.69 KB 934 B 1.68%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.89 KB 42.51 KB 618 B 1.48%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7056 WriteAndFlushEnrichedTraces net6.0 715μs 2.39μs 8.96μs 0 0 0 41.63 KB
#7056 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 763ns 2.64μs 0 0 0 42.51 KB
#7056 WriteAndFlushEnrichedTraces net472 925μs 2.1μs 7.87μs 8.93 0 0 56.69 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7056 ExecuteNonQuery net6.0 1.92μs 0.866ns 3.35ns 0 0 0 1.03 KB
#7056 ExecuteNonQuery netcoreapp3.1 2.53μs 11.6ns 40.1ns 0 0 0 1.02 KB
#7056 ExecuteNonQuery net472 2.7μs 3.51ns 13.1ns 0.15 0.0136 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7056 CallElasticsearch net6.0 1.75μs 7.75ns 30ns 0 0 0 1.04 KB
#7056 CallElasticsearch netcoreapp3.1 2.28μs 10.9ns 43.7ns 0 0 0 1.04 KB
#7056 CallElasticsearch net472 3.48μs 3.28ns 12.7ns 0.157 0 0 1.05 KB
#7056 CallElasticsearchAsync net6.0 1.79μs 3.15ns 12.2ns 0 0 0 1.02 KB
#7056 CallElasticsearchAsync netcoreapp3.1 2.42μs 5.93ns 23ns 0 0 0 1.09 KB
#7056 CallElasticsearchAsync net472 3.7μs 4.79ns 18.5ns 0.166 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7056 ExecuteAsync net6.0 1.84μs 2.78ns 10.8ns 0 0 0 960 B
#7056 ExecuteAsync netcoreapp3.1 2.28μs 6.95ns 26.9ns 0 0 0 960 B
#7056 ExecuteAsync net472 2.65μs 4.12ns 16ns 0.147 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7056 SendAsync net6.0 6.86μs 10.1ns 39.1ns 0 0 0 2.37 KB
#7056 SendAsync netcoreapp3.1 8.5μs 18.7ns 67.4ns 0 0 0 2.9 KB
#7056 SendAsync net472 12.6μs 7.97ns 29.8ns 0.5 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7056

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.197 458,300.00 548,400.00

More allocations ⚠️ in #7056

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 312.65 KB 37.72 KB 13.72%

Fewer allocations 🎉 in #7056

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.1 KB -728 B -1.66%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7056 StringConcatBenchmark net6.0 49.6μs 281ns 1.84μs 0 0 0 43.1 KB
#7056 StringConcatBenchmark netcoreapp3.1 48.9μs 275ns 2.15μs 0 0 0 42.64 KB
#7056 StringConcatBenchmark net472 57.1μs 275ns 1.1μs 0 0 0 57.34 KB
#7056 StringConcatAspectBenchmark net6.0 552μs 2.43μs 10.6μs 0 0 0 260.61 KB
#7056 StringConcatAspectBenchmark netcoreapp3.1 453μs 5.55μs 54.7μs 0 0 0 312.65 KB
#7056 StringConcatAspectBenchmark net472 407μs 2.25μs 17.1μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7056 EnrichedLog net6.0 2.6μs 11.9ns 50.3ns 0 0 0 1.76 KB
#7056 EnrichedLog netcoreapp3.1 3.57μs 14.4ns 55.9ns 0 0 0 1.76 KB
#7056 EnrichedLog net472 3.82μs 4ns 15.5ns 0.25 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7056 EnrichedLog net6.0 122μs 38ns 137ns 0 0 0 4.37 KB
#7056 EnrichedLog netcoreapp3.1 127μs 54.9ns 190ns 0 0 0 4.37 KB
#7056 EnrichedLog net472 166μs 88.8ns 344ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7056 EnrichedLog net6.0 5.03μs 23.4ns 87.5ns 0 0 0 2.32 KB
#7056 EnrichedLog netcoreapp3.1 6.82μs 16.7ns 62.5ns 0 0 0 2.32 KB
#7056 EnrichedLog net472 7.45μs 5.6ns 21.7ns 0.335 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7056 SendReceive net6.0 1.94μs 9.9ns 48.5ns 0 0 0 1.21 KB
#7056 SendReceive netcoreapp3.1 2.57μs 4.27ns 16ns 0 0 0 1.21 KB
#7056 SendReceive net472 3.1μs 2.02ns 7.81ns 0.185 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7056 EnrichedLog net6.0 4.23μs 4.09ns 15.8ns 0 0 0 1.64 KB
#7056 EnrichedLog netcoreapp3.1 5.86μs 21.1ns 81.7ns 0 0 0 1.69 KB
#7056 EnrichedLog net472 6.57μs 7.77ns 30.1ns 0.327 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7056 StartFinishSpan net6.0 747ns 3.8ns 16.6ns 0 0 0 584 B
#7056 StartFinishSpan netcoreapp3.1 956ns 4.35ns 16.8ns 0 0 0 584 B
#7056 StartFinishSpan net472 922ns 0.202ns 0.729ns 0.0924 0 0 586 B
#7056 StartFinishScope net6.0 908ns 0.55ns 2.13ns 0 0 0 704 B
#7056 StartFinishScope netcoreapp3.1 1.16μs 5.52ns 21.4ns 0 0 0 704 B
#7056 StartFinishScope net472 1.09μs 0.213ns 0.797ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7056 RunOnMethodBegin net6.0 992ns 5.03ns 23.6ns 0 0 0 704 B
#7056 RunOnMethodBegin netcoreapp3.1 1.36μs 6ns 23.2ns 0 0 0 704 B
#7056 RunOnMethodBegin net472 1.42μs 0.469ns 1.82ns 0.0994 0 0 666 B

@andrewlock andrewlock merged commit dd67b6f into master Jun 6, 2025
132 of 134 checks passed
@andrewlock andrewlock deleted the andrew/ci/add-debug-statement branch June 6, 2025 12:31
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenMatan GreenMatan GreenMatan approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @GreenMatan