Skip to content

Delete empty commontags interface #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Jun 10, 2025
Merged

Delete empty commontags interface #7060

merged 45 commits into from
Jun 10, 2025

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Jun 4, 2025 •
edited
Loading

Summary of changes

CommontTags and TagsList both had some stuff in them. Lucas emptied one of those two stacked classes in #5360,
we can now reduce it to only one class.

Reason for change

Implementation details

  • removed CommonTags
  • replaced the inheritance with TagsList directly everywhere it was used.

Test coverage

Other details

lucaspimentel and others added 30 commits June 2, 2025 12:32
@lucaspimentel
clean up
e41fa81
@lucaspimentel
add more validation to agent rates
a7aeb4c
@lucaspimentel
change SamplingMechanism constants to strings
cfdada7
@lucaspimentel
add samplng rate and limiter rate to SamplingDecision
b9167ef
@lucaspimentel
add fields to TraceContex and TraceChunkModel
f2c23aa
@lucaspimentel
stop adding span tags
47e6080
@lucaspimentel
inject tags during serialization
ea58864
@lucaspimentel
remove unused fields from CommonTags
9d5061b
@lucaspimentel
fix unit test
96700c3
@lucaspimentel
fix compiler error from bad merge
d7e1f7e
@lucaspimentel
clean up
b7fa460
@lucaspimentel
clean up
0d67a6a
@lucaspimentel
trying to fix test SpanSampling_ShouldSend_MultipleMatchedSpans_WhenS…
cc0876a 
…tatsDropsOne
@lucaspimentel
skip tests for now
5a6492a
@lucaspimentel
clean up in formatter
3a9fdd1
@lucaspimentel
rename properties and tweak code comments
4f1b968
@lucaspimentel
add TODO comment
1ac20ac
@lucaspimentel
code clean up, pattern matching syntax
6282266
@lucaspimentel
clean up in unit tests
4da2bbf
@lucaspimentel
rename properties
48e5700
@lucaspimentel
fix code comment
c605a1c
@lucaspimentel
fix compiler errors
7cfc97c
@vandonr @lucaspimentel
fix one test to not rely on written bytes
e4e7b66
@vandonr @lucaspimentel
unskip test (still failing)
471e81e
@vandonr @lucaspimentel
fix tests + comment
1e19c47
@lucaspimentel
fix comments
1e022de
@lucaspimentel
remove empty lines
bfc51de
@lucaspimentel
rename field
8401892
@lucaspimentel
make field readonly
796b392
@lucaspimentel
cache UTF-8 bytes for "_dd.top_level" and don't use tag processors
a11dc48
@vandonr vandonr requested review from a team as code owners June 4, 2025 14:11
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2025 •
edited
Loading

Datadog Report

All test runs 76e0082 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
❄️ 1 with New Flaky

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 7 271127 6727 44h 19m 40.02s Link
exploration_tests 0 0 0 22085 3 12m 49.26s Link

@andrewlock
Copy link
Member

andrewlock commented Jun 4, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (68ms)  : 65, 70
     .   : milestone, 68,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (1,016ms)  : 1003, 1029
     .   : milestone, 1016,
    master - mean (1,017ms)  : 1002, 1032
     .   : milestone, 1017,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (102ms)  : 99, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (699ms)  : 689, 709
     .   : milestone, 699,
    master - mean (700ms)  : 691, 709
     .   : milestone, 700,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (88ms)  : 87, 90
     .   : milestone, 88,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (674ms)  : 654, 694
     .   : milestone, 674,
    master - mean (670ms)  : 649, 692
     .   : milestone, 670,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (1,160ms)  : 1140, 1180
     .   : milestone, 1160,
    master - mean (1,165ms)  : 1143, 1187
     .   : milestone, 1165,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (935ms)  : 916, 954
     .   : milestone, 935,
    master - mean (934ms)  : 920, 947
     .   : milestone, 934,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7060) - mean (263ms)  : 259, 266
     .   : milestone, 263,
    master - mean (263ms)  : 260, 266
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (7060) - mean (933ms)  : 917, 948
     .   : milestone, 933,
    master - mean (930ms)  : 919, 941
     .   : milestone, 930,
Loading

@lucaspimentel
Copy link
Member

Getting some build errors:

tracer\test\Datadog.Trace.Tests\Tagging\TagsListTests.cs(68,45): error CS0246: The type or namespace name 'TagsList' could not be found

@vandonr
Copy link
Contributor Author

vandonr commented Jun 5, 2025

ah yes right, I haven't checked CI yet. I targeted your branch, but if you merge, it automatically converts to target master, so no rush.

andrewlock
andrewlock reviewed Jun 5, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with the theory, but TagsList is the better name IMO, can be easily updated with a simple "Rename symbol" in Rider, and will sort your build issues 😉

@vandonr
Copy link
Contributor Author

vandonr commented Jun 5, 2025

yeah, upon further review, I realized that after Lucas's PR, there are no tags left in there. I'll do the rename.

@vandonr vandonr requested review from a team as code owners June 6, 2025 09:27
@vandonr vandonr changed the title remove tagslist in favor of commontags Delete empty commontags interface Jun 6, 2025
Base automatically changed from lpimentel/sampling-rate-tags to master June 6, 2025 19:12
@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7060 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.218
  • 43 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.71 KB -43 B -0.75%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -78 B -1.40%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 5.98 KB -110 B -1.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7060 StartStopWithChild net6.0 10.5μs 58.5ns 370ns 0 0 0 5.5 KB
#7060 StartStopWithChild netcoreapp3.1 13.4μs 70.2ns 372ns 0 0 0 5.71 KB
#7060 StartStopWithChild net472 22.2μs 114ns 572ns 0.93 0.31 0 5.98 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7060 WriteAndFlushEnrichedTraces net6.0 928μs 238ns 922ns 0 0 0 2.71 KB
#7060 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 482ns 1.87μs 0 0 0 2.7 KB
#7060 WriteAndFlushEnrichedTraces net472 1.21ms 76ns 294ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.62 KB 3.27 KB 1.38%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.13 KB 3.27 KB 1.36%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7060 AllCycleSimpleBody net6.0 332μs 1.57μs 6.48μs 0 0 0 197.58 KB
#7060 AllCycleSimpleBody netcoreapp3.1 480μs 1.63μs 6.31μs 0 0 0 205.34 KB
#7060 AllCycleSimpleBody net472 457μs 183ns 686ns 37.9 2.23 0 239.62 KB
#7060 AllCycleMoreComplexBody net6.0 344μs 183ns 710ns 0 0 0 201.08 KB
#7060 AllCycleMoreComplexBody netcoreapp3.1 524μs 2.31μs 8.95μs 0 0 0 208.75 KB
#7060 AllCycleMoreComplexBody net472 451μs 76.9ns 298ns 37.9 2.23 0 243.13 KB
#7060 ObjectExtractorSimpleBody net6.0 318ns 1.44ns 5.39ns 0 0 0 280 B
#7060 ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.11ns 11.2ns 0 0 0 272 B
#7060 ObjectExtractorSimpleBody net472 303ns 0.0463ns 0.179ns 0.0444 0 0 281 B
#7060 ObjectExtractorMoreComplexBody net6.0 6.21μs 31.3ns 143ns 0 0 0 3.78 KB
#7060 ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 26.5ns 103ns 0 0 0 3.69 KB
#7060 ObjectExtractorMoreComplexBody net472 6.92μs 3.03ns 11.4ns 0.588 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7060 EncodeArgs net6.0 73.5μs 146ns 546ns 0 0 0 32.4 KB
#7060 EncodeArgs netcoreapp3.1 94.6μs 259ns 1μs 0 0 0 32.4 KB
#7060 EncodeArgs net472 105μs 19.2ns 69.2ns 4.71 0 0 32.51 KB
#7060 EncodeLegacyArgs net6.0 143μs 27.1ns 105ns 0 0 0 2.15 KB
#7060 EncodeLegacyArgs netcoreapp3.1 198μs 57.2ns 206ns 0 0 0 2.14 KB
#7060 EncodeLegacyArgs net472 261μs 27.6ns 107ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7060 RunWafRealisticBenchmark net6.0 275μs 76.8ns 287ns 0 0 0 4.55 KB
#7060 RunWafRealisticBenchmark netcoreapp3.1 291μs 135ns 522ns 0 0 0 4.48 KB
#7060 RunWafRealisticBenchmark net472 307μs 45.5ns 176ns 0 0 0 4.66 KB
#7060 RunWafRealisticBenchmarkWithAttack net6.0 185μs 84.5ns 316ns 0 0 0 2.24 KB
#7060 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 195μs 215ns 803ns 0 0 0 2.22 KB
#7060 RunWafRealisticBenchmarkWithAttack net472 207μs 26.5ns 99.1ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7060 SendRequest net6.0 60.1μs 45.1ns 175ns 0 0 0 14.52 KB
#7060 SendRequest netcoreapp3.1 72.4μs 187ns 726ns 0 0 0 17.42 KB
#7060 SendRequest net472 0.0157ns 0.0019ns 0.00737ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.39 KB 637 B 1.14%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.73 KB 42.17 KB 445 B 1.07%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7060 WriteAndFlushEnrichedTraces net6.0 702μs 3.61μs 16.2μs 0 0 0 42.17 KB
#7060 WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 3.65μs 21.3μs 0 0 0 42.01 KB
#7060 WriteAndFlushEnrichedTraces net472 860μs 2.36μs 8.51μs 8.33 0 0 56.39 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7060 ExecuteNonQuery net6.0 1.95μs 8.12ns 31.4ns 0 0 0 1.02 KB
#7060 ExecuteNonQuery netcoreapp3.1 2.59μs 7.92ns 30.7ns 0 0 0 1.02 KB
#7060 ExecuteNonQuery net472 2.77μs 2.73ns 10.2ns 0.152 0.0139 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7060 CallElasticsearch net6.0 1.81μs 1.29ns 4.66ns 0 0 0 1.03 KB
#7060 CallElasticsearch netcoreapp3.1 2.38μs 9.58ns 37.1ns 0 0 0 1.03 KB
#7060 CallElasticsearch net472 3.67μs 1.81ns 7.01ns 0.163 0 0 1.04 KB
#7060 CallElasticsearchAsync net6.0 1.83μs 7.87ns 30.5ns 0 0 0 1.01 KB
#7060 CallElasticsearchAsync netcoreapp3.1 2.46μs 10.6ns 40.9ns 0 0 0 1.08 KB
#7060 CallElasticsearchAsync net472 3.79μs 3.95ns 15.3ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7060 ExecuteAsync net6.0 1.89μs 1.99ns 7.69ns 0 0 0 952 B
#7060 ExecuteAsync netcoreapp3.1 2.35μs 2.92ns 10.9ns 0 0 0 952 B
#7060 ExecuteAsync net472 2.51μs 2.07ns 8ns 0.138 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7060 SendAsync net6.0 7.13μs 5.29ns 20.5ns 0 0 0 2.36 KB
#7060 SendAsync netcoreapp3.1 8.63μs 12.1ns 47ns 0 0 0 2.9 KB
#7060 SendAsync net472 12.3μs 12.7ns 49.2ns 0.491 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7060

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.218 413,700.00 503,900.00

More allocations ⚠️ in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 274.35 KB 14.39 KB 5.54%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 43.09 KB 448 B 1.05%

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.1 KB -728 B -1.66%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 258.18 KB -16.74 KB -6.09%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7060 StringConcatBenchmark net6.0 49.6μs 290ns 2.23μs 0 0 0 43.1 KB
#7060 StringConcatBenchmark netcoreapp3.1 58.7μs 948ns 9.44μs 0 0 0 43.09 KB
#7060 StringConcatBenchmark net472 57.1μs 260ns 972ns 0 0 0 57.34 KB
#7060 StringConcatAspectBenchmark net6.0 494μs 1.33μs 4.59μs 0 0 0 274.35 KB
#7060 StringConcatAspectBenchmark netcoreapp3.1 508μs 2.64μs 12.7μs 0 0 0 258.18 KB
#7060 StringConcatAspectBenchmark net472 403μs 1.54μs 5.98μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7060 EnrichedLog net6.0 2.59μs 12.1ns 48.2ns 0 0 0 1.7 KB
#7060 EnrichedLog netcoreapp3.1 3.47μs 16.1ns 66.3ns 0 0 0 1.7 KB
#7060 EnrichedLog net472 3.98μs 4.41ns 17.1ns 0.257 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7060 EnrichedLog net6.0 122μs 144ns 559ns 0 0 0 4.31 KB
#7060 EnrichedLog netcoreapp3.1 128μs 261ns 978ns 0 0 0 4.31 KB
#7060 EnrichedLog net472 167μs 41.1ns 148ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7060 EnrichedLog net6.0 5.03μs 16.2ns 60.8ns 0 0 0 2.26 KB
#7060 EnrichedLog netcoreapp3.1 6.71μs 16.8ns 65.2ns 0 0 0 2.26 KB
#7060 EnrichedLog net472 7.48μs 5.27ns 20.4ns 0.303 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7060 SendReceive net6.0 1.95μs 10.2ns 49.8ns 0 0 0 1.2 KB
#7060 SendReceive netcoreapp3.1 2.62μs 8.32ns 32.2ns 0 0 0 1.2 KB
#7060 SendReceive net472 3.26μs 5.69ns 21.3ns 0.179 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7060 EnrichedLog net6.0 4.08μs 13.1ns 47.4ns 0 0 0 1.58 KB
#7060 EnrichedLog netcoreapp3.1 5.7μs 17.2ns 66.8ns 0 0 0 1.63 KB
#7060 EnrichedLog net472 6.74μs 7.1ns 26.6ns 0.306 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7060 StartFinishSpan net6.0 754ns 3.61ns 14.9ns 0 0 0 576 B
#7060 StartFinishSpan netcoreapp3.1 956ns 4.89ns 22.9ns 0 0 0 576 B
#7060 StartFinishSpan net472 905ns 0.607ns 2.27ns 0.0909 0 0 578 B
#7060 StartFinishScope net6.0 883ns 4.85ns 28.7ns 0 0 0 696 B
#7060 StartFinishScope netcoreapp3.1 1.19μs 1.52ns 5.91ns 0 0 0 696 B
#7060 StartFinishScope net472 1.1μs 0.295ns 1.02ns 0.0994 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7060

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7060 RunOnMethodBegin net6.0 1.04μs 1.3ns 5.02ns 0 0 0 696 B
#7060 RunOnMethodBegin netcoreapp3.1 1.41μs 1.1ns 4.25ns 0 0 0 696 B
#7060 RunOnMethodBegin net472 1.39μs 3.46ns 13.4ns 0.099 0 0 658 B

andrewlock
andrewlock approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

e-n-0
e-n-0 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for the ASM part 😄

@vandonr vandonr merged commit 31cd314 into master Jun 10, 2025
135 of 136 checks passed
@vandonr vandonr deleted the vandonr/explo branch June 10, 2025 14:18
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@dudikeleti dudikeleti dudikeleti approved these changes

@e-n-0 e-n-0 e-n-0 approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
type:refactor
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vandonr @andrewlock @lucaspimentel @dudikeleti @e-n-0 @bouwkast