Skip to content

test(trace-exporter): enable UDS transport test for .NET Core 3.1 or greater #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 5, 2025

Summary of changes

Run UDS tests for .NET Core 3.1 or greater

Reason for change

Because the test agent only supports UDS for .NET Core 3.1 or greater

#if NETCOREAPP3_1_OR_GREATER
public static UdsAgent Create(ITestOutputHelper output, UnixDomainSocketConfig config, AgentConfiguration agentConfiguration = null) => new UdsAgent(config) { Output = output, Configuration = agentConfiguration ?? new() };
#endif

Implementation details

Wrapped UDS test under #if NETCOREAPP3_1_OR_GREATER preprocessor.

Test coverage

Other details

@ganeshnj ganeshnj requested a review from a team as a code owner June 5, 2025 19:30
@github-actions github-actions bot added the area:tests unit tests, integration tests label Jun 5, 2025
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (74ms)  : 67, 81
     .   : milestone, 74,
    master - mean (74ms)  : 69, 79
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (1,059ms)  : 1035, 1083
     .   : milestone, 1059,
    master - mean (1,069ms)  : 1049, 1089
     .   : milestone, 1069,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (737ms)  : 719, 755
     .   : milestone, 737,
    master - mean (744ms)  : 723, 765
     .   : milestone, 744,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (96ms)  : 94, 99
     .   : milestone, 96,
    master - mean (97ms)  : 93, 101
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (703ms)  : 676, 731
     .   : milestone, 703,
    master - mean (712ms)  : 685, 739
     .   : milestone, 712,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (189ms)  : 184, 195
     .   : milestone, 189,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (1,169ms)  : 1153, 1184
     .   : milestone, 1169,
    master - mean (1,166ms)  : 1149, 1182
     .   : milestone, 1166,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (268ms)  : 265, 272
     .   : milestone, 268,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (932ms)  : 918, 947
     .   : milestone, 932,
    master - mean (932ms)  : 920, 943
     .   : milestone, 932,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7073) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (262ms)  : 258, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7073) - mean (929ms)  : 916, 942
     .   : milestone, 929,
    master - mean (928ms)  : 911, 944
     .   : milestone, 928,

Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 5, 2025

Datadog Report

All test runs 6f49ec9 🔗

2 Total Test Services: 0 Failed, 2 Passed
❄️ 1 with New Flaky

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 1 246811 2492 15h 59m 2.23s Link
exploration_tests 0 0 0 22085 3 2m 11.61s Link

@ganeshnj ganeshnj merged commit d0cd313 into master Jun 6, 2025
130 of 132 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/fix/exporter-uds-netcore-3-1-greater branch June 6, 2025 07:19
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 6, 2025
@ganeshnj ganeshnj self-assigned this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants