Skip to content

[AAP] Reduce waf config diagnostics log levels #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2025
Merged

[AAP] Reduce waf config diagnostics log levels #7094

merged 4 commits into from
Jun 18, 2025

Conversation

daniel-romano-DD
Copy link
Contributor

Summary of changes

Waf config diagnostics log levels were being logged as Warnings, but should be Debug level

Reason for change

Specified in this RFC

Note that aside from through telemetry logs, none of the diagnostics presented here should be logged to a regular logger using a level above debug, as it will inevitably result in customer complaints.

Implementation details

Test coverage

Other details

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 11, 2025 •
edited
Loading

Datadog Report

Branch report: dani/asm/reduce_waf_config_log_levels
Commit report: d992c69
Test service: dd-trace-dotnet

✅ 0 Failed, 250335 Passed, 2470 Skipped, 18h 4m 28.7s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7094 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.161
  • 43 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.71 KB -44 B -0.76%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.49 KB -89 B -1.60%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 5.99 KB -100 B -1.64%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7094 StartStopWithChild net6.0 10.7μs 54.5ns 238ns 0 0 0 5.49 KB
#7094 StartStopWithChild netcoreapp3.1 13.5μs 70.6ns 338ns 0 0 0 5.71 KB
#7094 StartStopWithChild net472 21.9μs 122ns 781ns 0.97 0.323 0.108 5.99 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7094 WriteAndFlushEnrichedTraces net6.0 934μs 67.9ns 245ns 0 0 0 2.71 KB
#7094 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 305ns 1.18μs 0 0 0 2.7 KB
#7094 WriteAndFlushEnrichedTraces net472 1.23ms 978ns 3.79μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 242.2 KB 5.84 KB 2.47%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 245.71 KB 5.84 KB 2.44%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7094 AllCycleSimpleBody net6.0 331μs 1.45μs 5.62μs 0 0 0 197.58 KB
#7094 AllCycleSimpleBody netcoreapp3.1 497μs 1.3μs 5.05μs 0 0 0 205.34 KB
#7094 AllCycleSimpleBody net472 444μs 118ns 442ns 37.9 2.23 0 242.2 KB
#7094 AllCycleMoreComplexBody net6.0 340μs 737ns 2.85μs 0 0 0 201.08 KB
#7094 AllCycleMoreComplexBody netcoreapp3.1 501μs 2.27μs 8.8μs 0 0 0 208.75 KB
#7094 AllCycleMoreComplexBody net472 453μs 148ns 554ns 37.9 2.23 0 245.71 KB
#7094 ObjectExtractorSimpleBody net6.0 314ns 0.182ns 0.68ns 0 0 0 280 B
#7094 ObjectExtractorSimpleBody netcoreapp3.1 403ns 0.141ns 0.548ns 0 0 0 272 B
#7094 ObjectExtractorSimpleBody net472 303ns 0.0321ns 0.12ns 0.0442 0 0 281 B
#7094 ObjectExtractorMoreComplexBody net6.0 6.41μs 1.88ns 6.77ns 0 0 0 3.78 KB
#7094 ObjectExtractorMoreComplexBody netcoreapp3.1 7.68μs 26.5ns 103ns 0 0 0 3.69 KB
#7094 ObjectExtractorMoreComplexBody net472 6.78μs 0.718ns 2.78ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7094 EncodeArgs net6.0 74.2μs 356ns 1.23μs 0 0 0 32.4 KB
#7094 EncodeArgs netcoreapp3.1 95.4μs 12.2ns 47.3ns 0 0 0 32.4 KB
#7094 EncodeArgs net472 107μs 8.44ns 30.4ns 4.83 0 0 32.51 KB
#7094 EncodeLegacyArgs net6.0 147μs 77.7ns 301ns 0 0 0 2.15 KB
#7094 EncodeLegacyArgs netcoreapp3.1 194μs 145ns 561ns 0 0 0 2.14 KB
#7094 EncodeLegacyArgs net472 260μs 34.9ns 135ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7094 RunWafRealisticBenchmark net6.0 273μs 79.9ns 299ns 0 0 0 4.55 KB
#7094 RunWafRealisticBenchmark netcoreapp3.1 296μs 97ns 363ns 0 0 0 4.48 KB
#7094 RunWafRealisticBenchmark net472 306μs 47.3ns 183ns 0 0 0 4.66 KB
#7094 RunWafRealisticBenchmarkWithAttack net6.0 182μs 66.7ns 258ns 0 0 0 2.24 KB
#7094 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 195μs 39.1ns 151ns 0 0 0 2.22 KB
#7094 RunWafRealisticBenchmarkWithAttack net472 206μs 38.5ns 149ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7094 SendRequest net6.0 61.4μs 32.4ns 121ns 0 0 0 14.52 KB
#7094 SendRequest netcoreapp3.1 70.5μs 75.2ns 281ns 0 0 0 17.42 KB
#7094 SendRequest net472 0.0203ns 0.00174ns 0.00674ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7094

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.140 631,437.50 719,899.55

More allocations ⚠️ in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.36 KB 604 B 1.08%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7094 WriteAndFlushEnrichedTraces net6.0 656μs 1.19μs 4.11μs 0 0 0 41.74 KB
#7094 WriteAndFlushEnrichedTraces netcoreapp3.1 716μs 2.45μs 8.49μs 0 0 0 41.91 KB
#7094 WriteAndFlushEnrichedTraces net472 911μs 3.89μs 15.1μs 8.93 0 0 56.36 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7094 ExecuteNonQuery net6.0 1.96μs 8.09ns 31.3ns 0 0 0 1.02 KB
#7094 ExecuteNonQuery netcoreapp3.1 2.67μs 7.46ns 28.9ns 0 0 0 1.02 KB
#7094 ExecuteNonQuery net472 2.82μs 3.76ns 14.6ns 0.156 0.0141 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7094 CallElasticsearch net6.0 1.81μs 7.7ns 29.8ns 0 0 0 1.03 KB
#7094 CallElasticsearch netcoreapp3.1 2.32μs 1.78ns 6.43ns 0 0 0 1.03 KB
#7094 CallElasticsearch net472 3.66μs 3.07ns 11.5ns 0.165 0 0 1.04 KB
#7094 CallElasticsearchAsync net6.0 1.82μs 8.29ns 33.2ns 0 0 0 1.01 KB
#7094 CallElasticsearchAsync netcoreapp3.1 2.38μs 10.2ns 39.5ns 0 0 0 1.08 KB
#7094 CallElasticsearchAsync net472 3.87μs 1.87ns 7.25ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7094 ExecuteAsync net6.0 1.87μs 9.39ns 42ns 0 0 0 952 B
#7094 ExecuteAsync netcoreapp3.1 2.3μs 4.11ns 14.8ns 0 0 0 952 B
#7094 ExecuteAsync net472 2.57μs 2.04ns 7.9ns 0.141 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7094 SendAsync net6.0 7.07μs 17.6ns 68.1ns 0 0 0 2.36 KB
#7094 SendAsync netcoreapp3.1 8.61μs 29.3ns 113ns 0 0 0 2.9 KB
#7094 SendAsync net472 12.2μs 7.71ns 29.9ns 0.486 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7094

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.201 413,700.00 496,800.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.142 458,300.00 523,600.00

More allocations ⚠️ in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 277.7 KB 17.74 KB 6.83%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 43.83 KB 1.19 KB 2.80%

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 255.89 KB -19.04 KB -6.93%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7094 StringConcatBenchmark net6.0 44.8μs 243ns 1.82μs 0 0 0 43.78 KB
#7094 StringConcatBenchmark netcoreapp3.1 55μs 676ns 6.65μs 0 0 0 43.83 KB
#7094 StringConcatBenchmark net472 57.9μs 225ns 843ns 0 0 0 57.34 KB
#7094 StringConcatAspectBenchmark net6.0 524μs 1.64μs 5.92μs 0 0 0 277.7 KB
#7094 StringConcatAspectBenchmark netcoreapp3.1 498μs 1.81μs 7.02μs 0 0 0 255.89 KB
#7094 StringConcatAspectBenchmark net472 403μs 2.12μs 10.6μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7094 EnrichedLog net6.0 2.6μs 12.3ns 47.8ns 0 0 0 1.7 KB
#7094 EnrichedLog netcoreapp3.1 3.39μs 16.9ns 73.8ns 0 0 0 1.7 KB
#7094 EnrichedLog net472 3.89μs 6.1ns 23.6ns 0.254 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7094 EnrichedLog net6.0 122μs 224ns 838ns 0 0 0 4.31 KB
#7094 EnrichedLog netcoreapp3.1 127μs 214ns 829ns 0 0 0 4.31 KB
#7094 EnrichedLog net472 165μs 33.8ns 126ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7094 EnrichedLog net6.0 5.09μs 19.8ns 76.6ns 0 0 0 2.26 KB
#7094 EnrichedLog netcoreapp3.1 7.11μs 21.1ns 81.6ns 0 0 0 2.26 KB
#7094 EnrichedLog net472 7.72μs 8.41ns 32.6ns 0.309 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7094 SendReceive net6.0 2.04μs 10.1ns 44.2ns 0 0 0 1.2 KB
#7094 SendReceive netcoreapp3.1 2.62μs 12.6ns 50.5ns 0 0 0 1.2 KB
#7094 SendReceive net472 3.18μs 4.02ns 15.6ns 0.19 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7094 EnrichedLog net6.0 4.21μs 7.66ns 29.7ns 0 0 0 1.58 KB
#7094 EnrichedLog netcoreapp3.1 5.64μs 8.01ns 31ns 0 0 0 1.63 KB
#7094 EnrichedLog net472 6.64μs 7.18ns 27.8ns 0.299 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7094 StartFinishSpan net6.0 768ns 3.65ns 15.5ns 0 0 0 576 B
#7094 StartFinishSpan netcoreapp3.1 941ns 4.67ns 20.9ns 0 0 0 576 B
#7094 StartFinishSpan net472 906ns 0.413ns 1.6ns 0.0907 0 0 578 B
#7094 StartFinishScope net6.0 919ns 0.542ns 2.1ns 0 0 0 696 B
#7094 StartFinishScope netcoreapp3.1 1.19μs 5.65ns 21.9ns 0 0 0 696 B
#7094 StartFinishScope net472 1.11μs 0.302ns 1.17ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7094

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7094 RunOnMethodBegin net6.0 1.03μs 5.68ns 33.1ns 0 0 0 696 B
#7094 RunOnMethodBegin netcoreapp3.1 1.36μs 7.13ns 34.9ns 0 0 0 696 B
#7094 RunOnMethodBegin net472 1.36μs 0.178ns 0.641ns 0.102 0 0 658 B

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review June 12, 2025 07:51
@daniel-romano-DD daniel-romano-DD requested a review from a team as a code owner June 12, 2025 07:51
andrewlock
andrewlock approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daniel-romano-DD daniel-romano-DD changed the title [AAP] Reduce waf config diganostics log levels [AAP] Reduce waf config diagnostics log levels Jun 12, 2025
@daniel-romano-DD daniel-romano-DD merged commit f2acaed into master Jun 18, 2025
128 of 129 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/reduce_waf_config_log_levels branch June 18, 2025 09:30
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext-v3
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @e-n-0 @andrewlock