Fix AWS S3 DeleteBucket integration #7118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:tracer
andrewlock
commented
Jun 17, 2025
| @@ -17,6 +17,6 @@ internal interface IDeleteBucketRequest : IDuckType | |||
| /// <summary> | |||
| /// Gets the S3 bucket name. | |||
| /// </summary> | |||
| [DuckField(Name = "bucketName")] | |||
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes the broken integration
Reason for change
4.0.1.7 broke our integration, this fixes it
Implementation details
The backing field name changed, which broke the integration. Use the public property instead of the field, given it's basically just an auto-property anyway
Test coverage
Did a full test (all specific versions here) and all expected tests passed