[Test] Throughput testing with DSM - adding artificial sleep #7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

robcarlan-datadog wants to merge 11 commits into master from rob.carlan/dsm-throughput-testing-ci-slow-tracer

Contributor

robcarlan-datadog commented Jun 18, 2025

Summary of changes

Test related to #7103

Adding artificial sleep to show meaningful throughput results

Reason for change

Implementation details

Test coverage

Other details

robcarlan-datadog added 10 commits

June 13, 2025 17:31


          throughput testing CI

ae2a1eb


          run bp-runner for macrobenchmarks

c68522a


          use different image

1dbb8ad


          use different image

00a3e16


          set image explicitly

920ceef


          Merge branch 'master' into rob.carlan/dsm-throughput-testing-ci

e881166


          run setup SUT before running benchmarks

63834ca


          depend on artefact

c02ecc5


          sleep on produce & sleep on DSM

cd6b7a2


          fix ci branch name

7dc41cf

datadog-datadog-prod-us1 bot commented Jun 18, 2025 •

edited

Loading

Datadog Report

All test runs 0b4cd80 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`dd-trace-dotnet`	32	0	0	424128	4448	27h 33m 59.59s	Link
`exploration_tests`	0	0	0	22085	3	2m 16.32s	Link

❌ Failed Tests (32)

This report shows up to 5 failed tests.

AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

Expand for error

 Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_KAFKA_INTEGRATION_SLEEP_MS"}.

AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

Expand for error

 Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_KAFKA_INTEGRATION_SLEEP_MS"}.

AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

Expand for error

 Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_KAFKA_INTEGRATION_SLEEP_MS"}.

AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

Expand for error

 Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_KAFKA_INTEGRATION_SLEEP_MS"}.

AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

Expand for error

 Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_KAFKA_INTEGRATION_SLEEP_MS"}.


          confiure sleep

0b4cd80

pr-commenter bot commented Jun 18, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7120 compared to master:

2 benchmarks are slower, with geometric mean 1.244
41 benchmarks have fewer allocations
7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.75 KB	5.71 KB	-46 B	-0.80%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.09 KB	6.03 KB	-58 B	-0.95%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0	5.58 KB	5.48 KB	-98 B	-1.76%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	11.2μs	59.7ns	322ns	0	0	0	5.58 KB
master	`StartStopWithChild`	netcoreapp3.1	14.1μs	67.5ns	286ns	0	0	0	5.75 KB
master	`StartStopWithChild`	net472	22.1μs	119ns	651ns	1.03	0.411	0.103	6.09 KB
#7120	`StartStopWithChild`	net6.0	10.7μs	55.2ns	276ns	0	0	0	5.48 KB
#7120	`StartStopWithChild`	netcoreapp3.1	14.1μs	69.9ns	305ns	0	0	0	5.71 KB
#7120	`StartStopWithChild`	net472	21.6μs	122ns	862ns	0.975	0.325	0.108	6.03 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.33 KB	3.31 KB	-23 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	927μs	26.6ns	103ns	0	0	0	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.04ms	404ns	1.56μs	0	0	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.25ms	357ns	1.38μs	0	0	0	3.33 KB
#7120	`WriteAndFlushEnrichedTraces`	net6.0	913μs	93ns	360ns	0	0	0	2.7 KB
#7120	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.01ms	64.8ns	242ns	0	0	0	2.7 KB
#7120	`WriteAndFlushEnrichedTraces`	net472	1.2ms	99.8ns	387ns	0	0	0	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472	236.35 KB	239.64 KB	3.28 KB	1.39%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472	239.87 KB	243.15 KB	3.28 KB	1.37%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`AllCycleSimpleBody`	net6.0	331μs	1.76μs	8.42μs	0	0	0	197.06 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	510μs	1.45μs	5.61μs	0	0	0	204.77 KB
master	`AllCycleSimpleBody`	net472	436μs	119ns	460ns	36.6	2.16	0	236.35 KB
master	`AllCycleMoreComplexBody`	net6.0	338μs	1.76μs	8.8μs	0	0	0	200.56 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	495μs	987ns	3.56μs	0	0	0	208.18 KB
master	`AllCycleMoreComplexBody`	net472	446μs	106ns	412ns	36.6	2.16	0	239.87 KB
master	`ObjectExtractorSimpleBody`	net6.0	311ns	1.77ns	12.3ns	0	0	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	409ns	1.93ns	8.2ns	0	0	0	272 B
master	`ObjectExtractorSimpleBody`	net472	303ns	0.175ns	0.676ns	0.0442	0	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.52μs	29.5ns	110ns	0	0	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.76μs	36.2ns	140ns	0	0	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.66μs	0.89ns	3.33ns	0.599	0	0	3.8 KB
#7120	`AllCycleSimpleBody`	net6.0	329μs	1.19μs	4.61μs	0	0	0	197.6 KB
#7120	`AllCycleSimpleBody`	netcoreapp3.1	480μs	2.25μs	8.42μs	0	0	0	205.35 KB
#7120	`AllCycleSimpleBody`	net472	444μs	145ns	544ns	36.6	2.16	0	239.64 KB
#7120	`AllCycleMoreComplexBody`	net6.0	347μs	800ns	3.1μs	0	0	0	201.1 KB
#7120	`AllCycleMoreComplexBody`	netcoreapp3.1	486μs	1.61μs	6.22μs	0	0	0	208.77 KB
#7120	`AllCycleMoreComplexBody`	net472	453μs	320ns	1.2μs	37.9	2.23	0	243.15 KB
#7120	`ObjectExtractorSimpleBody`	net6.0	313ns	1.75ns	10.3ns	0	0	0	280 B
#7120	`ObjectExtractorSimpleBody`	netcoreapp3.1	399ns	1.93ns	7.96ns	0	0	0	272 B
#7120	`ObjectExtractorSimpleBody`	net472	305ns	0.0338ns	0.131ns	0.0444	0	0	281 B
#7120	`ObjectExtractorMoreComplexBody`	net6.0	6.31μs	24.3ns	94.1ns	0	0	0	3.78 KB
#7120	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.74μs	26ns	101ns	0	0	0	3.69 KB
#7120	`ObjectExtractorMoreComplexBody`	net472	6.84μs	1.95ns	7.55ns	0.584	0	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0	2.16 KB	2.15 KB	-11 B	-0.51%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EncodeArgs`	net6.0	73.3μs	263ns	984ns	0	0	0	32.41 KB
master	`EncodeArgs`	netcoreapp3.1	95.7μs	36.2ns	130ns	0	0	0	32.4 KB
master	`EncodeArgs`	net472	107μs	17.6ns	65.8ns	4.82	0	0	32.51 KB
master	`EncodeLegacyArgs`	net6.0	143μs	122ns	472ns	0	0	0	2.16 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	197μs	42.5ns	147ns	0	0	0	2.14 KB
master	`EncodeLegacyArgs`	net472	261μs	66.8ns	250ns	0	0	0	2.16 KB
#7120	`EncodeArgs`	net6.0	73.2μs	32.5ns	122ns	0	0	0	32.4 KB
#7120	`EncodeArgs`	netcoreapp3.1	95.6μs	188ns	728ns	0	0	0	32.4 KB
#7120	`EncodeArgs`	net472	105μs	26.6ns	99.5ns	4.72	0	0	32.51 KB
#7120	`EncodeLegacyArgs`	net6.0	143μs	13.8ns	53.5ns	0	0	0	2.15 KB
#7120	`EncodeLegacyArgs`	netcoreapp3.1	197μs	232ns	900ns	0	0	0	2.14 KB
#7120	`EncodeLegacyArgs`	net472	260μs	24.8ns	96.1ns	0	0	0	2.16 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`RunWafRealisticBenchmark`	net6.0	271μs	133ns	499ns	0	0	0	4.55 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	294μs	264ns	989ns	0	0	0	4.48 KB
master	`RunWafRealisticBenchmark`	net472	307μs	38.1ns	147ns	0	0	0	4.66 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	181μs	80.1ns	300ns	0	0	0	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	198μs	104ns	404ns	0	0	0	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	207μs	45.3ns	169ns	0	0	0	2.28 KB
#7120	`RunWafRealisticBenchmark`	net6.0	272μs	79.7ns	298ns	0	0	0	4.55 KB
#7120	`RunWafRealisticBenchmark`	netcoreapp3.1	293μs	94.6ns	341ns	0	0	0	4.48 KB
#7120	`RunWafRealisticBenchmark`	net472	311μs	36.5ns	141ns	0	0	0	4.66 KB
#7120	`RunWafRealisticBenchmarkWithAttack`	net6.0	182μs	25.9ns	96.9ns	0	0	0	2.24 KB
#7120	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	195μs	61.6ns	230ns	0	0	0	2.22 KB
#7120	`RunWafRealisticBenchmarkWithAttack`	net472	207μs	39ns	151ns	0	0	0	2.28 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendRequest`	net6.0	61.1μs	29ns	104ns	0	0	0	14.53 KB
master	`SendRequest`	netcoreapp3.1	69.9μs	118ns	440ns	0	0	0	17.42 KB
master	`SendRequest`	net472	0.0171ns	0.00147ns	0.00551ns	0	0	0	0 b
#7120	`SendRequest`	net6.0	61.1μs	269ns	1.04μs	0	0	0	14.52 KB
#7120	`SendRequest`	netcoreapp3.1	70.3μs	69ns	239ns	0	0	0	17.42 KB
#7120	`SendRequest`	net472	0.0122ns	0.00291ns	0.0113ns	0	0	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	55.75 KB	56.29 KB	533 B	0.96%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.89 KB	42.14 KB	250 B	0.60%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	645μs	512ns	1.98μs	0	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	1.67μs	6.67μs	0	0	0	41.89 KB
master	`WriteAndFlushEnrichedTraces`	net472	923μs	1.93μs	7.2μs	4.46	0	0	55.75 KB
#7120	`WriteAndFlushEnrichedTraces`	net6.0	711μs	388ns	1.5μs	0	0	0	41.64 KB
#7120	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	2.55μs	16.5μs	0	0	0	42.14 KB
#7120	`WriteAndFlushEnrichedTraces`	net472	872μs	3.74μs	14.5μs	8.33	0	0	56.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.03 KB	1.02 KB	-8 B	-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1	1.02 KB	1.02 KB	-8 B	-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472	995 B	987 B	-8 B	-0.80%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`ExecuteNonQuery`	net6.0	1.99μs	10.2ns	46.8ns	0	0	0	1.03 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.53μs	3.43ns	13.3ns	0	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.7μs	2.41ns	9.34ns	0.147	0.0134	0	995 B
#7120	`ExecuteNonQuery`	net6.0	1.89μs	3.57ns	13.8ns	0	0	0	1.02 KB
#7120	`ExecuteNonQuery`	netcoreapp3.1	2.58μs	10.2ns	39.7ns	0	0	0	1.02 KB
#7120	`ExecuteNonQuery`	net472	2.7μs	3.81ns	14.8ns	0.148	0.0135	0	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472	1.11 KB	1.1 KB	-8 B	-0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1	1.09 KB	1.08 KB	-8 B	-0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472	1.05 KB	1.04 KB	-8 B	-0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.04 KB	1.03 KB	-8 B	-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1	1.04 KB	1.03 KB	-8 B	-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.02 KB	1.01 KB	-8 B	-0.79%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`CallElasticsearch`	net6.0	1.83μs	5.85ns	22.7ns	0	0	0	1.04 KB
master	`CallElasticsearch`	netcoreapp3.1	2.3μs	11.8ns	56.6ns	0	0	0	1.04 KB
master	`CallElasticsearch`	net472	3.55μs	3.05ns	11.8ns	0.159	0	0	1.05 KB
master	`CallElasticsearchAsync`	net6.0	1.81μs	3.89ns	14.5ns	0	0	0	1.02 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.35μs	7.26ns	28.1ns	0	0	0	1.09 KB
master	`CallElasticsearchAsync`	net472	3.84μs	3.19ns	12.4ns	0.169	0	0	1.11 KB
#7120	`CallElasticsearch`	net6.0	1.84μs	9.88ns	43ns	0	0	0	1.03 KB
#7120	`CallElasticsearch`	netcoreapp3.1	2.31μs	7.96ns	30.8ns	0	0	0	1.03 KB
#7120	`CallElasticsearch`	net472	3.56μs	4.01ns	15.5ns	0.16	0	0	1.04 KB
#7120	`CallElasticsearchAsync`	net6.0	1.82μs	8.18ns	29.5ns	0	0	0	1.01 KB
#7120	`CallElasticsearchAsync`	netcoreapp3.1	2.43μs	9.45ns	36.6ns	0	0	0	1.08 KB
#7120	`CallElasticsearchAsync`	net472	3.7μs	5.09ns	19.7ns	0.166	0	0	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	960 B	952 B	-8 B	-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1	960 B	952 B	-8 B	-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472	923 B	915 B	-8 B	-0.87%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`ExecuteAsync`	net6.0	1.78μs	9.27ns	43.5ns	0	0	0	960 B
master	`ExecuteAsync`	netcoreapp3.1	2.29μs	7.45ns	25.8ns	0	0	0	960 B
master	`ExecuteAsync`	net472	2.58μs	1.78ns	6.88ns	0.143	0	0	923 B
#7120	`ExecuteAsync`	net6.0	1.97μs	5.71ns	22.1ns	0	0	0	952 B
#7120	`ExecuteAsync`	netcoreapp3.1	2.28μs	11.3ns	46.7ns	0	0	0	952 B
#7120	`ExecuteAsync`	net472	2.6μs	3.69ns	14.3ns	0.142	0	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendAsync`	net6.0	7.1μs	10.4ns	39ns	0	0	0	2.37 KB
master	`SendAsync`	netcoreapp3.1	8.69μs	14.1ns	54.6ns	0	0	0	2.9 KB
master	`SendAsync`	net472	12.5μs	10.3ns	38.5ns	0.498	0	0	3.19 KB
#7120	`SendAsync`	net6.0	7.08μs	3.15ns	11.8ns	0	0	0	2.36 KB
#7120	`SendAsync`	netcoreapp3.1	8.44μs	9.5ns	35.5ns	0	0	0	2.9 KB
#7120	`SendAsync`	net472	12.4μs	12.2ns	47.1ns	0.494	0	0	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7120

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	1.308	413,700.00	541,150.00

More allocations ⚠️ in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	57.34 KB	65.54 KB	8.19 KB	14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	259.96 KB	274.06 KB	14.1 KB	5.43%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	42.64 KB	44.02 KB	1.38 KB	3.23%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StringConcatBenchmark`	net6.0	44.6μs	212ns	1.6μs	0	0	0	43.83 KB
master	`StringConcatBenchmark`	netcoreapp3.1	47.2μs	224ns	838ns	0	0	0	42.64 KB
master	`StringConcatBenchmark`	net472	56.8μs	259ns	968ns	0	0	0	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	458μs	1.08μs	3.89μs	0	0	0	259.96 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	447μs	6.44μs	63.7μs	0	0	0	274.93 KB
master	`StringConcatAspectBenchmark`	net472	410μs	2.07μs	9.27μs	0	0	0	286.72 KB
#7120	`StringConcatBenchmark`	net6.0	48.7μs	279ns	1.95μs	0	0	0	43.82 KB
#7120	`StringConcatBenchmark`	netcoreapp3.1	47.9μs	222ns	829ns	0	0	0	44.02 KB
#7120	`StringConcatBenchmark`	net472	58.1μs	257ns	961ns	0	0	0	65.54 KB
#7120	`StringConcatAspectBenchmark`	net6.0	471μs	2.05μs	7.66μs	0	0	0	274.06 KB
#7120	`StringConcatAspectBenchmark`	netcoreapp3.1	545μs	2.35μs	9.12μs	0	0	0	275.94 KB
#7120	`StringConcatAspectBenchmark`	net472	404μs	1.76μs	6.83μs	0	0	0	286.72 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.76 KB	1.7 KB	-56 B	-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1	1.76 KB	1.7 KB	-56 B	-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472	1.69 KB	1.64 KB	-56 B	-3.31%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	2.63μs	2.6ns	10.1ns	0	0	0	1.76 KB
master	`EnrichedLog`	netcoreapp3.1	3.44μs	4.38ns	17ns	0	0	0	1.76 KB
master	`EnrichedLog`	net472	4.05μs	4.83ns	18.7ns	0.265	0	0	1.69 KB
#7120	`EnrichedLog`	net6.0	2.58μs	12.5ns	51.6ns	0	0	0	1.7 KB
#7120	`EnrichedLog`	netcoreapp3.1	3.52μs	18ns	80.6ns	0	0	0	1.7 KB
#7120	`EnrichedLog`	net472	3.97μs	2.5ns	9.69ns	0.257	0	0	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472	4.57 KB	4.52 KB	-55 B	-1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0	4.37 KB	4.31 KB	-56 B	-1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1	4.37 KB	4.31 KB	-56 B	-1.28%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	123μs	145ns	563ns	0	0	0	4.37 KB
master	`EnrichedLog`	netcoreapp3.1	126μs	330ns	1.24μs	0	0	0	4.37 KB
master	`EnrichedLog`	net472	167μs	161ns	603ns	0	0	0	4.57 KB
#7120	`EnrichedLog`	net6.0	123μs	99.7ns	345ns	0	0	0	4.31 KB
#7120	`EnrichedLog`	netcoreapp3.1	130μs	217ns	813ns	0	0	0	4.31 KB
#7120	`EnrichedLog`	net472	168μs	133ns	499ns	0	0	0	4.52 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0	2.32 KB	2.26 KB	-56 B	-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1	2.32 KB	2.26 KB	-56 B	-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472	2.14 KB	2.08 KB	-56 B	-2.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	4.94μs	19.3ns	74.6ns	0	0	0	2.32 KB
master	`EnrichedLog`	netcoreapp3.1	6.77μs	22.2ns	79.9ns	0	0	0	2.32 KB
master	`EnrichedLog`	net472	7.45μs	8.04ns	31.1ns	0.335	0	0	2.14 KB
#7120	`EnrichedLog`	net6.0	5.01μs	6.66ns	25.8ns	0	0	0	2.26 KB
#7120	`EnrichedLog`	netcoreapp3.1	6.82μs	5.98ns	23.2ns	0	0	0	2.26 KB
#7120	`EnrichedLog`	net472	7.51μs	3.27ns	12.3ns	0.299	0	0	2.08 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7120

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1	1.182	2,541.54	3,005.35

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472	1.21 KB	1.2 KB	-8 B	-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.21 KB	1.2 KB	-8 B	-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1	1.21 KB	1.2 KB	-8 B	-0.66%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendReceive`	net6.0	2.04μs	10.5ns	49.4ns	0	0	0	1.21 KB
master	`SendReceive`	netcoreapp3.1	2.53μs	11.8ns	47.4ns	0	0	0	1.21 KB
master	`SendReceive`	net472	3.28μs	2.71ns	10.5ns	0.178	0	0	1.21 KB
#7120	`SendReceive`	net6.0	1.98μs	8.39ns	32.5ns	0	0	0	1.2 KB
#7120	`SendReceive`	netcoreapp3.1	3.01μs	3.8ns	14.2ns	0	0	0	1.2 KB
#7120	`SendReceive`	net472	3.14μs	1.66ns	6.2ns	0.188	0	0	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472	2.08 KB	2.03 KB	-56 B	-2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1	1.69 KB	1.63 KB	-56 B	-3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0	1.64 KB	1.58 KB	-56 B	-3.41%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	4.18μs	0.92ns	3.44ns	0	0	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	5.64μs	23ns	89.3ns	0	0	0	1.69 KB
master	`EnrichedLog`	net472	6.67μs	7.28ns	27.3ns	0.298	0	0	2.08 KB
#7120	`EnrichedLog`	net6.0	4.17μs	3.98ns	14.9ns	0	0	0	1.58 KB
#7120	`EnrichedLog`	netcoreapp3.1	5.49μs	17.5ns	67.7ns	0	0	0	1.63 KB
#7120	`EnrichedLog`	net472	7.04μs	6.08ns	23.5ns	0.315	0	0	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	666 B	658 B	-8 B	-1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	586 B	578 B	-8 B	-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	584 B	576 B	-8 B	-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	584 B	576 B	-8 B	-1.37%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartFinishSpan`	net6.0	751ns	3.97ns	22.4ns	0	0	0	584 B
master	`StartFinishSpan`	netcoreapp3.1	953ns	4.42ns	17.7ns	0	0	0	584 B
master	`StartFinishSpan`	net472	914ns	0.809ns	3.13ns	0.0912	0	0	586 B
master	`StartFinishScope`	net6.0	918ns	0.479ns	1.73ns	0	0	0	704 B
master	`StartFinishScope`	netcoreapp3.1	1.15μs	6.24ns	34.2ns	0	0	0	704 B
master	`StartFinishScope`	net472	1.09μs	0.174ns	0.652ns	0.104	0	0	666 B
#7120	`StartFinishSpan`	net6.0	765ns	0.349ns	1.35ns	0	0	0	576 B
#7120	`StartFinishSpan`	netcoreapp3.1	943ns	5.04ns	26.2ns	0	0	0	576 B
#7120	`StartFinishSpan`	net472	925ns	0.306ns	1.15ns	0.088	0	0	578 B
#7120	`StartFinishScope`	net6.0	914ns	4.49ns	18.5ns	0	0	0	696 B
#7120	`StartFinishScope`	netcoreapp3.1	1.18μs	1.96ns	7.59ns	0	0	0	696 B
#7120	`StartFinishScope`	net472	1.14μs	0.321ns	1.24ns	0.103	0	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7120

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	666 B	658 B	-8 B	-1.20%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`RunOnMethodBegin`	net6.0	1.02μs	5.36ns	26.8ns	0	0	0	704 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.38μs	2.28ns	8.82ns	0	0	0	704 B
master	`RunOnMethodBegin`	net472	1.36μs	0.141ns	0.544ns	0.102	0	0	666 B
#7120	`RunOnMethodBegin`	net6.0	1.05μs	4.83ns	20.5ns	0	0	0	696 B
#7120	`RunOnMethodBegin`	netcoreapp3.1	1.44μs	1.28ns	4.63ns	0	0	0	696 B
#7120	`RunOnMethodBegin`	net472	1.41μs	1.97ns	7.63ns	0.0996	0	0	658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet