-
Notifications
You must be signed in to change notification settings - Fork 305
Extract Play json body response schemas #8995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manuel-alvarez-alvarez
wants to merge
2
commits into
malvarez/vertx-response-extraction
Choose a base branch
from
malvarez/play-response-extraction
base: malvarez/vertx-response-extraction
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract Play json body response schemas #8995
manuel-alvarez-alvarez
wants to merge
2
commits into
malvarez/vertx-response-extraction
from
malvarez/play-response-extraction
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 40 metrics, 8 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022194
Total [baseline] (10.676 s) : 0, 10675834
Agent [candidate] (1.029 s) : 0, 1028660
Total [candidate] (10.672 s) : 0, 10671742
section appsec
Agent [baseline] (1.182 s) : 0, 1182198
Total [baseline] (10.835 s) : 0, 10834637
Agent [candidate] (1.181 s) : 0, 1181274
Total [candidate] (10.733 s) : 0, 10733348
section iast
Agent [baseline] (1.151 s) : 0, 1150522
Total [baseline] (10.89 s) : 0, 10889666
Agent [candidate] (1.159 s) : 0, 1159334
Total [candidate] (10.89 s) : 0, 10890465
section profiling
Agent [baseline] (1.265 s) : 0, 1265197
Total [baseline] (10.915 s) : 0, 10915220
Agent [candidate] (1.278 s) : 0, 1277600
Total [candidate] (10.956 s) : 0, 10955631
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.025 ms) : 0, 683025
BytebuddyAgent [candidate] (685.055 ms) : 0, 685055
GlobalTracer [baseline] (240.675 ms) : 0, 240675
GlobalTracer [candidate] (241.372 ms) : 0, 241372
AppSec [baseline] (58.624 ms) : 0, 58624
AppSec [candidate] (62.244 ms) : 0, 62244
Debugger [baseline] (6.089 ms) : 0, 6089
Debugger [candidate] (6.143 ms) : 0, 6143
Remote Config [baseline] (725.389 µs) : 0, 725
Remote Config [candidate] (652.51 µs) : 0, 653
Telemetry [baseline] (9.585 ms) : 0, 9585
Telemetry [candidate] (9.672 ms) : 0, 9672
section appsec
BytebuddyAgent [baseline] (710.259 ms) : 0, 710259
BytebuddyAgent [candidate] (707.202 ms) : 0, 707202
GlobalTracer [baseline] (235.95 ms) : 0, 235950
GlobalTracer [candidate] (235.464 ms) : 0, 235464
AppSec [baseline] (176.658 ms) : 0, 176658
AppSec [candidate] (179.712 ms) : 0, 179712
Debugger [baseline] (5.957 ms) : 0, 5957
Debugger [candidate] (5.857 ms) : 0, 5857
Remote Config [baseline] (610.211 µs) : 0, 610
Remote Config [candidate] (642.805 µs) : 0, 643
Telemetry [baseline] (7.3 ms) : 0, 7300
Telemetry [candidate] (7.296 ms) : 0, 7296
IAST [baseline] (21.885 ms) : 0, 21885
IAST [candidate] (21.661 ms) : 0, 21661
section iast
BytebuddyAgent [baseline] (802.851 ms) : 0, 802851
BytebuddyAgent [candidate] (805.436 ms) : 0, 805436
GlobalTracer [baseline] (230.718 ms) : 0, 230718
GlobalTracer [candidate] (233.224 ms) : 0, 233224
AppSec [baseline] (50.299 ms) : 0, 50299
AppSec [candidate] (54.552 ms) : 0, 54552
Debugger [baseline] (5.964 ms) : 0, 5964
Debugger [candidate] (6.084 ms) : 0, 6084
Remote Config [baseline] (609.789 µs) : 0, 610
Remote Config [candidate] (619.018 µs) : 0, 619
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (8.023 ms) : 0, 8023
IAST [baseline] (28.654 ms) : 0, 28654
IAST [candidate] (27.85 ms) : 0, 27850
section profiling
ProfilingAgent [baseline] (103.241 ms) : 0, 103241
ProfilingAgent [candidate] (107.337 ms) : 0, 107337
BytebuddyAgent [baseline] (674.505 ms) : 0, 674505
BytebuddyAgent [candidate] (677.539 ms) : 0, 677539
GlobalTracer [baseline] (359.841 ms) : 0, 359841
GlobalTracer [candidate] (361.762 ms) : 0, 361762
AppSec [baseline] (61.885 ms) : 0, 61885
AppSec [candidate] (65.028 ms) : 0, 65028
Debugger [baseline] (6.137 ms) : 0, 6137
Debugger [candidate] (6.249 ms) : 0, 6249
Remote Config [baseline] (650.297 µs) : 0, 650
Remote Config [candidate] (664.926 µs) : 0, 665
Telemetry [baseline] (8.268 ms) : 0, 8268
Telemetry [candidate] (8.174 ms) : 0, 8174
Profiling [baseline] (103.266 ms) : 0, 103266
Profiling [candidate] (107.362 ms) : 0, 107362
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1033256
Total [baseline] (8.582 s) : 0, 8581567
Agent [candidate] (1.027 s) : 0, 1027436
Total [candidate] (8.558 s) : 0, 8557708
section iast
Agent [baseline] (1.152 s) : 0, 1151518
Total [baseline] (9.212 s) : 0, 9212341
Agent [candidate] (1.163 s) : 0, 1163419
Total [candidate] (9.252 s) : 0, 9251521
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.023 ms) : 0, 691023
BytebuddyAgent [candidate] (683.672 ms) : 0, 683672
GlobalTracer [baseline] (242.389 ms) : 0, 242389
GlobalTracer [candidate] (240.777 ms) : 0, 240777
AppSec [baseline] (59.528 ms) : 0, 59528
AppSec [candidate] (61.705 ms) : 0, 61705
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.144 ms) : 0, 6144
Remote Config [baseline] (742.573 µs) : 0, 743
Remote Config [candidate] (672.786 µs) : 0, 673
Telemetry [baseline] (9.658 ms) : 0, 9658
Telemetry [candidate] (11.075 ms) : 0, 11075
section iast
BytebuddyAgent [baseline] (803.529 ms) : 0, 803529
BytebuddyAgent [candidate] (810.701 ms) : 0, 810701
GlobalTracer [baseline] (231.458 ms) : 0, 231458
GlobalTracer [candidate] (232.384 ms) : 0, 232384
AppSec [baseline] (51.781 ms) : 0, 51781
AppSec [candidate] (52.849 ms) : 0, 52849
Debugger [baseline] (5.894 ms) : 0, 5894
Debugger [candidate] (6.055 ms) : 0, 6055
Remote Config [baseline] (603.516 µs) : 0, 604
Remote Config [candidate] (600.21 µs) : 0, 600
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (7.97 ms) : 0, 7970
IAST [baseline] (26.806 ms) : 0, 26806
IAST [candidate] (29.367 ms) : 0, 29367
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 0 metrics, 7 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (7.815 ms) : 7793, 7838
. : milestone, 7815,
appsec (8.523 ms) : 8496, 8551
. : milestone, 8523,
code_origins (9.709 ms) : 9676, 9743
. : milestone, 9709,
iast (7.789 ms) : 7762, 7816
. : milestone, 7789,
profiling (2.624 µs) : 1, 4
. : milestone, 3,
tracing (8.637 ms) : 8611, 8662
. : milestone, 8637,
section candidate
no_agent (37.1 ms) : 36336, 37864
. : milestone, 37100,
appsec (66.558 ms) : 65205, 67910
. : milestone, 66558,
code_origins (81.622 ms) : 78468, 84777
. : milestone, 81622,
iast (76.234 ms) : 74281, 78188
. : milestone, 76234,
profiling (58.747 ms) : 57693, 59802
. : milestone, 58747,
tracing (49.787 ms) : 48927, 50648
. : milestone, 49787,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.416 ms) : 2367, 2466
. : milestone, 2416,
iast (2.204 ms) : 2142, 2266
. : milestone, 2204,
iast_GLOBAL (2.238 ms) : 2177, 2300
. : milestone, 2238,
profiling (2.473 ms) : 2311, 2636
. : milestone, 2473,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.404 ms) : 2355, 2453
. : milestone, 2404,
iast (2.199 ms) : 2137, 2261
. : milestone, 2199,
iast_GLOBAL (2.229 ms) : 2168, 2291
. : milestone, 2229,
profiling (2.039 ms) : 1988, 2089
. : milestone, 2039,
tracing (2.008 ms) : 1961, 2055
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~135e0f01a5, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
dateFormat X
axisFormat %s
section baseline
no_agent (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
appsec (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
iast (18.471 s) : 18471000, 18471000
. : milestone, 18471000,
iast_GLOBAL (18.155 s) : 18155000, 18155000
. : milestone, 18155000,
profiling (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
tracing (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
section candidate
no_agent (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
appsec (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
iast (18.95 s) : 18950000, 18950000
. : milestone, 18950000,
iast_GLOBAL (18.207 s) : 18207000, 18207000
. : milestone, 18207000,
profiling (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
tracing (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
|
956faea
to
0078896
Compare
7d13dbd
to
cb58b47
Compare
0078896
to
ad782b6
Compare
cb58b47
to
0078896
Compare
0078896
to
e6d0da9
Compare
e6d0da9
to
bf5e01e
Compare
23f52bc
to
f7b1451
Compare
f7b1451
to
cf8d5bc
Compare
cf8d5bc
to
135e0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
inst: play framework
Play Framework instrumentation
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds response body extraction for Play JSON endpoints to enable automatic API schema discovery and protection by the Web Application Firewall (WAF). Support is for Play >= 2.4+ (leverages new JSON response API)
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57914