fix(prof): disable allocation profiling when JIT is enabled on PHP 8.4 #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
=========================================
Coverage 78.92% 78.92%
Complexity 2927 2927
=========================================
Files 114 114
Lines 11582 11582
=========================================
Hits 9141 9141
Misses 2441 2441
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2025-04-09 15:24:42 Comparing candidate commit 9f65c84 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
realFlowControl
force-pushed
the
florian/disable-on-jit-with-php-84
branch
from
aa1736b to
4dfd79e
Compare
realFlowControl
force-pushed
the
florian/disable-on-jit-with-php-84
branch
from
4dfd79e to
9f65c84
Compare
morrisonlevi
approved these changes
Apr 9, 2025
morrisonlevi
changed the title
bwoebi
pushed a commit
that referenced
this pull request
Apr 10, 2025
#3199) * Disable allocation profiling when JIT is enabled on PHP 8.4 * update link * add test and update link
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A customer reached out in #3197 with a crash while collecting a stack frame for an allocation that is done while hot function is compiled. This code seems to be there since the new JIT in PHP 8.4. So for now we are disabling allocation profiling when an active JIT is detected in PHP 8.4.
Update
The upstream fix was released with PHP 8.4.7
Reviewer checklist