Skip to content

fix(radio/checkbox): 修复 radio/checkbox group 按钮形态属性 direction="column" 时样式异常 #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

Zz-ZzzZ
Copy link
Contributor

@Zz-ZzzZ Zz-ZzzZ commented Sep 21, 2022

修复后如图
1663749596712
1663749617547

@github-actions
Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1353.surge.sh.

@kagol kagol added the bug Something isn't working label Sep 21, 2022
@kagol
Copy link
Member

kagol commented Sep 28, 2022

@Cv-Engineer123 这个效果可能不是特别好
image

建议如下:

  1. 每一项宽度应该保持一致
  2. 按钮之间的border-radius应该为零

预期效果大致如下:
image

@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Sep 28, 2022

好的 我改一下

@kagol kagol mentioned this pull request Sep 28, 2022
50 tasks
@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Sep 28, 2022

@kagol
更改后效果如图
我把checkbox-group的column也一并更改了
1664360470799
1664360492230

@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Sep 28, 2022

补充checkbox-group全部选中时的效果图

1664361331378(1)

@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Sep 28, 2022

新增了两个提交

  1. 看了一下历史提交记录,radio-button本身没有定义box-shadow,所以可以去掉box-shadow: none
  2. checkbox-button的box-shadow应该在group模式下才会出现,若使用单个时不需要该属性

@github-actions
Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1353.surge.sh.

@kagol kagol merged commit 7913d96 into DevCloudFE:dev Sep 30, 2022
@pr-triage pr-triage bot added the PR: merged label Sep 30, 2022
@kagol
Copy link
Member

kagol commented Oct 5, 2022

@all-contributors please add @Cv-Engineer123 for code

@allcontributors
Copy link
Contributor

@kagol

We had trouble processing your request. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants