Skip to content

to_timestamp_* scalar functions family #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 23, 2025
Merged

to_timestamp_* scalar functions family #1259

merged 18 commits into from
Jul 23, 2025

Conversation

ravlio
Copy link
Contributor

@ravlio ravlio commented Jul 4, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Jul 4, 2025

SQL Logic Tests Results ❌

Coverage by SLT File

  • to_timestamp: 0/10 (0.0%)
  • try_to_timestamp: 0/0 (100.0%)

Overall: 0/10 (0.0%)

Copy link
Contributor

github-actions bot commented Jul 4, 2025

SQL Logic Tests Results ❌

Coverage by SLT File

  • to_timestamp: 0/10 (0.0%)
  • try_to_timestamp: 0/0 (100.0%)

Overall: 0/10 (0.0%)

Copy link
Contributor

github-actions bot commented Jul 5, 2025

SQL Logic Tests Results ❌

Coverage by SLT File

  • try_to_timestamp: 0/0 (100.0%)
  • to_timestamp: 0/10 (0.0%)

Overall: 0/10 (0.0%)

@ravlio ravlio force-pushed the maxim/to_timestamp branch from b67bf44 to 3744c50 Compare July 9, 2025 17:32
Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ The SLT test execution failed. Please check the workflow logs for details.

@ravlio ravlio force-pushed the maxim/to_timestamp branch from 3744c50 to 7666f1f Compare July 14, 2025 14:01
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • set: 6/16 (37.5%)
  • timestampdiff: 0/3 (0.0%)
  • timestamp_from_parts: 3/6 (50.0%)
  • convert_timezone: 0/3 (0.0%)
  • to_timestamp: 0/10 (0.0%)
  • try_to_timestamp: 0/0 (100.0%)
  • timestampadd: 5/5 (100.0%)

Overall: 14/43 (32.6%)

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • try_to_timestamp: 0/0 (100.0%)
  • timestampadd: 5/5 (100.0%)
  • timestampdiff: 0/3 (0.0%)
  • timestamp_from_parts: 3/6 (50.0%)
  • convert_timezone: 1/3 (33.3%)
  • to_timestamp: 2/10 (20.0%)

Overall: 11/27 (40.7%)

@ravlio ravlio force-pushed the maxim/to_timestamp branch from 594e48a to 8324fb4 Compare July 22, 2025 11:46
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • convert_timezone: 1/3 (33.3%)
  • try_to_timestamp: 0/0 (100.0%)
  • timestamp_from_parts: 3/6 (50.0%)
  • to_timestamp: 2/10 (20.0%)

Overall: 6/19 (31.6%)

Copy link
Contributor

SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

1 similar comment
Copy link
Contributor

SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@Vedin Vedin marked this pull request as ready for review July 22, 2025 13:42
@Vedin
Copy link
Contributor

Vedin commented Jul 22, 2025

I didn't check the correctness. Overall I believe it works. As I can see SLT's haven't run after the recent changes. What's the current state? Should we change some of them with a proper comment? I believe some of them are still failing, but for now, it's expected behaviour.

@ravlio ravlio force-pushed the maxim/to_timestamp branch from 7e64f9e to 05aace1 Compare July 22, 2025 14:40
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • to_timestamp: 2/10 (20.0%)
  • timestamp_from_parts: 3/6 (50.0%)
  • timestampadd: 5/5 (100.0%)
  • try_to_timestamp: 0/0 (100.0%)
  • timestampdiff: 0/3 (0.0%)

Overall: 10/24 (41.7%)

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • try_to_timestamp: 0/0 (100.0%)
  • to_timestamp: 2/10 (20.0%)

Overall: 2/10 (20.0%)

@ravlio
Copy link
Contributor Author

ravlio commented Jul 22, 2025

I didn't check the correctness. Overall I believe it works. As I can see SLT's haven't run after the recent changes. What's the current state? Should we change some of them with a proper comment? I believe some of them are still failing, but for now, it's expected behaviour.

We shouldn't change slt tests.

DF/Embucket has strange behaviour rendering timestamp. DF produces:

SELECT to_timestamp_tz('2024-04-05 01:02:03');
2024-04-05T01:02:03-07:00

while Embucket gives:

2024-04-05 08:02:03

somehow tz is applied to timestamp and converted to UTC. Most of the slt fail due to this. I think it is a different problem and we can merge this PR.

@ravlio ravlio requested a review from Vedin July 22, 2025 16:43
@ravlio ravlio merged commit e2fd06a into main Jul 23, 2025
20 checks passed
@ravlio ravlio deleted the maxim/to_timestamp branch July 23, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants