-
Notifications
You must be signed in to change notification settings - Fork 3
to_timestamp_*
scalar functions family
#1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 0/10 (0.0%) |
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 0/10 (0.0%) |
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 0/10 (0.0%) |
b67bf44
to
3744c50
Compare
|
3744c50
to
7666f1f
Compare
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 14/43 (32.6%) |
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 11/27 (40.7%) |
594e48a
to
8324fb4
Compare
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 6/19 (31.6%) |
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
1 similar comment
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
I didn't check the correctness. Overall I believe it works. As I can see SLT's haven't run after the recent changes. What's the current state? Should we change some of them with a proper comment? I believe some of them are still failing, but for now, it's expected behaviour. |
7e64f9e
to
05aace1
Compare
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 10/24 (41.7%) |
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 2/10 (20.0%) |
We shouldn't change slt tests. DF/Embucket has strange behaviour rendering timestamp. DF produces:
while Embucket gives:
somehow tz is applied to timestamp and converted to UTC. Most of the slt fail due to this. I think it is a different problem and we can merge this PR. |
No description provided.