Revert "Cut version 1.23.0 (#2380)" (#2382)

This reverts commit 1c40d45.

Author: rnystrom

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,24 +1,21 @@
 disabled_rules:
   - function_parameter_count
+  - line_length
+  - identifier_name
+  - type_name
   - function_body_length
   - type_body_length
   - force_try
   - force_cast
-  - cyclomatic_complexity
-  - identifier_name
-  - type_name
-  - line_length
-  - file_length
-  - large_tuple
-  - nesting
+  - trailing_whitespace
 
 included: 
   - Classes
   - FreetimeTests
-  - Local\ Pods
 excluded:
   - Pods
+  - Local Pods
   - Playgrounds
-  - Local\ Pods/SwipeCellKit
+  - Sample
 
 reporter: "xcode"

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,110 @@
+# App Store Details
+
+[App Store Link](https://itunes.apple.com/us/app/githawk-for-github/id1252320249?ls=1&mt=8)
+
+## App Information
+
+### Name
+
+GitHawk for GitHub
+
+### Subtitle
+
+Better GitHub notifications
+
+### Privacy Policy URL
+
+http://githawk.com/privacy.html
+
+### Category
+
+1. Productivity
+2. Utilities
+
+### Rating
+
+4+
+
+## Version Information
+
+### Keywords
+
+```
+github,codehub,gitbucket,ioctocat,gitlab,repository,gitbucket,gitter,gothub,githun,girhub,bitbucket
+```
+
+- github
+- codehub
+- gitbucket
+- ioctocat
+- gitlab
+- repository
+- gitbucket
+- gitter
+- gothub
+- githun
+- girhub
+- bitbucket
+
+### Description
+
+```
+GitHawk will help you achieve INBOX ZERO with your GitHub notifications. Comment on Issues and Pull Requests even faster than GitHub desktop. GitHawk is also the first-ever mobile app that lets you add emoji reactions!
+
+TOP FEATURES
+
+- Reach INBOX ZERO with GitHub notifications
+- Read, reply, and react to Issues and Pull Requests
+- Fast, native GitHub flavored Markdown
+- Browse Repositories and create Issues
+- 100% open source
+
+ISSUES & PULL REQUESTS
+
+- Browse file changes
+- Manage labels, reviewers, assignees, and miletones
+- Open, close and lock
+- React with emoji on comments
+- Read comments, reviews, and view the timeline
+- Comment with fast Markdown shortcuts
+- Edit and delete comments
+
+NOTIFICATIONS
+
+- Browse latest notifications
+- Swipe to mark read or Mark All
+
+SEARCH
+
+- Search for Repositories (Issues and Users coming soon!)
+- View recent searches
+
+BOOKMARKS
+
+- Keep track of your favorite Repositories, Issues, and Pull Requests
+
+REPOSITORIES
+
+- READMEs are native and fast
+- View Issues and Pull Requests
+- Browse files and code
+- Create new Issues
+
+OTHER
+
+- Homescreen badge for unread notifications
+- Sign in with multiple accounts
+- View GitHub API status
+
+GitHawk is also fully open source, so if there are features or fixes that you want, its as simple as building it yourself! You can find all of the source code on GitHub:
+
+github.com/rnystrom/githawk
+
+Follow us on Twitter: @githawk
+```
+
+### URLs
+
+- **Support URL:** http://githawk.com
+- **Marketing URL:** http://githawk.com
+

.swiftlint.yml

@@ -25,7 +25,7 @@ final class BookmarkCell: SwipeSelectableCell {
 
     override init(frame: CGRect) {
         super.init(frame: frame)
-
+        
         backgroundColor = .white
 
         contentView.clipsToBounds = true
@@ -84,14 +84,14 @@ final class BookmarkCell: SwipeSelectableCell {
                 string: "\(viewModel.bookmark.owner)/\(viewModel.bookmark.name)",
                 attributes: [
                     .font: Styles.Text.secondaryBold.preferredFont,
-                    .foregroundColor: Styles.Colors.Gray.light.color
+                    .foregroundColor: Styles.Colors.Gray.light.color,
                     ]
             )
             detailString.append(NSAttributedString(
                 string: " #\(viewModel.bookmark.number)",
                 attributes: [
                     .font: Styles.Text.secondary.preferredFont,
-                    .foregroundColor: Styles.Colors.Gray.light.color
+                    .foregroundColor: Styles.Colors.Gray.light.color,
                 ]
             ))
             detailLabel.attributedText = detailString

AppStore.md

@@ -14,7 +14,6 @@ final class BookmarkNavigationController {
 
     private let store: BookmarkStore
     private let model: Bookmark
-    private static let iconImageInset = UIEdgeInsets(top: 0, left: 16, bottom: 0, right: 0)
 
     init?(store: BookmarkStore?, model: Bookmark?) {
         guard let store = store, let model = model else { return nil }
@@ -23,19 +22,19 @@ final class BookmarkNavigationController {
     }
 
     // MARK: Public API
-
+    
     var navigationItem: UIBarButtonItem {
         let item = UIBarButtonItem()
         configureNavigationItem(item)
         return item
     }
-
+    
     func configureNavigationItem(_ item: UIBarButtonItem) {
-
+        
         let accessibilityLabel: String
         let imageName: String
         let selector: Selector
-
+        
         if store.contains(model) {
             imageName = "nav-bookmark-selected"
             accessibilityLabel = Constants.Strings.removeBookmark
@@ -45,38 +44,36 @@ final class BookmarkNavigationController {
             accessibilityLabel = Constants.Strings.bookmark
             selector = #selector(BookmarkNavigationController.add(sender:))
         }
-
+        
         item.accessibilityLabel = accessibilityLabel
         item.image = UIImage(named: imageName)?.withRenderingMode(.alwaysTemplate)
         item.target = self
         item.action = selector
         item.isEnabled = true
         item.width = 0
-        item.imageInsets = BookmarkNavigationController.iconImageInset
     }
-
+    
     //for timeframe between viewDidLoad() and bookmark info is loaded 
     static var disabledNavigationItem: UIBarButtonItem {
         let item = UIBarButtonItem()
         item.image = UIImage(named: "nav-bookmark")?.withRenderingMode(.alwaysTemplate)
         item.isEnabled = false
-        item.imageInsets = BookmarkNavigationController.iconImageInset
         return item
     }
-
+    
     // MARK: Private API
-
+    
     @objc func add(sender: UIBarButtonItem) {
         Haptic.triggerSelection()
         sender.action = #selector(BookmarkNavigationController.remove(sender:))
         sender.image = UIImage(named: "nav-bookmark-selected")?.withRenderingMode(.alwaysTemplate)
         store.add(model)
     }
-
+    
     @objc func remove(sender: UIBarButtonItem) {
         sender.action = #selector(BookmarkNavigationController.add(sender:))
         sender.image = UIImage(named: "nav-bookmark")?.withRenderingMode(.alwaysTemplate)
         store.remove(model)
     }
-
+    
 }

CODE_OF_CONDUCT.md

@@ -32,7 +32,7 @@ final class BookmarkSectionController: ListGenericSectionController<BookmarkView
 
         return CGSize(
             width: width,
-            height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeight + Styles.Sizes.rowSpacing * 2)
+            height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeightLarge)
         )
     }
 

Classes/Bookmark/BookmarkCell.swift

@@ -76,6 +76,7 @@ TabNavRootViewControllerType {
 
         searchBar.delegate = self
         searchBar.placeholder = Constants.Strings.searchBookmarks
+        searchBar.tintColor = Styles.Colors.Blue.medium.color
         searchBar.backgroundColor = .clear
         searchBar.searchBarStyle = .minimal
         navigationItem.titleView = searchBar
@@ -98,11 +99,12 @@ TabNavRootViewControllerType {
             collectionView.collectionViewLayout.invalidateForOrientationChange()
         }
     }
-
+  
     override func viewWillDisappear(_ animated: Bool) {
       searchBar.resignFirstResponder()
     }
 
+
     private func update(animated: Bool) {
         adapter.performUpdates(animated: animated)
     }