GitHawkApp
diff --git a/‎.github/ISSUE_TEMPLATE/bug_report.md
Lines changed: 35 additions & 0 deletions b/‎.github/ISSUE_TEMPLATE/bug_report.md
Lines changed: 35 additions & 0 deletions
diff --git a/‎.github/ISSUE_TEMPLATE/feature_request.md
Lines changed: 17 additions & 0 deletions b/‎.github/ISSUE_TEMPLATE/feature_request.md
Lines changed: 17 additions & 0 deletions
diff --git a/‎.swiftlint.yml
Lines changed: 9 additions & 6 deletions b/‎.swiftlint.yml
Lines changed: 9 additions & 6 deletions
diff --git a/‎AppStore.md
Lines changed: 0 additions & 110 deletions b/‎AppStore.md
Lines changed: 0 additions & 110 deletions
diff --git a/‎CODE_OF_CONDUCT.md
Lines changed: 46 additions & 0 deletions b/‎CODE_OF_CONDUCT.md
Lines changed: 46 additions & 0 deletions
diff --git a/‎Classes/Bookmark/BookmarkCell.swift
Lines changed: 3 additions & 3 deletions b/‎Classes/Bookmark/BookmarkCell.swift
Lines changed: 3 additions & 3 deletions
diff --git a/‎Classes/Bookmark/BookmarkNavigationController.swift
Lines changed: 13 additions & 10 deletions b/‎Classes/Bookmark/BookmarkNavigationController.swift
Lines changed: 13 additions & 10 deletions
diff --git a/‎Classes/Bookmark/BookmarkSectionController.swift
Lines changed: 1 addition & 1 deletion b/‎Classes/Bookmark/BookmarkSectionController.swift
Lines changed: 1 addition & 1 deletion
diff --git a/‎Classes/Bookmark/BookmarkViewController.swift
Lines changed: 1 addition & 3 deletions b/‎Classes/Bookmark/BookmarkViewController.swift
Lines changed: 1 addition & 3 deletions
@@ -0,0 +1,35 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.
@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.
@@ -1,21 +1,24 @@
 disabled_rules:
   - function_parameter_count
-  - line_length
-  - identifier_name
-  - type_name
   - function_body_length
   - type_body_length
   - force_try
   - force_cast
-  - trailing_whitespace
+  - cyclomatic_complexity
+  - identifier_name
+  - type_name
+  - line_length
+  - file_length
+  - large_tuple
+  - nesting
 
 included: 
   - Classes
   - FreetimeTests
+  - Local\ Pods
 excluded:
   - Pods
-  - Local Pods
   - Playgrounds
-  - Sample
+  - Local\ Pods/SwipeCellKit
 
 reporter: "xcode"
@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/
@@ -25,7 +25,7 @@ final class BookmarkCell: SwipeSelectableCell {
 
     override init(frame: CGRect) {
         super.init(frame: frame)
-        
+
         backgroundColor = .white
 
         contentView.clipsToBounds = true
@@ -84,14 +84,14 @@ final class BookmarkCell: SwipeSelectableCell {
                 string: "\(viewModel.bookmark.owner)/\(viewModel.bookmark.name)",
                 attributes: [
                     .font: Styles.Text.secondaryBold.preferredFont,
-                    .foregroundColor: Styles.Colors.Gray.light.color,
+                    .foregroundColor: Styles.Colors.Gray.light.color
                     ]
             )
             detailString.append(NSAttributedString(
                 string: " #\(viewModel.bookmark.number)",
                 attributes: [
                     .font: Styles.Text.secondary.preferredFont,
-                    .foregroundColor: Styles.Colors.Gray.light.color,
+                    .foregroundColor: Styles.Colors.Gray.light.color
                 ]
             ))
             detailLabel.attributedText = detailString
 
@@ -14,6 +14,7 @@ final class BookmarkNavigationController {
 
     private let store: BookmarkStore
     private let model: Bookmark
+    private static let iconImageInset = UIEdgeInsets(top: 0, left: 16, bottom: 0, right: 0)
 
     init?(store: BookmarkStore?, model: Bookmark?) {
         guard let store = store, let model = model else { return nil }
@@ -22,19 +23,19 @@ final class BookmarkNavigationController {
     }
 
     // MARK: Public API
-    
+
     var navigationItem: UIBarButtonItem {
         let item = UIBarButtonItem()
         configureNavigationItem(item)
         return item
     }
-    
+
     func configureNavigationItem(_ item: UIBarButtonItem) {
-        
+
         let accessibilityLabel: String
         let imageName: String
         let selector: Selector
-        
+
         if store.contains(model) {
             imageName = "nav-bookmark-selected"
             accessibilityLabel = Constants.Strings.removeBookmark
@@ -44,36 +45,38 @@ final class BookmarkNavigationController {
             accessibilityLabel = Constants.Strings.bookmark
             selector = #selector(BookmarkNavigationController.add(sender:))
         }
-        
+
         item.accessibilityLabel = accessibilityLabel
         item.image = UIImage(named: imageName)?.withRenderingMode(.alwaysTemplate)
         item.target = self
         item.action = selector
         item.isEnabled = true
         item.width = 0
+        item.imageInsets = BookmarkNavigationController.iconImageInset
     }
-    
+
     //for timeframe between viewDidLoad() and bookmark info is loaded 
     static var disabledNavigationItem: UIBarButtonItem {
         let item = UIBarButtonItem()
         item.image = UIImage(named: "nav-bookmark")?.withRenderingMode(.alwaysTemplate)
         item.isEnabled = false
+        item.imageInsets = BookmarkNavigationController.iconImageInset
         return item
     }
-    
+
     // MARK: Private API
-    
+
     @objc func add(sender: UIBarButtonItem) {
         Haptic.triggerSelection()
         sender.action = #selector(BookmarkNavigationController.remove(sender:))
         sender.image = UIImage(named: "nav-bookmark-selected")?.withRenderingMode(.alwaysTemplate)
         store.add(model)
     }
-    
+
     @objc func remove(sender: UIBarButtonItem) {
         sender.action = #selector(BookmarkNavigationController.add(sender:))
         sender.image = UIImage(named: "nav-bookmark")?.withRenderingMode(.alwaysTemplate)
         store.remove(model)
     }
-    
+
 }
@@ -32,7 +32,7 @@ final class BookmarkSectionController: ListGenericSectionController<BookmarkView
 
         return CGSize(
             width: width,
-            height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeightLarge)
+            height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeight + Styles.Sizes.rowSpacing * 2)
         )
     }
 
 
@@ -76,7 +76,6 @@ TabNavRootViewControllerType {
 
         searchBar.delegate = self
         searchBar.placeholder = Constants.Strings.searchBookmarks
-        searchBar.tintColor = Styles.Colors.Blue.medium.color
         searchBar.backgroundColor = .clear
         searchBar.searchBarStyle = .minimal
         navigationItem.titleView = searchBar
@@ -99,12 +98,11 @@ TabNavRootViewControllerType {
             collectionView.collectionViewLayout.invalidateForOrientationChange()
         }
     }
-  
+
     override func viewWillDisappear(_ animated: Bool) {
       searchBar.resignFirstResponder()
     }
 
-
     private func update(animated: Bool) {
         adapter.performUpdates(animated: animated)
     }
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ final class BookmarkSectionController: ListGenericSectionController<BookmarkView`
`32`	`32`
`33`	`33`	`return CGSize(`
`34`	`34`	`width: width,`
`35`		`- height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeightLarge)`
	`35`	`+ height: max(object.text.viewSize(in: width).height, Styles.Sizes.tableCellHeight + Styles.Sizes.rowSpacing * 2)`
`36`	`36`	`)`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,6 @@ TabNavRootViewControllerType {`
`76`	`76`
`77`	`77`	`searchBar.delegate = self`
`78`	`78`	`searchBar.placeholder = Constants.Strings.searchBookmarks`
`79`		`- searchBar.tintColor = Styles.Colors.Blue.medium.color`
`80`	`79`	`searchBar.backgroundColor = .clear`
`81`	`80`	`searchBar.searchBarStyle = .minimal`
`82`	`81`	`navigationItem.titleView = searchBar`
`@@ -99,12 +98,11 @@ TabNavRootViewControllerType {`
`99`	`98`	`collectionView.collectionViewLayout.invalidateForOrientationChange()`
`100`	`99`	`}`
`101`	`100`	`}`
`102`		`-`
	`101`	`+`
`103`	`102`	`override func viewWillDisappear(_ animated: Bool) {`
`104`	`103`	`searchBar.resignFirstResponder()`
`105`	`104`	`}`
`106`	`105`
`107`		`-`
`108`	`106`	`private func update(animated: Bool) {`
`109`	`107`	`adapter.performUpdates(animated: animated)`
`110`	`108`	`}`