Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Manager cell text to Constants #2207

Merged
merged 1 commit into from
Sep 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Classes/Issues/IssueManagingContextController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,10 @@ final class IssueManagingContextController: NSObject, ContextMenuDelegate {
title = Constants.Strings.reviewers
iconName = "reviewer"
case .unlock:
title = NSLocalizedString("Unlock", comment: "")
title = Constants.Strings.unlock
iconName = "key"
case .lock:
title = NSLocalizedString("Lock", comment: "")
title = Constants.Strings.lock
iconName = "lock"
case .reopen:
title = Constants.Strings.reopen
Expand Down
12 changes: 6 additions & 6 deletions Classes/Issues/Managing/IssueManagingSectionController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,37 +19,37 @@ ContextMenuDelegate {
private enum Action {
static let labels = IssueManagingActionModel(
key: "tag",
label: NSLocalizedString("Labels", comment: ""),
label: Constants.Strings.labels,
imageName: "tag",
color: "3f88f7".color
)
static let milestone = IssueManagingActionModel(
key: "milestone",
label: NSLocalizedString("Milestone", comment: ""),
label: Constants.Strings.milestone,
imageName: "milestone",
color: "6847ba".color
)
static let assignees = IssueManagingActionModel(
key: "person",
label: NSLocalizedString("Assignees", comment: ""),
label: Constants.Strings.assignees,
imageName: "person",
color: "e77230".color
)
static let reviewers = IssueManagingActionModel(
key: "reviewer",
label: NSLocalizedString("Reviewers", comment: ""),
label: Constants.Strings.reviewers,
imageName: "reviewer",
color: "50a451".color
)
static let lock = IssueManagingActionModel(
key: "lock", // share key so lock/unlock just updates cell
label: NSLocalizedString("Lock", comment: ""),
label: Constants.Strings.lock,
imageName: "lock",
color: Styles.Colors.Gray.dark.color
)
static let unlock = IssueManagingActionModel(
key: "lock", // share key so lock/unlock just updates cell
label: NSLocalizedString("Unlock", comment: ""),
label: Constants.Strings.unlock,
imageName: "key",
color: Styles.Colors.Gray.dark.color
)
Expand Down
2 changes: 2 additions & 0 deletions Classes/Views/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ enum Constants {
static let reopened = NSLocalizedString("Reopened", comment: "")
static let unknown = NSLocalizedString("Unknown", comment: "")
static let merged = NSLocalizedString("Merged", comment: "")
static let unlock = NSLocalizedString("Unlock", comment: "")
static let lock = NSLocalizedString("Lock", comment: "")
static let locked = NSLocalizedString("Locked", comment: "")
static let newIssue = NSLocalizedString("New Issue", comment: "")
static let bullet = "\u{2022}"
Expand Down