This repository was archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 382
Button to display Push Notification info in Settings #2282
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
Classes/Settings/PushNotificationsDisclaimerViewController.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // PushNotificationsDisclaimerViewController.swift | ||
| // Freetime | ||
| // | ||
| // Created by Ryan Nystrom on 10/13/18. | ||
| // Copyright © 2018 Ryan Nystrom. All rights reserved. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| final class PushNotificationsDisclaimerViewController: UIViewController { | ||
|
|
||
| private let textView = UITextView() | ||
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
|
|
||
| navigationItem.rightBarButtonItem = UIBarButtonItem( | ||
| barButtonSystemItem: .done, | ||
| target: self, | ||
| action: #selector(onDone) | ||
| ) | ||
| title = NSLocalizedString("Push Notifications", comment: "") | ||
|
|
||
| textView.textContainerInset = UIEdgeInsets( | ||
| top: 0, | ||
| left: Styles.Sizes.gutter, | ||
| bottom: Styles.Sizes.gutter, | ||
| right: Styles.Sizes.gutter | ||
| ) | ||
| textView.isEditable = false | ||
|
|
||
| textView.font = Styles.Text.body.preferredFont | ||
| textView.textColor = Styles.Colors.Gray.dark.color | ||
| textView.text = NSLocalizedString("GitHawk uses iOS background fetch to periodically check for new GitHub notifications. When there is new content available, GitHawk sends alerts with local notifications.\n\nThis setup requires Background App Refresh be enabled to work. Enable this feature in Settings > General > Background App Refresh.\n\nAt GitHawk, we value your privacy and data. Real-time push notifications require sending your authentication data to servers, which is a security risk we want to avoid.", comment: "") | ||
| view.addSubview(textView) | ||
|
|
||
| preferredContentSize = textView.sizeThatFits(CGSize( | ||
| width: min(320, UIScreen.main.bounds.width - Styles.Sizes.rowSpacing * 2), | ||
| height: CGFloat.greatestFiniteMagnitude | ||
| )) | ||
| } | ||
|
|
||
| override func viewWillLayoutSubviews() { | ||
| super.viewWillLayoutSubviews() | ||
| textView.frame = view.bounds | ||
| } | ||
|
|
||
| @objc private func onDone() { | ||
| dismiss(animated: true) | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put this in a multiline string?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that work for localized strings?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it is possible, but it looks more of a hassle than when we don't: https://stackoverflow.com/a/51478852.