This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Search for labels in-app #2309
Closed
Search for labels in-app #2309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To init and present a RepositoryIssuesViewController, need a GithubClient to pass in.
- Instead of initializing using RepositoryDetails, only use owner and repo. Makes it easier to present a new RepoIssuesVC without needing a reference to RepositoryDetails. The only info from RepoDetails that we were using anyway was was owner and name.
rnystrom
suggested changes
Oct 19, 2018
| @@ -10,11 +10,13 @@ import Foundation | |||
|
|
|||
| final class LabelDetails { | |||
|
|
|||
| let client: GithubClient | |||
There was a problem hiding this comment.
Is there another way to pass the client around beside attaching it to a model? This puts a lot of baggage in these models (the client object is basically a full app session!)
There was a problem hiding this comment.
Re-tried this in a new PR - didn't do enough homework on how this is handled elsewhere in the app. Thanks for the feedback!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #2263
In most files, the changes are adding a
GithubClientparameter so that it can be passed to theLabelDetailsmodel, which is passed along to init and present aRepositoryIssuesViewController.Also, I removed the RepositoryDetails parameter from the
RepositoryIssuesViewControllerinitializer and replaced it withownerandname. This was so that we didn't have to pass around a reference toRepositoryDetailsas well, and also because we were only using thenameandownerfields ofRepositoryDetailsanyway.vid:
I've checked manually that it works when labels are embedded in other contexts as well. Only place it doesn't work is on the main RepoIssuesSectionController list, which as @Huddie suggested, we should enable as well.