Fix pushing Issues VC when user taps on username in referenced issues

[natharateh]

This fixes #2260. 🤞

When user taps IssueReferencedCell, 2 competing delegates can be notified -

1. UICollectionViewDelegate
2. MarkdownStyledTextViewDelegate

When both delegates are notified (for example when user taps username in a referenced issue), UICollectionViewDelegate (IssueReferencedSectionController) will push a new IssuesViewController :

GitHawk/Classes/Issues/Referenced/IssueReferencedSectionController.swift

Line 39 in f28b119

viewController?.route_push(to: IssuesViewController(client: client, model: model))

and MarkdownStyledTextViewDelegate (IssuesViewController) will present a profile via SFSafariViewController :

GitHawk/Classes/Utility/UIViewController+Routing.swift

Line 21 in 80d1255

case .username(let username): presentProfile(login: username)

Since IssueReferencedSectionController implements UICollectionViewDelegate, I made it conform to the competing delegate (MarkdownStyledTextViewDelegate) so that we can figure out which delegate should proceed - if we're notified that username was tapped, we'll present the profile VC and set a flag that will prevent the other delegate from pushing the Issues VC.

Let me know if there's a better way to do this. 🤔

[jdisho]

The solution looks good to me. However, I have one question.
Shouldn’t we also set shouldShowIssueOnItemSelection to false on cases like email, url and commit? 🤔

[natharateh]

Good point @jdisho 🤔 Maybe we could use the result of handle(attribute: DetectedMarkdownAttribute) -> Bool to set shouldShowIssueOnItemSelection? That handles all the cases we care about - url, email, username and commit :

GitHawk/Classes/Utility/UIViewController+Routing.swift

Line 14 in 80d1255

func handle(attribute: DetectedMarkdownAttribute) -> Bool {

So something like

    func didTap(cell: MarkdownStyledTextView, attribute: DetectedMarkdownAttribute) {
        guard let viewController = viewController else {
            return
        }
        shouldShowIssueOnItemSelection = !viewController.handle(attribute: attribute)
    }

If the attribute can be handled, handle will do the work & return true, if not, we'll allow didSelectItem to proceed. What do you think?

[jdisho]

Nice one @nambatee!
I think we can continue with this suggestion 👍

[natharateh]

Thanks @jdisho! 😄 Pushed it in b79d0aa

[jdisho]

Awesome! Thank you @nambatee