Add ability to start lasso select within object without dragging layers #2799
Conversation
| if handle_drag_from_anchor { | ||
| if let Some((layer, point)) = shape_editor.find_nearest_point_indices(&document.network_interface, input.mouse.position, SELECTION_THRESHOLD) { | ||
| // Check that selected point is an anchor |
There was a problem hiding this comment.
didn't change almost any of this logic. The diff just seems large because I moved the pieces from the if/else chain into a match statement
|
if this change is too involved and not preferred there is a simpler change here: #2798 |
|
I tested this and didn't find any obvious regressions @Keavon 👍 |
|
@hemu could you please resolve the merge conflict? I tried but it looks like it affects the structure of an if-else statement that changed. Thanks. Also, please mark this as ready for review and comment when you've completed this. I'm marking it as a draft for now while waiting the resolution. |
|
looking at the other merged commits in the past week that intersect with the same files in this PR, i think too much has changed underneath and the safer thing to do at this point is redo this entirely. will close this and take another crack at in a new PR so it can get retested and re-reviewed with same level of scrutiny as a new change |
|
When you have your redo ready, please push it to this branch and reopen the same PR rather than filing a new PR. |
When beginning a lasso select from within an object, currently the behavior is to drag its layers. This PR updates this behavior such that a lasso select beginning within an object will remain a lasso selection over the existing layers.
Refactor select_tool and path_tool transition drag logic to determine an "intent" up front. This made it easier to incorporate the type of logic needed in this PR where the lasso select intent has priority over others, but its logic is shared with box select which has the lowest priority so it was hard to capture this in the existing if/else chain.
Part of #2647
NOTE: This is an alternate implementation compared to this simpler change: #2798
Before
graphite_fix_start_lasso_inside_before.mp4
After
graphite_fix_start_lasso_inside_after.mp4