Add TwoOffsets_CombinedIndexer, and UnpackedStridedIndexer #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TwoOffsets_CombinedIndexer takes two single offset indexers and combines them into a TwoOffsets struct. The UnpackedStridedIndexer is a relative of StridedIndexer, except shapes and strides are provided as separate pointers. This increases its size, but may be useful to produce indexer that only computes the second offset using shape/strides stored in packed format for two-offset indexers. These are going to be used in reduction kernels.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1162/index.html |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_89 ran successfully. |
ndgrigorian
approved these changes
Apr 7, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_91 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TwoOffsets_CombinedIndexertakes two single offset indexers and combines their indexing results into aTwoOffsetsstruct.The
UnpackedStridedIndexeris a relative ofStridedIndexer, except shapes and strides are provided as separate pointers. This increases its size, but may be useful to produce indexer that only computes the second offset using shape/strides stored in packed format for two-offset indexers.These are going to be used in reduction kernels.