Skip to content

Fix tests for py3.11 #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix tests for py3.11 #1172

merged 3 commits into from
Apr 17, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR addresses deprecation warning reported when dpt.arange(512*1024, 0, step=-1, dtype="i2") is evaluated issued by NumPy 1.24.

This PR also fixes test_sycl_queue_manager.py:: test_device_context_activates_nested_context which fails with Python 3.11 due
to the change the exception type raised when attempting to nest contexts using object which does not implement context protocol.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Fixed deprecation warning about NumPy scalar construction
173488f 
If the input Python object is out of range for the type being
created, a warning is issued, e.g. `np.int16(512*1024)`.
This commit implements the suggested work-around.
@oleksandr-pavlyk
Fixed test due to change in exception type raised in Py 3.11
1c6029a
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1172/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 15, 2023 •
edited
Loading

Coverage Status

Coverage: 83.254% (+0.03%) from 83.224% when pulling b8e2890 on fix-tests-for-py3.11 into 456f46f on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_112 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_113 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

@oleksandr-pavlyk
Generate coverage workflow changes
b8e2890 
1. Use Python 3.11
2. Use Google Test 1.13.0
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_113 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

@oleksandr-pavlyk
Copy link
Contributor Author

The second commit in this PR updates "generate-coverage.yaml" workflow to run on Python 3.11 and to use GTest 1.13.0

@oleksandr-pavlyk oleksandr-pavlyk merged commit b050e8c into master Apr 17, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-tests-for-py3.11 branch April 17, 2023 18:07
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_113 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls