-
Notifications
You must be signed in to change notification settings - Fork 30
InfoDev review of API section #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfoDev review of API section #1659
Conversation
I reviewed the API section. There were some terms that did not match up so I changed them. For example C-API is not how Python uses the C API name so I removed the - .
@ndgrigorian @xaleryb I do not have the ability to add reviewers. Please add appropriate reviewers to this PR. |
I've added myself and @oleksandr-pavlyk |
docs/doc_sources/api_reference/dpctl/sycl_usm_array_interface.rst
Outdated
Show resolved
Hide resolved
docs/doc_sources/api_reference/dpctl/sycl_usm_array_interface.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksandr Pavlyk <[email protected]>
Co-authored-by: Oleksandr Pavlyk <[email protected]>
Co-authored-by: Oleksandr Pavlyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bdmoore1 for the changes! They look good to me now.
As a side note, should we be using Python/C API as in https://docs.python.org/3/c-api/index.html, or Python C API as in the document?
If the change is needed, let's do it in a separate PR.
@oleksandr-pavlyk yes we should standardize the name Python/C API. I will create a DOC Jira and target 2025.0 to complete that task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I reviewed the API section. There were some terms that did not match up so I changed them. For example C-API is not how Python uses the C API name so I removed the - .
I will submit separate PRs for these sections: beginners_guides, contributor_guides, and user_guides.