Skip to content

Update wheel tag with pep600 #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

ekomarova
Copy link
Contributor

@ekomarova ekomarova commented May 6, 2024

This PR is designed to fix the problem described here: SAT-6873. I did some experiments and found out that using pep600 wheel tag prevents the wheel from being installed on non-supported platforms

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ekomarova ekomarova requested a review from oleksandr-pavlyk May 6, 2024 18:22
Copy link

github-actions bot commented May 6, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.892%. remained the same
when pulling 5435817 on ekomarova/update_wheel_tag
into 0cb2181 on master.

Copy link

github-actions bot commented May 6, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_327 ran successfully.
Passed: 882
Failed: 10
Skipped: 92

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ekomarova.

I have not tested this change myself yet. I assume testing was part performed while working out particulars of this change.

@ekomarova ekomarova merged commit 1243edc into master May 7, 2024
@ekomarova ekomarova deleted the ekomarova/update_wheel_tag branch May 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants