tweak to functor implementing gemm #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not make any difference in performance due to compiler optimization being effective as loops are unrolled, but makes compiler's job easier and the intent clearer.
oleksandr-pavlyk
force-pushed
the
tweak-to-gemm
branch
from
92514f1 to
af82129
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully. |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optimization to save rows/cols of sub-matrices stored in SLM into registers prior to summing over delta_m, delta_n and updating private result with products.
This does not make any difference in performance of the compiled code though due to compiler optimization being effective as loops are unrolled, but makes compiler's job easier and the intent clearer.