Rename dppl to dpctl #201
Merged
Rename dppl to dpctl #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
approved these changes
Dec 4, 2020
| @@ -1,4 +1,4 @@ | |||
| //===------------------- dppl_utils.h - dpctl-C_API ---*--- C++ -----*-----===// | |||
| //===------------------- dpctl_utils.h - dpctl-C_API ---*--- C++ -----*-----===// | |||
There was a problem hiding this comment.
Nitpick. Can you please make sure the line is 80 chars wide. Remove few - in the comment line. The fix to line width will apply to all/most modified files.
| __dppl_keep const DPPLSyclContextRef CtxRef2); | ||
| DPCTL_API | ||
| bool DPCTLContext_AreEq (__dpctl_keep const DPCTLSyclContextRef CtxRef1, | ||
| __dpctl_keep const DPCTLSyclContextRef CtxRef2); |
There was a problem hiding this comment.
extra leading white space.
| DPCTL_API | ||
| __dpctl_give DPCTLSyclKernelRef | ||
| DPCTLProgram_GetKernel (__dpctl_keep DPCTLSyclProgramRef PRef, | ||
| __dpctl_keep const char *KernelName); |
There was a problem hiding this comment.
Unfortunately we have no C/C++ formatter yet.
| DPCTL_API | ||
| __dpctl_give DPCTLSyclProgramRef | ||
| DPCTLProgram_CreateFromOCLSpirv (__dpctl_keep const DPCTLSyclContextRef Ctx, | ||
| __dpctl_keep const void *IL, |
There was a problem hiding this comment.
leading white spaces. The issue exists in several places, may be it is a tabsize issue please take a look.
|
I am waiting for a new "Great job!" from daal4py again! We had plan in #31. See its header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the #31