-
Notifications
You must be signed in to change notification settings - Fork 30
Rename dppl to dpctl #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dppl to dpctl #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor formatting nitpicks, but otherwise ready to go. Thanks for taking care of it.
@@ -1,4 +1,4 @@ | |||
//===------------------- dppl_utils.h - dpctl-C_API ---*--- C++ -----*-----===// | |||
//===------------------- dpctl_utils.h - dpctl-C_API ---*--- C++ -----*-----===// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick. Can you please make sure the line is 80 chars wide. Remove few -
in the comment line. The fix to line width will apply to all/most modified files.
__dppl_keep const DPPLSyclContextRef CtxRef2); | ||
DPCTL_API | ||
bool DPCTLContext_AreEq (__dpctl_keep const DPCTLSyclContextRef CtxRef1, | ||
__dpctl_keep const DPCTLSyclContextRef CtxRef2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra leading white space.
DPCTL_API | ||
__dpctl_give DPCTLSyclKernelRef | ||
DPCTLProgram_GetKernel (__dpctl_keep DPCTLSyclProgramRef PRef, | ||
__dpctl_keep const char *KernelName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leading white space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we have no C/C++ formatter yet.
DPCTL_API | ||
__dpctl_give DPCTLSyclProgramRef | ||
DPCTLProgram_CreateFromOCLSpirv (__dpctl_keep const DPCTLSyclContextRef Ctx, | ||
__dpctl_keep const void *IL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leading white spaces. The issue exists in several places, may be it is a tabsize issue please take a look.
I am waiting for a new "Great job!" from daal4py again! We had plan in #31. See its header. |
Closes the #31