Skip to content

Rename dppl to dpctl #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Rename dppl to dpctl #201

merged 2 commits into from
Dec 4, 2020

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Dec 4, 2020

Closes the #31

Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor formatting nitpicks, but otherwise ready to go. Thanks for taking care of it.

@@ -1,4 +1,4 @@
//===------------------- dppl_utils.h - dpctl-C_API ---*--- C++ -----*-----===//
//===------------------- dpctl_utils.h - dpctl-C_API ---*--- C++ -----*-----===//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick. Can you please make sure the line is 80 chars wide. Remove few - in the comment line. The fix to line width will apply to all/most modified files.

__dppl_keep const DPPLSyclContextRef CtxRef2);
DPCTL_API
bool DPCTLContext_AreEq (__dpctl_keep const DPCTLSyclContextRef CtxRef1,
__dpctl_keep const DPCTLSyclContextRef CtxRef2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra leading white space.

DPCTL_API
__dpctl_give DPCTLSyclKernelRef
DPCTLProgram_GetKernel (__dpctl_keep DPCTLSyclProgramRef PRef,
__dpctl_keep const char *KernelName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leading white space.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we have no C/C++ formatter yet.

DPCTL_API
__dpctl_give DPCTLSyclProgramRef
DPCTLProgram_CreateFromOCLSpirv (__dpctl_keep const DPCTLSyclContextRef Ctx,
__dpctl_keep const void *IL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leading white spaces. The issue exists in several places, may be it is a tabsize issue please take a look.

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Dec 5, 2020

I am waiting for a new "Great job!" from daal4py again!
Release notes should highlight this changes twice.

We had plan in #31. See its header.

@1e-to 1e-to deleted the rename branch March 2, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants