Skip to content

Fix Klocwork issues #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

We use [clang-format](https://clang.llvm.org/docs/ClangFormat.html) code formatter.

Install: `pip install clang`
Install: `conda install clang-tools`

- Revision: `10.0.1`
- See the default configuration used by dpCtl in `.clang-format`.
Expand Down
1 change: 1 addition & 0 deletions dpctl-capi/helper/include/dpctl_dynamic_lib_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ namespace dpctl
class DynamicLibHelper final
{
public:
DynamicLibHelper &operator=(const DynamicLibHelper &) = delete;
DynamicLibHelper() = delete;
DynamicLibHelper(const DynamicLibHelper &) = delete;
DynamicLibHelper(const char *libName, int flag)
Expand Down
2 changes: 2 additions & 0 deletions dpctl-capi/source/dpctl_sycl_program_interface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,11 @@ DPCTLProgram_CreateFromOCLSource(__dpctl_keep const DPCTLSyclContextRef Ctx,
break;
case backend::level_zero:
std::cerr << "CreateFromSource is not supported in Level Zero.\n";
delete SyclProgram;
return nullptr;
default:
std::cerr << "CreateFromSource is not supported in unknown backend.\n";
delete SyclProgram;
return nullptr;
}
}
Expand Down