Method _usm_type of Memory class should accept sycl_context #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PokhodenkoSA
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Looks good for me. It would be better if there was a test.
@oleksandr-pavlyk could you please also add a test for this method?
Tests for USM: dppl/tests/dppl_tests/test_sycl_usm.py
PokhodenkoSA
approved these changes
Sep 21, 2020
| ctx = <SyclContext>(context) | ||
| kind = DPPLUSM_GetPointerType(self.memory_ptr, | ||
| ctx.get_context_ref()) | ||
| elif isinstance(context, SyclQueue): |
There was a problem hiding this comment.
What if name the variable context_or_queue ?
There was a problem hiding this comment.
Yes, makes sense. Since the argument can be either context or queue. If we do not like long names, let us just call it syclobj or something other than context.
diptorupd
reviewed
Sep 21, 2020
| @@ -46,16 +46,30 @@ def test_memory_without_context (self): | |||
| def test_memory_cpu_context (self): | |||
| mobj = self._create_memory() | |||
|
|
|||
| # CPU context | |||
| # CPU context | |||
vlad-perevezentsev
added a commit
to vlad-perevezentsev/dpctl
that referenced
this pull request
Nov 30, 2020
vlad-perevezentsev
added a commit
to vlad-perevezentsev/dpctl
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PokhodenkoSA @diptorupd