Add a execution_status method for the SyclEventRaw class
#522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,3 +206,18 @@ cdef class SyclEventRaw(_SyclEventRaw): | |||
| "SyclEventRef", | |||
| &_event_capsule_deleter | |||
| ) | |||
|
|
|||
| def execution_status(self): | |||
There was a problem hiding this comment.
Perhaps this should be a read-only property.
In [2]: dpctl.SyclEventRaw().execution_status
Out[2]: <function SyclEventRaw.execution_status>
In [3]: dpctl.SyclEventRaw().execution_status()
Out[3]: <event_status_type.complete: 4>So one would use In[2] rather than In[3].
There was a problem hiding this comment.
Suggested change
| def execution_status(self): | |
| @property | |
| def execution_status(self): |
vlad-perevezentsev
force-pushed
the
cython_getstatus
branch
from
17459e0 to
a201184
Compare
oleksandr-pavlyk
approved these changes
Aug 13, 2021
vlad-perevezentsev
added a commit
to vlad-perevezentsev/dpctl
that referenced
this pull request
Aug 23, 2021
vlad-perevezentsev
added a commit
that referenced
this pull request
Aug 23, 2021
oleksandr-pavlyk
pushed a commit
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
execution_statusmethod which returns the value of the 'event_status_type' enumeration.