Skip to content

Documentation overhaul #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

diptorupd
Copy link
Contributor

The PR seeks to address the long overdue overhaul of dpctl's documentation. I have started rewriting the introductory paragraphs and added stubs for a user manual that remains to be filled.

@diptorupd
Copy link
Contributor Author

@oleksandr-pavlyk @adarshyoga I am counting on your reviews and help in filling in the missing pieces. :)

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2021

Coverage Status

Coverage remained the same at 74.445% when pulling 1cead76 on diptorupd:user-guide into 9d264fd on IntelPython:master.

`dpnp <https://intelpython.github.io/dpnp/>`_ package, a NumPy-like
library of pre-compiled kernels written in the
`SYCL language <https://sycl.readthedocs.io/en/latest/index.html>`_. Dpnp too
uses dpctl to schedule and execute the kernels it provides.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dpnp too uses dpctl to schedule and execute the kernels it provides.

I do not think this is true. dpnp only uses dpctl.SyclQueue provided by the user, and submits to that queue by directly calling the DPC++ run-time, i.e. q.submit(...).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dpctl.tensor will also be using DPC++ runtime directly.

@adarshyoga
Copy link
Contributor

@diptorupd , let me take a stab at queues and submitting kernels.

@diptorupd diptorupd closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants