Skip to content

-fsycl-device-code-split=per_kernel must be passed to linker, not compiler #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Thanks the compiler team for pointing this out.

Now, envoking copy kernels for different types calls JIT-ting as evidenced by

(idp_2022) [14:54:46 ansatnuc04 dpctl]$ SYCL_PI_TRACE=-1 python -c "import dpctl.tensor as dpt; print(dpt.__file__); X = dpt.empty(10, 'd'); Y = dpt.empty(10, 'i4'); X[:] = Y; X1 = dpt.empty(10,'f4'); X1[:] = Y" >& pi_trace.txt
(idp_2022) [14:54:55 ansatnuc04 dpctl]$ grep -c piProgramCreate pi_trace.txt
2

Previously the output was 1 (all 14*14 kernels were compiled all at once which was slower)
on the first invocation.

…iler team

Now, envoking copy kernels for different types calls JIT-ting as evidenced by

```
(idp_2022) [14:54:46 ansatnuc04 dpctl]$ SYCL_PI_TRACE=-1 python -c "import dpctl.tensor as dpt; print(dpt.__file__); X = dpt.empty(10, 'd'); Y = dpt.empty(10, 'i4'); X[:] = Y; X1 = dpt.empty(10,'f4'); X1[:] = Y" >& pi_trace.txt
(idp_2022) [14:54:55 ansatnuc04 dpctl]$ grep -c piProgramCreate pi_trace.txt
2
```

Previously the output was 1 (all 14*14 kernels were compiled all at once which was slower)
on the first invocation.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.063% when pulling 7cf8a8c on jit-per-kernel into f469af2 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit a20344b into master Mar 24, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the jit-per-kernel branch March 24, 2022 23:05
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants