Skip to content

Fixed usage of unwrap in comment to templated one #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

Fixed usage of non-templated unwrap(KRef) to unwrap<kernel>(KRef) since implementation was changed in #960.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the corrected-use-of-non-templated-unwrap-in-comments branch from 06c9b91 to 5247b38 Compare November 6, 2022 13:57
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_21 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2022

Coverage Status

Coverage remained the same at 81.996% when pulling 52999ac on corrected-use-of-non-templated-unwrap-in-comments into c610e9b on master.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_21 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the corrected-use-of-non-templated-unwrap-in-comments branch from 5247b38 to 52999ac Compare November 7, 2022 14:45
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_23 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit fafa979 into master Nov 7, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the corrected-use-of-non-templated-unwrap-in-comments branch November 7, 2022 18:55
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_28 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants