Add property flags to dpnp_array #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Dec 22, 2022
tests/test_dparray.py
Outdated
Comment on lines
45
to
47
| expected = dpt.usm_ndarray(shape, order=order) | ||
| result = dpnp.ndarray(shape, order=order) | ||
| assert expected.flags == result.flags |
There was a problem hiding this comment.
what if to extend the test (or add additional one), where to compare flags with numpy array? like:
Suggested change
| expected = dpt.usm_ndarray(shape, order=order) | |
| result = dpnp.ndarray(shape, order=order) | |
| assert expected.flags == result.flags | |
| usm_array = dpt.usm_ndarray(shape, order=order) | |
| numpy_array = numpy.ndarray(shape, order=order) | |
| dpnp_array = dpnp.ndarray(shape, order=order) | |
| assert usm_array.flags == dpnp_array.flags | |
| assert numpy_array.flags.c_contiguous == dpnp_array.flags.c_contiguous | |
| assert numpy_array.flags.f_contiguous == dpnp_array.flags.f_contiguous |
antonwolfy
reviewed
Dec 22, 2022
| @pytest.mark.parametrize("order", | ||
| ["C", "F"], | ||
| ids=['C', 'F']) | ||
| def test_flags(shape, order): |
There was a problem hiding this comment.
I guess, also it would be good to add a test of flags with different strides.
antonwolfy
approved these changes
Dec 23, 2022
oleksandr-pavlyk
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added property flags to dpnp_array by using dpctl.tensor.usm_ndarray.flags.