Skip to content

Replaced windows-latest with windows-2019 to fix windows builds #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2024
Merged

Replaced windows-latest with windows-2019 to fix windows builds #1833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d37d3d
Replaced windows-latest with windows-2019 to fix windows builds
antonwolfy May 17, 2024
ae6cb0b
Merge branch 'master' into use-windows-2019
antonwolfy May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/conda-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
strategy:
matrix:
python: ['3.9', '3.10', '3.11']
os: [ubuntu-20.04, windows-latest]
os: [ubuntu-20.04, windows-2019]

permissions:
# Needed to cancel any previous runs that are not completed for a given workflow
Expand All @@ -77,7 +77,7 @@ jobs:

defaults:
run:
shell: ${{ matrix.os == 'windows-latest' && 'cmd /C CALL {0}' || 'bash -l {0}' }}
shell: ${{ matrix.os == 'windows-2019' && 'cmd /C CALL {0}' || 'bash -l {0}' }}

continue-on-error: true

Expand Down Expand Up @@ -253,11 +253,11 @@ jobs:
python -m pytest -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }}

test_windows:
name: Test ['windows-latest', python='${{ matrix.python }}']
name: Test ['windows-2019', python='${{ matrix.python }}']

needs: build

runs-on: windows-latest
runs-on: windows-2019

defaults:
run:
Expand Down Expand Up @@ -409,7 +409,7 @@ jobs:
strategy:
matrix:
python: ['3.9', '3.10', '3.11']
os: [ubuntu-20.04, windows-latest]
os: [ubuntu-20.04, windows-2019]

runs-on: ${{ matrix.os }}

Expand Down