Update mkl_lapack::batch_error handling in getrf_batch / getri_batch
#2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy,
AlexanderKalistratov,
vtavana and
ndgrigorian
as code owners
vlad-perevezentsev
changed the title
mkl_lapacl::batch_error handling in getrf_batch / getri_batchmkl_lapack::batch_error handling in getrf_batch / getri_batch
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev3=py312he4f9c94_17 ran successfully. |
antonwolfy
reviewed
May 19, 2025
antonwolfy
approved these changes
May 19, 2025
github-actions bot
added a commit
that referenced
this pull request
May 19, 2025
…atch` (#2458) This PR suggests improvements to the handling of `oneapi::mkl::lapack::batch_error` in `oneapi::mkl::lapack::getrf_batch` and `oneapi::mkl::lapack::getri_batch` OneMKL batched functions throw a single `oneapi::mkl::lapack::batch_error` interpreted as computation_error for all failed matrices (ids()). Now set dev_info[...] = 1 for each to determinate singular matrix. This change allows a consistent raising of `LinAlgError` in `dpnp.linalg.inv()` for both non-batched and batched singular matrices and unskipping tests with singular matrices for `dpnp.linalg.inv()` , `dpnp.linalg.det`, `dpnp.linalg.slogdet` 56ccf86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests improvements to the handling of
oneapi::mkl::lapack::batch_errorinoneapi::mkl::lapack::getrf_batchandoneapi::mkl::lapack::getri_batchOneMKL batched functions throw a single
oneapi::mkl::lapack::batch_errorinterpreted as computation_error for all failed matrices (ids()). Now set dev_info[...] = 1 for each to determinate singular matrix.This change allows a consistent raising of
LinAlgErrorindpnp.linalg.inv()for both non-batched and batched singular matrices and unskipping tests with singular matrices fordpnp.linalg.inv(),dpnp.linalg.det,dpnp.linalg.slogdet