Skip to content

Fix compilation warnings #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

Fix compilation warnings #2517

merged 3 commits into from
Jul 7, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 7, 2025

This PR resolves compilation warnings:

warning: class template argument deduction for alias templates is a C++20 extension [-Wc++20-extensions]

As for now DPNP is building with C++17 standard, and Class Template Argument Deduction is available where only for a class template, but not for a type alias. What support was added in C++20 standard.

Since there are currently no plans to move to the C++20 standard, the code has been updated to conform to the C++17 standard.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Copy link
Contributor

github-actions bot commented Jul 7, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_4 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.051% (-0.001%) from 72.052%
when pulling 815383a on resolve-compilation-warnings
into 0684c1f on master.

@antonwolfy antonwolfy merged commit 624f14f into master Jul 7, 2025
119 of 121 checks passed
@antonwolfy antonwolfy deleted the resolve-compilation-warnings branch July 7, 2025 15:35
github-actions bot added a commit that referenced this pull request Jul 7, 2025
This PR resolves compilation warnings:
> warning: class template argument deduction for alias templates is a
C++20 extension [-Wc++20-extensions]

As for now DPNP is building with C++17 standard, and Class Template
Argument Deduction is available where only for a class template, but not
for a type alias. What support was added in C++20 standard.

Since there are currently no plans to move to the C++20 standard, the
code has been updated to conform to the C++17 standard. 624f14f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants