Skip to content

Add implementation of dpnp.ndarray.view method #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 10, 2025
Merged

Add implementation of dpnp.ndarray.view method #2520

merged 8 commits into from
Jul 10, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 8, 2025 •
edited
Loading

This PR adds implementation of dpnp.ndarray.view method.
All places in the code with connected TODO comments were updated properly.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 8, 2025
@antonwolfy antonwolfy self-assigned this Jul 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_11 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2025 •
edited
Loading

Coverage Status

coverage: 72.088% (+0.04%) from 72.051%
when pulling c989693 on add-view-method
into d15d395 on master.

@antonwolfy antonwolfy linked an issue Jul 9, 2025 that may be closed by this pull request
[dpnp.ndarray] Issue with .view() #2486
Closed
@antonwolfy antonwolfy marked this pull request as ready for review July 9, 2025 10:59
vtavana
vtavana approved these changes Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 9b73305 into master Jul 10, 2025
97 of 98 checks passed
@antonwolfy antonwolfy deleted the add-view-method branch July 10, 2025 10:56
github-actions bot added a commit that referenced this pull request Jul 10, 2025
@github-actions
Add implementation of dpnp.ndarray.view method (#2520)
0922edb 
This PR adds implementation of `dpnp.ndarray.view` method.
All places in the code with connected TODO comments were updated
properly. 9b73305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.

[dpnp.ndarray] Issue with .view()
3 participants
@antonwolfy @coveralls @vtavana