Skip to content

Add job explicit, conservative job timeouts #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-sphinx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
name: Build and Deploy Docs

runs-on: ubuntu-22.04
timeout-minutes: 60

permissions:
# Needed to cancel any previous runs that are not completed for a given workflow
Expand Down Expand Up @@ -244,6 +245,7 @@ jobs:
pull-requests: write

runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/check-onemath.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
actions: write

runs-on: 'ubuntu-latest'
timeout-minutes: 5

steps:
- name: Cancel Previous Runs
Expand Down Expand Up @@ -69,6 +70,7 @@ jobs:
os: [ubuntu-22.04] # windows-2022 - no DFT support for Windows in oneMKL

runs-on: ${{ matrix.os }}
timeout-minutes: 60

defaults:
run:
Expand Down Expand Up @@ -157,6 +159,7 @@ jobs:
os: [ubuntu-22.04] # windows-2022 - no DFT support for Windows in oneMKL

runs-on: ${{ matrix.os }}
timeout-minutes: 60

defaults:
run:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/conda-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
actions: write

runs-on: ${{ matrix.os }}
timeout-minutes: 60

defaults:
run:
Expand Down Expand Up @@ -118,6 +119,7 @@ jobs:
needs: build

runs-on: ${{ matrix.os }}
timeout-minutes: 100

defaults:
run:
Expand Down Expand Up @@ -245,6 +247,7 @@ jobs:
needs: build

runs-on: ${{ matrix.os }}
timeout-minutes: 120

defaults:
run:
Expand Down Expand Up @@ -406,6 +409,7 @@ jobs:
os: [ubuntu-22.04, windows-2022]

runs-on: ${{ matrix.os }}
timeout-minutes: 10

defaults:
run:
Expand Down Expand Up @@ -487,6 +491,7 @@ jobs:
os: [ubuntu-22.04]

runs-on: ${{ matrix.os }}
timeout-minutes: 15

defaults:
run:
Expand Down Expand Up @@ -649,6 +654,7 @@ jobs:
needs: [upload]

runs-on: 'ubuntu-latest'
timeout-minutes: 10

defaults:
run:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cron-run-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
if: github.event.repository.fork == false

runs-on: ${{ matrix.runner }}
timeout-minutes: 60

defaults:
run:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/generate_coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ permissions: read-all
jobs:
generate-coverage:
name: Generate coverage and push to Coveralls.io

runs-on: ubuntu-latest
timeout-minutes: 120

permissions:
# Needed to cancel any previous runs that are not completed for a given workflow
Expand Down Expand Up @@ -154,6 +156,7 @@ jobs:
needs: generate-coverage

runs-on: ubuntu-latest
timeout-minutes: 10

container: python:3-slim

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/openssf-scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
analysis:
name: Scorecard analysis
runs-on: ubuntu-latest
timeout-minutes: 10
permissions:
# Needed to upload the results to code-scanning dashboard.
security-events: write
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pre-commit
name: Run pre-commit

on:
pull_request:
Expand All @@ -9,7 +9,11 @@ permissions: read-all

jobs:
pre-commit:
name: Check

runs-on: ubuntu-22.04
timeout-minutes: 10

steps:
- name: Set up clang-format
run: |
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Added several new `pre-commit` rules, including protection against direct commits to master/maintenance branches [#2500](https://github.com/IntelPython/dpnp/pull/2500)
* Added implementation of `dpnp.ndarray.view` method [#2520](https://github.com/IntelPython/dpnp/pull/2520)
* Added a new backend routine `syrk` from oneMKL to perform symmetric rank-k update which is used for a specialized matrix multiplication where the result is a symmetric matrix [2509](https://github.com/IntelPython/dpnp/pull/2509)
* Added `timeout-minutes` property to GitHub jobs [#2526](https://github.com/IntelPython/dpnp/pull/2526)

### Changed

Expand Down
Loading