Skip to content

Remove use of numpy.testing.suppress_warnings in tests #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Remove use of numpy.testing.suppress_warnings in tests #2529

merged 2 commits into from
Jul 16, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 16, 2025 •
edited
Loading

NumPy is going to deprecate use of numpy.testing.suppress_warnings and to fully migrate to warnings module internally which is tread-safe.
This PR updates the tests and replaces the use of numpy.testing.suppress_warnings with appropriate calls from the warnings module.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 16, 2025
@antonwolfy antonwolfy self-assigned this Jul 16, 2025
vtavana
vtavana approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_13 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.092%. remained the same
when pulling 7b8386a on remove-use-of-suppress_warnings
into e2c0469 on master.

@antonwolfy antonwolfy merged commit fed6925 into master Jul 16, 2025
94 of 96 checks passed
@antonwolfy antonwolfy deleted the remove-use-of-suppress_warnings branch July 16, 2025 17:07
github-actions bot added a commit that referenced this pull request Jul 16, 2025
@github-actions
Remove use of numpy.testing.suppress_warnings in tests (#2529)
48aa0ed 
NumPy is going to deprecate use of `numpy.testing.suppress_warnings` and
to fully migrate to `warnings` module internally which is tread-safe.
This PR updates the tests and replaces the use of
`numpy.testing.suppress_warnings` with appropriate calls from the
`warnings` module. fed6925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana