Skip to content

Enable offloading for numba.njit in dpctl.device_context #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 25, 2021
Merged

Enable offloading for numba.njit in dpctl.device_context #630

merged 15 commits into from
Nov 25, 2021

Conversation

PokhodenkoSA
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA commented Nov 19, 2021 •
edited
Loading

Relates to IntelPython/dpctl#678.

Tasks:

  • docs
  • changelog
  • dppy.offload_to_sycl_device reuses dpctl.device_context
  • replace dppy.offload_to_sycl_device with dpctl.device_context in all tests
  • dpctl >=0.12 or >=0.11.2

@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 19, 2021
Merged
7 tasks
reazulhoque
reazulhoque reviewed Nov 19, 2021
View reviewed changes
PokhodenkoSA
PokhodenkoSA commented Nov 19, 2021
View reviewed changes
@PokhodenkoSA
Copy link
Contributor Author

Documentation update is not necessary. Because we have example with dpctl.device_context on the main page.

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Nov 24, 2021 •
edited
Loading

Ready to be reviewed.
Waiting to be merged after IntelPython/dpctl#678. Depends on dpctl 0.11.2 or 0.12.0.

@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 25, 2021
Merged
4 tasks
@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Nov 25, 2021 •
edited
Loading

Rebased to release0.17.3.
Merging based on public CI and local testing.

@PokhodenkoSA PokhodenkoSA merged commit f9f850d into release0.17.3 Nov 25, 2021
github-actions bot pushed a commit that referenced this pull request Nov 25, 2021
@PokhodenkoSA
Enable offloading for numba.njit in dpctl.device_context (#630) f…
cf53db3 
…9f850d
@1e-to 1e-to added ignore-for-release-notes and removed bug Something isn't working labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reazulhoque reazulhoque reazulhoque left review comments

@diptorupd diptorupd Awaiting requested review from diptorupd

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees

@PokhodenkoSA PokhodenkoSA

Labels
dpctl Integration with dpctl ignore-for-release-notes
Projects
None yet
Milestone
0.17.3
Development

Successfully merging this pull request may close these issues.
3 participants
@PokhodenkoSA @reazulhoque @1e-to