Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Patch for addrspace #92

Closed
wants to merge 1 commit into from
Closed

Patch for addrspace #92

wants to merge 1 commit into from

Conversation

PokhodenkoSA
Copy link

This commit removes modification that introduce addrspace
in ce96c20 by @DrTodd13 and test are fixed in 947b407 by @reazulhoque.
This commit could be reverted to get the patch which could be proposed
to upstream.

@PokhodenkoSA PokhodenkoSA mentioned this pull request Nov 9, 2020
Closed
50 tasks
@PokhodenkoSA
Copy link
Author

This looks like something to upstream. But there is several ways to go:

  1. Ask Numba to add addrspace to CPointer. - Upstream way. Is addrspace so universal to be used by other libraries (maybe missed in Numba)? Or it is only for us?
  2. We can redesign Numba to allow work with arrays and custom pointer types. Now it is not possible to mix numpy functions which uses array with custom types. - A lot of work.

@PokhodenkoSA
Patch for addrspace
e5f4a54 
This commit removes modification that introduce addrspace
in ce96c20 by @DrTodd13 and test are fixed in 947b407 by @reazulhoque.
This commit could be reverted to get the patch which could be proposed
to upstream.
@PokhodenkoSA
Copy link
Author

Moved to upstream for discussion: numba#6469

@PokhodenkoSA
Copy link
Author

numba#6469 merged. Will be available in 0.54.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrTodd13 DrTodd13 Awaiting requested review from DrTodd13

@reazulhoque reazulhoque Awaiting requested review from reazulhoque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release (0.54)
Development

Successfully merging this pull request may close these issues.
1 participant
@PokhodenkoSA