-
Notifications
You must be signed in to change notification settings - Fork 340
Closed as not planned
Labels
Description
Describe the bug
Related issue:
- Fix the editor height in review box go-gitea/gitea#19003
- The related code (only a few lines): https://github.com/go-gitea/gitea/pull/19003/files
In some cases, we need to set minHeight
and maxHeight
at the same time.
However, although the EasyMDE document has described the details of minHeight
/maxHeight
handling, the current logic is not ideal.
To Reproduce
Current logic:
{minHeight: '80px', maxHeight: 'calc(100vh-200px)'}
becomes style="min-height: calc(100vh-200px); height: calc(100vh-200px)"
Then users are not able to make the heights correct in some cases.
Expected behavior
Just pass minHeight
to min-height
and maxHeight
to max-height
as they are.
artaommahe