-
Notifications
You must be signed in to change notification settings - Fork 187
Use dir instead of getmembers #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
==========================================
- Coverage 67.63% 67.61% -0.02%
==========================================
Files 20 20
Lines 1965 1967 +2
==========================================
+ Hits 1329 1330 +1
- Misses 636 637 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@stevengj can a new release be tagged as well? |
@stevengj can you tag a new release? One of my packages needs this fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
==========================================
- Coverage 67.63% 67.61% -0.02%
==========================================
Files 20 20
Lines 1965 1967 +2
==========================================
+ Hits 1329 1330 +1
- Misses 636 637 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #857 by using
dir
to get names of properties instead ofgetmembers
, which also gets the properties themselves and therefore errors when properties are optional.