Skip to content

Use dir instead of getmembers #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 18, 2021
Merged

Use dir instead of getmembers #879

merged 7 commits into from
Jan 18, 2021

Conversation

sethaxen
Copy link
Contributor

Fixes #857 by using dir to get names of properties instead of getmembers, which also gets the properties themselves and therefore errors when properties are optional.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #879 (173542e) into master (ead312f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   67.63%   67.61%   -0.02%     
==========================================
  Files          20       20              
  Lines        1965     1967       +2     
==========================================
+ Hits         1329     1330       +1     
- Misses        636      637       +1     
Flag Coverage Δ
unittests 67.61% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PyCall.jl 69.75% <100.00%> (+0.18%) ⬆️
src/conversions.jl 63.13% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead312f...173542e. Read the comment docs.

@stevengj stevengj merged commit 5d227fc into JuliaPy:master Jan 18, 2021
@sethaxen sethaxen deleted the usedir branch January 18, 2021 23:46
@sethaxen
Copy link
Contributor Author

@stevengj can a new release be tagged as well?

@sethaxen
Copy link
Contributor Author

@stevengj can you tag a new release? One of my packages needs this fix.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (ead312f) to head (173542e).
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   67.63%   67.61%   -0.02%     
==========================================
  Files          20       20              
  Lines        1965     1967       +2     
==========================================
+ Hits         1329     1330       +1     
- Misses        636      637       +1     
Flag Coverage Δ
unittests 67.61% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propertynames fails for "optional" property decorators
4 participants